linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Peter Xu <peterx@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	David Hildenbrand <david@redhat.com>,
	Mike Rapoport <rppt@linux.vnet.ibm.com>,
	Mike Kravetz <mike.kravetz@oracle.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Nadav Amit <nadav.amit@gmail.com>,
	Axel Rasmussen <axelrasmussen@google.com>
Subject: Re: [PATCH] mm/uffd: Reset write protection when unregister with wp-mode
Date: Thu, 11 Aug 2022 15:01:05 -0700	[thread overview]
Message-ID: <20220811150105.ce8636e7f101545d12d6cfac@linux-foundation.org> (raw)
In-Reply-To: <YvVzQqXp81zgA/DP@xz-m1.local>

On Thu, 11 Aug 2022 17:23:14 -0400 Peter Xu <peterx@redhat.com> wrote:

> On Thu, Aug 11, 2022 at 02:11:44PM -0700, Andrew Morton wrote:
> > On Thu, 11 Aug 2022 16:13:40 -0400 Peter Xu <peterx@redhat.com> wrote:
> > 
> > > I added a Fixes upon introducing of uffd-wp shmem+hugetlbfs because that's
> > > the only issue reported so far and that's the commit David's reproducer
> > > will start working (v5.19+).  But the whole idea actually applies to not
> > > only file memories but also anonymous.  It's just that we don't need to fix
> > > anonymous prior to v5.19- because there's no known way to exploit.
> > 
> > I added a cc:stable to this.
> 
> Thanks, Andrew.  I'll remember to do so in future patches when Fixes apply.
> 

Only if we want the fix to be backported!

I mean, it's legitimate and sensible to add a Fixes: to a patch which
fixes a comment typo, but we don't want that backported.

And sometimes a fix is too complex and the problem too small to warrant
a backport, but we still want that Fixes: tag.


      reply	other threads:[~2022-08-11 22:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-11 20:13 Peter Xu
2022-08-11 21:11 ` Andrew Morton
2022-08-11 21:23   ` Peter Xu
2022-08-11 22:01     ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220811150105.ce8636e7f101545d12d6cfac@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=aarcange@redhat.com \
    --cc=axelrasmussen@google.com \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mike.kravetz@oracle.com \
    --cc=nadav.amit@gmail.com \
    --cc=peterx@redhat.com \
    --cc=rppt@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox