From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAC5AC25B07 for ; Thu, 11 Aug 2022 07:29:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5CDD58E0002; Thu, 11 Aug 2022 03:29:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 57DBD8E0001; Thu, 11 Aug 2022 03:29:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46D118E0002; Thu, 11 Aug 2022 03:29:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 36B7D8E0001 for ; Thu, 11 Aug 2022 03:29:55 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 12D37120792 for ; Thu, 11 Aug 2022 07:29:55 +0000 (UTC) X-FDA: 79786487550.27.DBF12FD Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf05.hostedemail.com (Postfix) with ESMTP id 95F2B100180 for ; Thu, 11 Aug 2022 07:29:54 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id B92CA68AA6; Thu, 11 Aug 2022 09:29:51 +0200 (CEST) Date: Thu, 11 Aug 2022 09:29:51 +0200 From: Christoph Hellwig To: Baoquan He Cc: Michal Hocko , Christoph Hellwig , Andrew Morton , John Donnelly , David Hildenbrand , linux-mm@kvack.org, LKML Subject: Re: [PATCH] dma/pool: do not complain if DMA pool is not allocated Message-ID: <20220811072951.GC13886@lst.de> References: <20220325122559.14251-1-mhocko@kernel.org> <20220325164856.GA16800@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660202994; a=rsa-sha256; cv=none; b=m6G/mqb0+E0V8elcTR0VHZzxIR/16UJ+8BeEWl31sVoXya3ZXmR9k1F54R6c2BAT2YwpuL KR+J1c/70pLxgKkddmiKVoCtksDrnfwgSovON4JjzzyNFxTe2bjDJ700ChF0VvyO602C/d SUTAFy2e3htEAAb6i6DRoVGqI3nkOY4= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; spf=none (imf05.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660202994; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t7ux9tMGFQ1gUrUi1YV8YUlfHsqn0XWShz6JV8r4xQI=; b=Ynruu1zBr4bC3fhxi1UOMukGPU21hyJKUZDPziRT08IP9Mr5KPZ1xo+vQuIl5uH79mttwJ O02ALNfu6CgSqJUKoK8Y4LCleUz6XNO31nZEuR4ZoMzLrosojFaf16lra85JM3v6bH6jYX 3guJ93wBm4WKlza1UYugqQBRU0cNFXo= X-Rspamd-Queue-Id: 95F2B100180 Authentication-Results: imf05.hostedemail.com; dkim=none; spf=none (imf05.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: psw9ytf3adzrfqzed6f1matbdxucqajj X-HE-Tag: 1660202994-460487 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 5aa4c2ecf5c7..93af781f9445 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -2761,7 +2761,6 @@ config ISA_BUS > # x86_64 have no ISA slots, but can have ISA-style DMA. > config ISA_DMA_API > bool "ISA-style DMA support" if (X86_64 && EXPERT) > - default y This looks sensible to me, but you'll have to get it past Linus. > -#ifdef CONFIG_ZONE_DMA > +#if defined(CONFIG_ZONE_DMA) && defined(CONFIG_ISA_DMA_API) > max_zone_pfns[ZONE_DMA] = min(MAX_DMA_PFN, max_low_pfn); > +#else > + max_zone_pfns[ZONE_DMA] = min(MAX_DMA32_PFN, max_low_pfn); > #endif But this simply can't work at all.