From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB271C19F2D for ; Thu, 11 Aug 2022 08:22:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 593B78E0002; Thu, 11 Aug 2022 04:22:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5436A8E0001; Thu, 11 Aug 2022 04:22:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 40BCC8E0002; Thu, 11 Aug 2022 04:22:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 334EB8E0001 for ; Thu, 11 Aug 2022 04:22:11 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id EDFF7A165C for ; Thu, 11 Aug 2022 08:22:10 +0000 (UTC) X-FDA: 79786619220.22.F086F70 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 91EAC12017C for ; Thu, 11 Aug 2022 08:22:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660206130; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EEtmDPDEfm6ZN6xmlgAYrdfRiGRj8DNGtUE2f/V2pis=; b=OlBwhTQv4TBNrROlAi/UU7b+aB481OFK5X8MD0NSjahE9KMn+AZhvdlW1iFbmT4rnV8Lg6 h4MWsHXBytVA9gj+N11lfd9QHadbbM6khCfO/E38MhimuOvH5/J0VTB2isT4/rkAfoUFg+ PLxAIWvJaDYMKXEJcPbaqngbPg50X6w= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-553-4V7mKBt6Ox2r5aYE5Q2roA-1; Thu, 11 Aug 2022 04:22:06 -0400 X-MC-Unique: 4V7mKBt6Ox2r5aYE5Q2roA-1 Received: by mail-ed1-f69.google.com with SMTP id j19-20020a05640211d300b0043ddce5c23aso10425945edw.14 for ; Thu, 11 Aug 2022 01:22:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=EEtmDPDEfm6ZN6xmlgAYrdfRiGRj8DNGtUE2f/V2pis=; b=g7eshdmhJN+9Q7rY/5MMFyQsBUsLilliCTQ5qUknDjnYPyNMXBJWAJZSg5Yyc9L9TL FzMeLU31mhHStLBFremi9etUvEXHMSqVw4Uk+Wh1TGFktBxGtmlwbhBeZWEhdxkfLRs9 v1xSqViEm6PgZtD+floyv4gSCkdi5716ydMiWlmeE3zQdZp+aV8fj0UeQlQYELyCbhMT tSRahLXKjKa2RoW4NBpBSTiw3kYVVrgvhcGLmZqdcrALg1+iyR7GPmr6iVGOgb22DnL7 slc0H3+xIf4ZVOWFWtcM+AFeShSdFDz2XBVCfntrYps5t2Sd0z108Xd9f90dcInWxaOq uZug== X-Gm-Message-State: ACgBeo1yotXqZpiuXcYt6KIkZyhj66uOJ8iKoSds6E+7Ny27Ey/h4rmb 0T1mUh+JnVwXiNmop4S3cu4qL45DLoCEgxQHRhi940eItnjBw6KlDL05NJCnJIkwHyV5+6S6kXz 7orLZVdWfYr4= X-Received: by 2002:a17:906:8477:b0:730:a658:b286 with SMTP id hx23-20020a170906847700b00730a658b286mr23573592ejc.646.1660206124973; Thu, 11 Aug 2022 01:22:04 -0700 (PDT) X-Google-Smtp-Source: AA6agR6y/Q+GVb2CZ/UTdsNXn1wHQDoBdSdMDWesZKQeNKJjBCRfbKXoa2c/80fT12UpDm6WNKSfPw== X-Received: by 2002:a17:906:8477:b0:730:a658:b286 with SMTP id hx23-20020a170906847700b00730a658b286mr23573585ejc.646.1660206124748; Thu, 11 Aug 2022 01:22:04 -0700 (PDT) Received: from redhat.com ([2.52.152.113]) by smtp.gmail.com with ESMTPSA id g18-20020a17090604d200b0072fb3704e49sm3237910eja.46.2022.08.11.01.22.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Aug 2022 01:22:04 -0700 (PDT) Date: Thu, 11 Aug 2022 04:22:00 -0400 From: "Michael S. Tsirkin" To: Stefano Garzarella Cc: kernel test robot , llvm@lists.linux.dev, kbuild-all@lists.01.org, Linux Memory Management List Subject: Re: [linux-next:master 14849/15097] drivers/vdpa/vdpa_sim/vdpa_sim_blk.c:201:3: error: expected expression Message-ID: <20220811042124-mutt-send-email-mst@kernel.org> References: <202208111501.5PSP1WaM-lkp@intel.com> <20220811081217.ugn7vslc2nlqv6l3@sgarzare-redhat> MIME-Version: 1.0 In-Reply-To: <20220811081217.ugn7vslc2nlqv6l3@sgarzare-redhat> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660206130; a=rsa-sha256; cv=none; b=UD42a1naBu8cAY00qYvipEbWv9hQSLkma9/sn2duPsCif1pl1JDS6atlmgXHxiFrVfjF1O OmGXiqNK28FfA4qVYoyx7Nkl4o+zvZgTGserRETZm+raf2zELLCNsfYK27tbdtBtnlamKc TPn/uQV4Sk3Teb9K1d4CpF8aPew4OKg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OlBwhTQv; spf=pass (imf29.hostedemail.com: domain of mst@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=mst@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660206130; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EEtmDPDEfm6ZN6xmlgAYrdfRiGRj8DNGtUE2f/V2pis=; b=fyQuqnhRbum42f+8EBqiAMwmW26+9DFnqStiCEXuV2kcaTHyEJTe+EqIgCIetBjRxHc5AD GzHRP0CwUAGlg4zkrZUBbSlZIpy7pyNPl1DjBFTrHRxBDB9cZXBR59hWUxiTUAUB+joWoC aWxOoIcZX1+RsrvMcmxnwmShRdMzMYY= X-Rspam-User: X-Stat-Signature: mf4m4ckqgdeppthhtp3q1xw8afpc3si3 X-Rspamd-Queue-Id: 91EAC12017C Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OlBwhTQv; spf=pass (imf29.hostedemail.com: domain of mst@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=mst@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam01 X-HE-Tag: 1660206130-28822 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 11, 2022 at 10:12:17AM +0200, Stefano Garzarella wrote: > Hi Michael, > > On Thu, Aug 11, 2022 at 03:46:35PM +0800, kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > head: 40d43a7507e1547dd45cb02af2e40d897c591870 > > commit: d79b32c2e4a4e66d5678410cd45815c1c2375196 [14849/15097] vdpa_sim_blk: add support for discard and write-zeroes > > config: i386-randconfig-a015 (https://download.01.org/0day-ci/archive/20220811/202208111501.5PSP1WaM-lkp@intel.com/config) > > compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 5f1c7e2cc5a3c07cbc2412e851a7283c1841f520) > > reproduce (this is a W=1 build): > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=d79b32c2e4a4e66d5678410cd45815c1c2375196 > > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > > git fetch --no-tags linux-next master > > git checkout d79b32c2e4a4e66d5678410cd45815c1c2375196 > > # save the config file > > mkdir build_dir && cp config build_dir/.config > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/vdpa/vdpa_sim/ > > > > If you fix the issue, kindly add following tag where applicable > > Reported-by: kernel test robot > > > > All error/warnings (new ones prefixed by >>): > > > > > > drivers/vdpa/vdpa_sim/vdpa_sim_blk.c:201:3: error: expected expression > > struct virtio_blk_discard_write_zeroes range; > > ^ > > > > drivers/vdpa/vdpa_sim/vdpa_sim_blk.c:204:25: error: use of undeclared identifier 'range' > > if (to_pull != sizeof(range)) { > > ^ > > drivers/vdpa/vdpa_sim/vdpa_sim_blk.c:207:21: error: use of undeclared identifier 'range' > > to_pull, sizeof(range)); > > ^ > > drivers/vdpa/vdpa_sim/vdpa_sim_blk.c:212:60: error: use of undeclared identifier 'range' > > bytes = vringh_iov_pull_iotlb(&vq->vring, &vq->out_iov, &range, > > ^ > > drivers/vdpa/vdpa_sim/vdpa_sim_blk.c:222:38: error: use of undeclared identifier 'range' > > sector = vdpasim64_to_cpu(vdpasim, range.sector); > > ^ > > drivers/vdpa/vdpa_sim/vdpa_sim_blk.c:224:43: error: use of undeclared identifier 'range' > > num_sectors = vdpasim32_to_cpu(vdpasim, range.num_sectors); > > ^ > > drivers/vdpa/vdpa_sim/vdpa_sim_blk.c:225:37: error: use of undeclared identifier 'range' > > flags = vdpasim32_to_cpu(vdpasim, range.flags); > > ^ > > > > drivers/vdpa/vdpa_sim/vdpa_sim_blk.c:202:7: warning: mixing declarations and code is incompatible with standards before C99 [-Wdeclaration-after-statement] > > u32 num_sectors, flags; > > ^ > > 1 warning and 7 errors generated. > > I'll send followup patches to fix this issue and another that I found > building with C=2 (virtio_blk_discard_write_zeroes fields are __leX not > __virtioX, so I should use leX_to_cpu). > > Is that okay or should I re-send the original series fixed? > > Thanks, Resend, I dropped them for now. Unlikely to be included in this window, at this point. -- MST