From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00BB5C00140 for ; Wed, 10 Aug 2022 17:07:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8CCDB6B0072; Wed, 10 Aug 2022 13:07:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 87D516B0073; Wed, 10 Aug 2022 13:07:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 71D166B0074; Wed, 10 Aug 2022 13:07:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 622776B0072 for ; Wed, 10 Aug 2022 13:07:11 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3EDD11C5E30 for ; Wed, 10 Aug 2022 17:07:11 +0000 (UTC) X-FDA: 79784313462.08.489CA01 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) by imf15.hostedemail.com (Postfix) with ESMTP id CB21CA0178 for ; Wed, 10 Aug 2022 17:07:10 +0000 (UTC) Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-31f58599ad3so131872507b3.20 for ; Wed, 10 Aug 2022 10:07:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:from:to:cc; bh=NDKj9WvDVcpp72e/Jq/GTiPcROFKNcyaGjJEdm/L+Ts=; b=X9e/GgluQJANDKFV0jFwlXW00XKEjHhjfO/brvre3Gw5uNpgSHsWoIi8QDqA4wt8zk CexRXMYl9XeZtcQ1hg2op+YKm38bo0z4cWq8rCwG5+wrjzrUOJSInGLpcRNPTKVPxD8J TQJ02+pc3eBFY+XQ/1/w34xfwA9dtKzVGX0nmZGQMjB+MdAlDz3bkz8mMF91BWMCEFEt j+/QOmPEv9/ryDVEy/xsPy0lJGhPCSW59i60SFbFZp6JphxcmA71yWhTiw3oKJzNgwnu XoWreqyMPwsntxrmAakC9gUG0oYWZ4lVDH7xx1MiVudxtJgaYpbfsUUkgBjahjMLoLq3 i1YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:x-gm-message-state:from:to:cc; bh=NDKj9WvDVcpp72e/Jq/GTiPcROFKNcyaGjJEdm/L+Ts=; b=Ts9OC8MZcR30Hpj5O6hKSHwMGM4Ga5GVjmshJeuHXA04TR1WXaxwxuXq10FXl+lTrw ZfG5fOAez4Yj7hID0Fj8grqk+QSutsFaWmKH80BwOlRZ/xLwDrWd2g6hC5CmmadnICBg EqPK2HubDE590d8UoyPYuZOp4nvEr3pU0wE8sE/T4G4ec5/Sog/FF66p31w3yrove3mB ALi4gPLxciPIQLeQxaMkxNTpHOtbpogPZ+qK3wE08vy82YHNtUJ3TLbIEFpgVV8RryTM IZ2g5MQwrpT41lbUdKe9JSXVL28YSxwbXIc1UJdV14N/rScVwc4Qsl6BFXRr+/yYd7eZ k3fg== X-Gm-Message-State: ACgBeo1KMFZ/VVFFnNkJb2budHEWpX2DmJWQxrY8o3Kxvzohcj64ZeeW YZjP0i2t874hKjsFwgs4B+Zb+WsywL9TWQ== X-Google-Smtp-Source: AA6agR40+GyN7iMi/+y8+SEnXgz5d1sWTF6KBR9mZOrYJz5MsqI+gArikvEGD0ucx6p3tDpnZos8Ahi8w8vEZQ== X-Received: from shakeelb.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:28b]) (user=shakeelb job=sendgmr) by 2002:a25:cb4f:0:b0:677:5f49:99e6 with SMTP id b76-20020a25cb4f000000b006775f4999e6mr25934323ybg.338.1660151229736; Wed, 10 Aug 2022 10:07:09 -0700 (PDT) Date: Wed, 10 Aug 2022 17:07:06 +0000 In-Reply-To: <20220810151840.16394-6-laoar.shao@gmail.com> Message-Id: <20220810170706.ikyrsuzupjwt65h7@google.com> Mime-Version: 1.0 References: <20220810151840.16394-1-laoar.shao@gmail.com> <20220810151840.16394-6-laoar.shao@gmail.com> Subject: Re: [PATCH bpf-next 05/15] bpf: Fix incorrect mem_cgroup_put From: Shakeel Butt To: Yafang Shao Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, songmuchun@bytedance.com, akpm@linux-foundation.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="us-ascii" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660151230; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NDKj9WvDVcpp72e/Jq/GTiPcROFKNcyaGjJEdm/L+Ts=; b=ioCRv5qlLFzzMFfebMuRt8Th111vC3RxT0EfNZRGBrO8OvQ+hvu6WndzrB3E/3FB52DP+M OHdUgRAPnMeFYUTmX+ab3jqA3EG8ngqv04BrAAr5fbzlrsiUfMGBVXbhXwdZJALslWxlVO IRd0XptdkDLNyRXrTW7vwGri2M1zs80= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="X9e/Gglu"; spf=pass (imf15.hostedemail.com: domain of 3veXzYggKCHYmbUeYYfVaiiafY.Wigfchor-ggepUWe.ila@flex--shakeelb.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3veXzYggKCHYmbUeYYfVaiiafY.Wigfchor-ggepUWe.ila@flex--shakeelb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660151230; a=rsa-sha256; cv=none; b=3I5/7ojn5NFyyAbApuZvda0a8SfHvt1BzZAfJTdjfuxKBxXmmApoHh2I56IDWBqx8cITlV AS/4uzI9zGuw2h7m+uFT/0bX/8e6dnl8yAG7pt5Zffzkc4BmpWXDu3XhzT5h8aOk73uscg XBzS6ZmdDea4HiGQ7julqEyopVZXw+I= X-Stat-Signature: fe1crtwhh9nh3z9ur7bzhk156idhqn8m X-Rspamd-Queue-Id: CB21CA0178 Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="X9e/Gglu"; spf=pass (imf15.hostedemail.com: domain of 3veXzYggKCHYmbUeYYfVaiiafY.Wigfchor-ggepUWe.ila@flex--shakeelb.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=3veXzYggKCHYmbUeYYfVaiiafY.Wigfchor-ggepUWe.ila@flex--shakeelb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1660151230-47772 X-Bogosity: Ham, tests=bogofilter, spamicity=0.015808, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 10, 2022 at 03:18:30PM +0000, Yafang Shao wrote: > The memcg may be the root_mem_cgroup, in which case we shouldn't put it. No, it is ok to put root_mem_cgroup. css_put already handles the root cgroups.