From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74364C00140 for ; Wed, 10 Aug 2022 21:31:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA5308E0002; Wed, 10 Aug 2022 17:31:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B2CE08E0001; Wed, 10 Aug 2022 17:31:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CFA78E0002; Wed, 10 Aug 2022 17:31:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 890FB8E0001 for ; Wed, 10 Aug 2022 17:31:09 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5BEF5A0159 for ; Wed, 10 Aug 2022 21:31:09 +0000 (UTC) X-FDA: 79784978658.07.D607AE1 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf28.hostedemail.com (Postfix) with ESMTP id 8CF36C0161 for ; Wed, 10 Aug 2022 21:31:05 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9293D61531; Wed, 10 Aug 2022 21:31:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0D28C433C1; Wed, 10 Aug 2022 21:31:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1660167064; bh=NK5lGETgJ8mV70zk2IetcbwhCrJmhDXBruOENzA6gx0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HgvldGL+0W0bZUXB4GMdvA8WAn0MnQAf5RshM9DXqFgYnCo9exBMfdSF5xuPBY0QL BOzOf+35p230OeMwcerWHA4EvX3W682/mJqLmg3qlMdVW2QtQOIm8EXMD1EbWk9dnC A6SbZldUcxeYrFpCp+DVbqLGmNVngiJ3PzXez/8Y= Date: Wed, 10 Aug 2022 14:31:02 -0700 From: Andrew Morton To: Charan Teja Kalla Cc: , , , , , Subject: Re: [PATCH] mm/cma_debug: show complete cma name in debugfs directories Message-Id: <20220810143102.595072879e4bae7f7c46e3e6@linux-foundation.org> In-Reply-To: <1660152485-17684-1-git-send-email-quic_charante@quicinc.com> References: <1660152485-17684-1-git-send-email-quic_charante@quicinc.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660167069; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YshFOUWfjj6rMzDFqR1WUUSqF3Kl3ebmEh2tAp2rrac=; b=eTktK71xxV2kJ6KmvXy0OO2oW/hY3IS4rG0oSXaCLy3Cs2Q5NzP4qOY+tDdKMgw9Ax1x4x WYzbi/0Zm25PBTgufn95VTj+KvykKLi0ft9GdEEfUoJgK/lyZWF/P4vn3nU5acrSSWzapU xtNBN6MeTosYIUUNVhVRQqpierRQOxc= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=HgvldGL+; dmarc=none; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660167069; a=rsa-sha256; cv=none; b=uPhw26N9yYod2PFx6nZgMgfFokBm7VjeHsVWiZxTUdIKcUDqnxxGshJ8tEG3k1Cy5WCyYR 7HK42LQnQw0y6RfzccNXXi3KVjkDVQKDvQ1Gd/3jWqS19z/evjA9vZvhVWM0FhbKH4pi44 dZGrQ/+30BF3TlK0bhWLUD4csW7yMwU= X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 8CF36C0161 X-Rspam-User: X-Stat-Signature: qqndotdgai4tf914h9xrwk5kij3odizt Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=HgvldGL+; dmarc=none; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-HE-Tag: 1660167065-861010 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 10 Aug 2022 22:58:05 +0530 Charan Teja Kalla wrote: > Currently only 12 characters of the cma name is being used as the debug > directories where as the cma name can be of length CMA_MAX_NAME(=64) > characters. One side problem with this is having 2 cma's with first > common 12 characters would end up in trying to create directories with > same name and fails with -EEXIST thus can limit cma debug functionality. I guess so. There might be back-compatibility issues, but it's debugfs... > Also drop 'cma-' prefix for the cma debug directories as they are > clearly evident that they are for cma debug through creating them in > /sys/kernel/debug/cma/ path. I guess so. But please run `grep -r cma- Documentation'