From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 779D8C19F2D for ; Tue, 9 Aug 2022 13:56:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 906886B0072; Tue, 9 Aug 2022 09:56:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B4846B0073; Tue, 9 Aug 2022 09:56:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77C958E0001; Tue, 9 Aug 2022 09:56:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 669546B0072 for ; Tue, 9 Aug 2022 09:56:22 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 397E7140CE0 for ; Tue, 9 Aug 2022 13:56:22 +0000 (UTC) X-FDA: 79780203804.30.5144B9C Received: from smtp-fw-6001.amazon.com (smtp-fw-6001.amazon.com [52.95.48.154]) by imf27.hostedemail.com (Postfix) with ESMTP id AA0BB4017B for ; Tue, 9 Aug 2022 13:56:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1660053382; x=1691589382; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=odYNCkcIAQcBKQptQexLin/WRKzdil3fPD/Uqu4HkkI=; b=aEFzcalQ97hAG4bs2JdRqWh1VYvGCJfnHi664tJe/d/FqlvKXVw2DGNF 0sl4Mb77jMqaH3pw2ip5ztIa2t/6kYAuQ4kVNeWE0WSFPGYG3tWmustKj S1MyZYCrFhh3nnAJx34sgJL686GkGPuP7OCHq+najECXbN6sNphKBVeTe U=; Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-iad-1a-b09d0114.us-east-1.amazon.com) ([10.43.8.2]) by smtp-border-fw-6001.iad6.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2022 13:56:08 +0000 Received: from EX13D24EUC003.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1a-b09d0114.us-east-1.amazon.com (Postfix) with ESMTPS id 35EAD80383; Tue, 9 Aug 2022 13:55:58 +0000 (UTC) Received: from dev-dsk-sabrapan-1c-164a86ac.eu-west-1.amazon.com (10.43.162.227) by EX13D24EUC003.ant.amazon.com (10.43.164.217) with Microsoft SMTP Server (TLS) id 15.0.1497.36; Tue, 9 Aug 2022 13:55:48 +0000 From: Sabin Rapan To: CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH Part2 v6 26/49] KVM: SVM: Add KVM_SEV_SNP_LAUNCH_UPDATE command Date: Tue, 9 Aug 2022 13:55:35 +0000 Message-ID: <20220809135535.88234-1-sabrapan@amazon.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [10.43.162.227] X-ClientProxiedBy: EX13D40UWC003.ant.amazon.com (10.43.162.246) To EX13D24EUC003.ant.amazon.com (10.43.164.217) Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660053381; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=odYNCkcIAQcBKQptQexLin/WRKzdil3fPD/Uqu4HkkI=; b=lY41hcCVJj8x/XjD39vlCeVUThslm4kUiYqH1mSJH3kem2stWUQLXYZeRFeWqk0ie2wuwO HSpVcCjbaJxr+RYnfk4ZjTZo/QoV6UepdygFvqoT9SWm8rFkmCisxoYcFAcBOXIqEvl39P mwKSRiC+Qa2M37j2orKC3CRjAowlM5M= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=amazon.com header.s=amazon201209 header.b=aEFzcalQ; dmarc=pass (policy=quarantine) header.from=amazon.com; spf=pass (imf27.hostedemail.com: domain of "prvs=213a8a0d2=sabrapan@amazon.com" designates 52.95.48.154 as permitted sender) smtp.mailfrom="prvs=213a8a0d2=sabrapan@amazon.com" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660053381; a=rsa-sha256; cv=none; b=uam+cuVUtiSOJ287+Q0+wikCgYo/xrQLkuGvqICYnrnfBaSjg//97xVxFkpWtGHlzXA8tB XiJ0kb0PdK1dmxDLMODBDHcWBhaWoY8C35I3qHB5pQ7j6HQNy+bsn2HB9kb2zbm6tWfFdV DaSiL+oki+Q+PVun4Zh8HOdyN0JS01A= Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=amazon.com header.s=amazon201209 header.b=aEFzcalQ; dmarc=pass (policy=quarantine) header.from=amazon.com; spf=pass (imf27.hostedemail.com: domain of "prvs=213a8a0d2=sabrapan@amazon.com" designates 52.95.48.154 as permitted sender) smtp.mailfrom="prvs=213a8a0d2=sabrapan@amazon.com" X-Rspamd-Server: rspam02 X-Stat-Signature: qankwa3wrqxwisfzth5z451sjoc5fnqa X-Rspamd-Queue-Id: AA0BB4017B X-Rspam-User: X-HE-Tag: 1660053381-139765 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > +static bool is_hva_registered(struct kvm *kvm, hva_t hva, size_t len) > +{ > + struct kvm_sev_info *sev = &to_kvm_svm(kvm)->sev_info; > + struct list_head *head = &sev->regions_list; > + struct enc_region *i; > + > + lockdep_assert_held(&kvm->lock); > + > + list_for_each_entry(i, head, list) { > + u64 start = i->uaddr; > + u64 end = start + i->size; > + > + if (start <= hva && end >= (hva + len)) > + return true; > + } > + > + return false; > +} Since KVM_MEMORY_ENCRYPT_REG_REGION should be called for every memory region the user gives to kvm, is the regions_list any different from kvm's memslots? > + > +static int snp_launch_update(struct kvm *kvm, struct kvm_sev_cmd *argp) > +{ > + struct kvm_sev_info *sev = &to_kvm_svm(kvm)->sev_info; > + struct sev_data_snp_launch_update data = {0}; > + struct kvm_sev_snp_launch_update params; > + unsigned long npages, pfn, n = 0; > + int *error = &argp->error; > + struct page **inpages; > + int ret, i, level; > + u64 gfn; > + > + if (!sev_snp_guest(kvm)) > + return -ENOTTY; > + > + if (!sev->snp_context) > + return -EINVAL; > + > + if (copy_from_user(¶ms, (void __user *)(uintptr_t)argp->data, sizeof(params))) > + return -EFAULT; > + > + /* Verify that the specified address range is registered. */ > + if (!is_hva_registered(kvm, params.uaddr, params.len)) > + return -EINVAL; > + > + /* > + * The userspace memory is already locked so technically we don't > + * need to lock it again. Later part of the function needs to know > + * pfn so call the sev_pin_memory() so that we can get the list of > + * pages to iterate through. > + */ > + inpages = sev_pin_memory(kvm, params.uaddr, params.len, &npages, 1); > + if (!inpages) > + return -ENOMEM; sev_pin_memory will call pin_user_pages() which fails for PFNMAP vmas that you would get if you use memory allocated from an IO driver. Using gfn_to_pfn instead will make this work with vmas backed by pages or raw pfn mappings. Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.