From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E833EC00140 for ; Mon, 8 Aug 2022 18:40:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3FA4B8E0001; Mon, 8 Aug 2022 14:40:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A9506B0073; Mon, 8 Aug 2022 14:40:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24A708E0001; Mon, 8 Aug 2022 14:40:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 102226B0071 for ; Mon, 8 Aug 2022 14:40:40 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C3786A0500 for ; Mon, 8 Aug 2022 18:40:39 +0000 (UTC) X-FDA: 79777291398.13.E982CCD Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf16.hostedemail.com (Postfix) with ESMTP id 5EE9E180162 for ; Mon, 8 Aug 2022 18:40:39 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7518461262; Mon, 8 Aug 2022 18:40:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81C3DC433C1; Mon, 8 Aug 2022 18:40:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659984037; bh=NeZb0DNW+wBBbBivljipLAuWjXhHR+VkQ+vg21O7Lzk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Cmhafj2K0/21CO1Au6QseEfKeeWWpWSHPkUuM/MkUNqCmIFq6BrbRorJpBdVT5B6d mTrSAr2P7pe+p+tB1sUYRwU4EW/B1aK2A48tVkL+Einz/PL9D12IXCRrpvjLXk2ai2 rHGdDPul4hT4Yl+6+5Aqju/2OtjmvcOpf36JfLGdfsymogYti8tG2nw/GZ8kCEczUb rSYVchcwSpIp+mHy+6Uyin/v44RI2mpAEvHX3nTNuFaolvoQ9o/d+VyVFlTtbp3LzP 4tYxy9HA/les28+3BI5Pp73dDVwt/pK6ZqXuHysG4SiLhMrpWxbsBMbMZbgRTl27YG x+WAtk5W7PbbA== Received: by pali.im (Postfix) id 693D3F13; Mon, 8 Aug 2022 20:40:34 +0200 (CEST) Date: Mon, 8 Aug 2022 20:40:34 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: linux-mm@kvack.org Cc: Ash Logan , paulus@samba.org, mpe@ellerman.id.au, christophe.leroy@csgroup.eu, robh+dt@kernel.org, benh@kernel.crashing.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, j.ne@posteo.net Subject: Re: [PATCH 11/12] powerpc: wiiu: don't enforce flat memory Message-ID: <20220808184034.lskqrk6z3gb5q76r@pali> References: <20220302044406.63401-1-ash@heyquark.com> <20220302044406.63401-12-ash@heyquark.com> <20220513224353.n56qg5fhstbaqhfz@pali> <20220520080454.c3cqodsdbfbkmg56@pali> <935b426a-6c64-beb0-907f-8c3f0a089ab7@heyquark.com> <20220520123002.rd46p5ty6wumi7cc@pali> <20220609222420.ponpoodiqmaqtwht@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220609222420.ponpoodiqmaqtwht@pali> User-Agent: NeoMutt/20180716 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659984039; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HhNb4DqslKQXOed7jGI3BJ61mKoWDMecIrYCXiXIbfU=; b=an1PuZwgAxQ+Je8P5e+e1HwNuf4fWjTP93KD+I4qJptsYLJtT/6EESMurnrTcg6sXdTKbr o/9E7C/Rqhzb/yKWldbQn5adhDIDoaw0dcIsk5N/jFhPFAX301BfcFoIHSCUkZouOzQ+VF MBaDvB7mJV0PT/nNF2Wz1RTPJd3SghQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Cmhafj2K; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of pali@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=pali@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659984039; a=rsa-sha256; cv=none; b=AkM+2Fgm+ARXLixKA/wxfYzBO2utws4fC8IXZtTOByLlFYQOQJ+vh/mFOwqitSMVZCmJ0U T5U23lZ6D9k3vXXDh9iW7YEJ1eGthx+iSmwvKrWT1ZL7kkncWfk2N2KeJZB97ZK1cJ6BTX MI0uJ+NQOloS0iPSyn9KFLDTZ6Xm270= Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Cmhafj2K; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of pali@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=pali@kernel.org X-Rspamd-Server: rspam02 X-Stat-Signature: eex3ga3b5jsuey18yab47fetksq5nm7p X-Rspamd-Queue-Id: 5EE9E180162 X-Rspam-User: X-HE-Tag: 1659984039-575150 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Friday 10 June 2022 00:24:20 Pali Rohár wrote: > On Friday 20 May 2022 14:30:02 Pali Rohár wrote: > > + linux-mm > > > > Do you know what are requirements for kernel to support non-contiguous > > memory support and what is needed to enable it for 32-bit powerpc? > > Any hints? PING? > > Currently powerpc arch code does not support "memblock.memory.cnt > 1" > > except for WII which seems like a hack... See below. > > > > On Friday 20 May 2022 20:44:04 Ash Logan wrote: > > > On 20/5/22 18:04, Pali Rohár wrote: > > > > On Friday 20 May 2022 13:41:04 Ash Logan wrote: > > > >> On 14/5/22 08:43, Pali Rohár wrote: > > > >>> On Wednesday 02 March 2022 15:44:05 Ash Logan wrote: > > > >>>> pgtable_32.c:mapin_ram loops over each valid memory range, which means > > > >>>> non-contiguous memory just works. > > > >>> > > > >>> Hello! Does it mean that non-contiguous memory works for any 32-bit > > > >>> powerpc platform, and not only for wiiu? If yes, should not be > > > >>> non-contiguous memory support enabled for all 32-bit ppc boards then? > > > >> > > > >> Hi! Sorry for my delayed response. As best I can tell, it does indeed > > > >> Just Work, but I have only been able to test on wiiu which is missing a > > > >> lot of features other boards have (like PCI) - so it's possible there's > > > >> still an assumption elsewhere in the kernel that I haven't hit. > > > >> > > > >> As best I can tell, the Wii and Wii U are the only 32-bit powerpc boards > > > >> out there where it's even possible to have non-contiguous memory. > > > > > > > > What is the reason that those two boards are the **only**? Is there some > > > > specific requirement from bootloader or hardware to "enable" > > > > non-contiguous memory support? > > > > > > Not that I know of, I was just saying that I was only aware of those two > > > boards where the memory map isn't contiguous, and that is the only place > > > where it has been tested. Evidently you know of another board! > > > > > > > I'm interested in enabling non-contiguous memory support for P2020-based > > > > board as it has gaps in its 32-bit memory layout and which could be used > > > > for RAM mapping when 4GB DDR3 module is plugged in (default is 2GB). > > > > > > If it's like the Wii or Wii U (some memory at 0, a gap for MMIO or > > > whatever, then more memory at a higher address) then you should try a > > > patch along these lines, because barring the unknowns I mentioned before > > > it should work. At least as far as I'm aware ;) > > > > > > >>>> Signed-off-by: Ash Logan > > > >>>> --- > > > >>>> arch/powerpc/mm/init_32.c | 4 ++-- > > > >>>> 1 file changed, 2 insertions(+), 2 deletions(-) > > > >>>> > > > >>>> diff --git a/arch/powerpc/mm/init_32.c b/arch/powerpc/mm/init_32.c > > > >>>> index 3d690be48e84..59a84629d9a0 100644 > > > >>>> --- a/arch/powerpc/mm/init_32.c > > > >>>> +++ b/arch/powerpc/mm/init_32.c > > > >>>> @@ -125,10 +125,10 @@ void __init MMU_init(void) > > > >>>> * lowmem_end_addr is initialized below. > > > >>>> */ > > > >>>> if (memblock.memory.cnt > 1) { > > > >>>> -#ifndef CONFIG_WII > > > >>>> +#if !defined(CONFIG_WII) && !defined(CONFIG_WIIU) > > > >>>> memblock_enforce_memory_limit(memblock.memory.regions[0].size); > > > >>>> pr_warn("Only using first contiguous memory region\n"); > > > >>>> -#else > > > >>>> +#elif defined(CONFIG_WII) > > > >>>> wii_memory_fixups(); > > > >>>> #endif > > > >>>> } > > > >>>> -- > > > >>>> 2.35.1 > > > >>>>