linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Brian Geffon <bgeffon@google.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Minchan Kim <minchan@kernel.org>
Cc: Nitin Gupta <ngupta@vflare.org>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	 linux-kernel@vger.kernel.org,
	Suleiman Souhlal <suleiman@google.com>,
	linux-mm@kvack.org,  Brian Geffon <bgeffon@google.com>
Subject: [RFC PATCH 0/1] zram: Allow rw_page when page isn't written back.
Date: Mon,  8 Aug 2022 12:50:05 -0400	[thread overview]
Message-ID: <20220808165006.2451180-1-bgeffon@google.com> (raw)

Today when a zram device has a backing device we change the ops to
a new set which does not expose a rw_page method. This prevents the
upper layers from trying to issue a synchronous rw. This has the
downside that we penalize every rw even when it could possibly
still be performed as a synchronous rw.

This is just a proposal and I wanted to get feedback if people
felt this was worthwhile.

The motivation comes from what Minchan noted in the original
change which introduced the synchronous behavior that it enhanches
swap-in performance by about 45% [1]. So it'd be great if we could
still get this benefit while using writeback.

1. https://lore.kernel.org/all/1505886205-9671-5-git-send-email-minchan@kernel.org/

Brian Geffon (1):
  zram: Allow rw_page when page isn't written back.

 drivers/block/zram/zram_drv.c | 65 +++++++++++++++++++++--------------
 drivers/block/zram/zram_drv.h |  1 +
 2 files changed, 41 insertions(+), 25 deletions(-)

-- 
2.37.1.559.g78731f0fdb-goog



             reply	other threads:[~2022-08-08 16:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-08 16:50 Brian Geffon [this message]
2022-08-08 16:50 ` [RFC PATCH 1/1] " Brian Geffon
2022-08-09  1:38   ` Sergey Senozhatsky
2022-08-10 19:18     ` Brian Geffon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220808165006.2451180-1-bgeffon@google.com \
    --to=bgeffon@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=ngupta@vflare.org \
    --cc=senozhatsky@chromium.org \
    --cc=suleiman@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox