From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 120FDC00140 for ; Wed, 3 Aug 2022 01:09:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B0FA8E0002; Tue, 2 Aug 2022 21:09:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 65EEC8E0001; Tue, 2 Aug 2022 21:09:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 54E968E0002; Tue, 2 Aug 2022 21:09:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 395C98E0001 for ; Tue, 2 Aug 2022 21:09:54 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id F123F41095 for ; Wed, 3 Aug 2022 01:09:53 +0000 (UTC) X-FDA: 79756499466.02.3C5CA9C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 8093340118 for ; Wed, 3 Aug 2022 01:09:52 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 84D6A61070; Wed, 3 Aug 2022 01:09:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B44CAC433D6; Wed, 3 Aug 2022 01:09:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1659488990; bh=ZGfXtJXYckiqLI2OLNiUd35oN8pZrrFA74XGucTzrjA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hPU7aVFaT/I1UDsj1ptPQu810ub32IqakJANGGKwnd/TlQWVG9AyPwYwvP23XG/pX 7D1CwWxAcnBx2U9OGAfeWAQ8oxM/4LuteKNb3JspCdyTLtHhaZfl1vZ2j+GTjdwr4X e/InQoWAamrsyjMliCOi0JZecGSLLhNcowkP7kW0= Date: Tue, 2 Aug 2022 18:09:49 -0700 From: Andrew Morton To: kernel test robot Cc: Ralph Campbell , kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Linux Memory Management List , Alistair Popple Subject: Re: [akpm-mm:mm-stable 242/251] hmm-tests.c:1607:42: error: 'HMM_DMIRROR_MIGRATE' undeclared; did you mean 'HMM_DMIRROR_WRITE'? Message-Id: <20220802180949.1a6429096f9ebede543034fc@linux-foundation.org> In-Reply-To: <202208030814.FpNJkXbm-lkp@intel.com> References: <202208030814.FpNJkXbm-lkp@intel.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659488992; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JWeJr8NzhFS6ER2AtN/4gNVxj7ZLgzxAw58dbinnsCQ=; b=ORJ9ctFPqB1Tkm5aqJ0NuN6aaHoy7zWnTEV7fNOQaALsCHulcOMpztWbdNRJ2kmq+I62Ru aBEpzM+H9kDJt+vkKnb5vCb2N8TmVoVGN2J4lV9LbjMj0sYIxP7VWa/+Koy0s1nE9ZS80s MS3n/2GEavHWH4CrAfDEhEIXRnDJpG8= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=hPU7aVFa; spf=pass (imf12.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659488992; a=rsa-sha256; cv=none; b=bbU4KnVTKPXNS3uJc9nb/7EPAQXeKppp5rHrV695EY6+z1ATsE2jt2Sgju7uASBsPiz6Y5 0zrPhQGwaPfZyVN7QXs1jsay+5Opfvxt1HGFal/4sEMpvF7crg6xKbw3rb4YsD8yGXJlzo Z1NF1z1JcJddpiUn8IAQbPy67OrNMCs= X-Rspam-User: Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=hPU7aVFa; spf=pass (imf12.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Stat-Signature: w8qfjngjajciqjnopye3sbuwi6kmjjzx X-Rspamd-Queue-Id: 8093340118 X-Rspamd-Server: rspam10 X-HE-Tag: 1659488992-256013 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 3 Aug 2022 08:24:08 +0800 kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-stable > head: 1a44131d4f524e18d873bbe363598e39841001bf > commit: f6c3e1ae0114cd0f5123cf38187d450c1b119e67 [242/251] mm/hmm: add a test for cross device private faults > compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 > reproduce: > # https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?id=f6c3e1ae0114cd0f5123cf38187d450c1b119e67 > git remote add akpm-mm https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git > git fetch --no-tags akpm-mm mm-stable > git checkout f6c3e1ae0114cd0f5123cf38187d450c1b119e67 > make O=/tmp/kselftest headers > make O=/tmp/kselftest -C tools/testing/selftests > > If you fix the issue, kindly add following tag where applicable > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > hmm-tests.c: In function 'hmm2_double_map': > >> hmm-tests.c:1607:42: error: 'HMM_DMIRROR_MIGRATE' undeclared (first use in this function); did you mean 'HMM_DMIRROR_WRITE'? > 1607 | ret = hmm_dmirror_cmd(self->fd1, HMM_DMIRROR_MIGRATE, buffer, npages); > | ^~~~~~~~~~~~~~~~~~~ > | HMM_DMIRROR_WRITE > hmm-tests.c:1607:42: note: each undeclared identifier is reported only once for each function it appears in oops, thanks. It's been a week - I'm surprised this wasn't picked up sooner? Ralph, Alistair, is this right? From: Andrew Morton Subject: tools/testing/selftests/vm/hmm-tests.c: fix build Date: Tue Aug 2 06:03:03 PM PDT 2022 hmm-tests.c:1607:42: error: 'HMM_DMIRROR_MIGRATE' undeclared (first use in this function); did you mean 'HMM_DMIRROR_WRITE'? Fixes: f6c3e1ae0114cd0 ("mm/hmm: add a test for cross device private faults") Reported-by: kernel test robot Cc: Ralph Campbell Cc: Alistair Popple Signed-off-by: Andrew Morton --- tools/testing/selftests/vm/hmm-tests.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/tools/testing/selftests/vm/hmm-tests.c~tools-testing-selftests-vm-hmm-testsc-fix-build +++ a/tools/testing/selftests/vm/hmm-tests.c @@ -1604,7 +1604,7 @@ TEST_F(hmm2, double_map) ASSERT_EQ(ptr[i], i); /* Migrate pages to device 1 and try to read from device 0. */ - ret = hmm_dmirror_cmd(self->fd1, HMM_DMIRROR_MIGRATE, buffer, npages); + ret = hmm_migrate_sys_to_dev(self->fd1, buffer, npages); ASSERT_EQ(ret, 0); ASSERT_EQ(buffer->cpages, npages); _