From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61241C00144 for ; Mon, 1 Aug 2022 05:28:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B8CEA8E0002; Mon, 1 Aug 2022 01:28:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B3C838E0001; Mon, 1 Aug 2022 01:28:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A03A18E0002; Mon, 1 Aug 2022 01:28:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 915988E0001 for ; Mon, 1 Aug 2022 01:28:58 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 430601A0186 for ; Mon, 1 Aug 2022 05:28:57 +0000 (UTC) X-FDA: 79749894714.19.C4BC83A Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by imf08.hostedemail.com (Postfix) with ESMTP id A7C05160020 for ; Mon, 1 Aug 2022 05:28:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1659331736; x=1690867736; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=fnJA2N4BlsQJQig0zFxKAUGxel99425sq0Qw9NnY5No=; b=AZOsAGJn+ZMj26H43B7R1rnCHeJlVfHr+JDMi3IkgsjZNFFrzowDw//k n2XVyJ3f848pX23wwLXf/tbqZv08oT3rzUUnI0d+HAcznuPP2UTCWinfL uTb8Ful37Htd9sz8PAeQPpKRTXznDvna1LZzfHBxPjyQIYdUy8tEGe9S5 I=; Received: from unknown (HELO ironmsg-SD-alpha.qualcomm.com) ([10.53.140.30]) by alexa-out-sd-02.qualcomm.com with ESMTP; 31 Jul 2022 22:28:55 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg-SD-alpha.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jul 2022 22:28:55 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Sun, 31 Jul 2022 22:28:55 -0700 Received: from hu-pkondeti-hyd.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Sun, 31 Jul 2022 22:28:52 -0700 Date: Mon, 1 Aug 2022 10:58:48 +0530 From: Pavan Kondeti To: Charan Teja Kalla CC: , , , , , Subject: Re: [PATCH] mm/page_ext: remove unused variable in offline_page_ext Message-ID: <20220801052848.GB18790@hu-pkondeti-hyd.qualcomm.com> References: <1659330397-11817-1-git-send-email-quic_charante@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1659330397-11817-1-git-send-email-quic_charante@quicinc.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659331737; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fnJA2N4BlsQJQig0zFxKAUGxel99425sq0Qw9NnY5No=; b=wrPcggwcmJT6oDIDQEs/V72k763Zzo4A8nB3/o0z4N2d+4ZX0pJDsNMphqxIkXaA8iWXzD 3wt0YkWgeUPG3ecGcjjYLe9rMVJXusbB9eI6vDpNAU8SYlklbjTEMsH6l1+mcJa+dV/GP6 yNQaKzXgtb0cMDomwtwX33MS94qkNXY= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcdkim header.b=AZOsAGJn; spf=pass (imf08.hostedemail.com: domain of quic_pkondeti@quicinc.com designates 199.106.114.39 as permitted sender) smtp.mailfrom=quic_pkondeti@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659331737; a=rsa-sha256; cv=none; b=bWSaLCFqjVw5Thm1e1Dp9KZE9JQy8jPYuSoqN6+TfsePPODuS54yFmU0JAeOMymrY2cVX7 GfiTHRWFUiLTFOaxKGQuC6gcbr1vHOBzEB4gMDPkgpR5MjSzGtC/O1reLTCCWKkXzHXpyc VQ6o7XfMniv2op+MqcvHze/34jwPbtY= Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcdkim header.b=AZOsAGJn; spf=pass (imf08.hostedemail.com: domain of quic_pkondeti@quicinc.com designates 199.106.114.39 as permitted sender) smtp.mailfrom=quic_pkondeti@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A7C05160020 X-Stat-Signature: qzq9z7sdyfmu7n9wd8sha8q1eoakxycf X-HE-Tag: 1659331736-425268 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 01, 2022 at 10:36:37AM +0530, Charan Teja Kalla wrote: > Remove unused variable 'nid' in offline_page_ext(). This is not used > since the page_ext code inception. > Just to be clear, should we say "drop nid argument from offline_page_exit"? With this change the symmetry between "online_page_exit" and "offline_page_exit" is lost. But that is not a valid point to keep an unused argument. > Signed-off-by: Charan Teja Kalla > --- > mm/page_ext.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/page_ext.c b/mm/page_ext.c > index 3dc715d..e22a928 100644 > --- a/mm/page_ext.c > +++ b/mm/page_ext.c > @@ -336,7 +336,7 @@ static int __meminit online_page_ext(unsigned long start_pfn, > } > > static int __meminit offline_page_ext(unsigned long start_pfn, > - unsigned long nr_pages, int nid) > + unsigned long nr_pages) > { > unsigned long start, end, pfn; > > @@ -362,11 +362,11 @@ static int __meminit page_ext_callback(struct notifier_block *self, > break; > case MEM_OFFLINE: > offline_page_ext(mn->start_pfn, > - mn->nr_pages, mn->status_change_nid); > + mn->nr_pages); > break; > case MEM_CANCEL_ONLINE: > offline_page_ext(mn->start_pfn, > - mn->nr_pages, mn->status_change_nid); > + mn->nr_pages); > break; > case MEM_GOING_OFFLINE: > break; Looks good to me. Thanks, Pavan