From: Christoph Hellwig <hch@lst.de>
To: Mel Gorman <mgorman@suse.de>
Cc: Jan Kara <jack@suse.cz>, Christoph Hellwig <hch@lst.de>,
Bob Peterson <rpeterso@redhat.com>,
Andreas Gruenbacher <agruenba@redhat.com>,
"Darrick J. Wong" <djwong@kernel.org>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Naohiro Aota <naohiro.aota@wdc.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Vlastimil Babka <vbabka@suse.cz>,
Johannes Thumshirn <jth@kernel.org>,
cluster-devel@redhat.com, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: remove iomap_writepage v2
Date: Fri, 29 Jul 2022 16:11:45 +0200 [thread overview]
Message-ID: <20220729141145.GA31605@lst.de> (raw)
In-Reply-To: <20220729092216.GE3493@suse.de>
On Fri, Jul 29, 2022 at 10:22:16AM +0100, Mel Gorman wrote:
> There is some context missing because it's not clear what the full impact is
> but it is definitly the case that writepage is ignored in some contexts for
> common filesystems so lets assume that writepage from reclaim context always
> failed as a worst case scenario. Certainly this type of change is something
> linux-mm needs to be aware of because we've been blind-sided before.
Between willy and Johannes pushing or it I was under the strong assumption
that linux-mm knows of it..
> I don't think it would be incredibly damaging although there *might* be
> issues with small systems or cgroups.
Johannes specifically mentioned that cgroup writeback will never call
into ->writepage anyway.
next prev parent reply other threads:[~2022-07-29 14:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220719041311.709250-1-hch@lst.de>
2022-07-28 11:10 ` Jan Kara
2022-07-28 14:18 ` Matthew Wilcox
2022-07-28 22:48 ` Dave Chinner
2022-07-28 23:26 ` Yang Shi
2022-07-29 9:22 ` Mel Gorman
2022-07-29 14:11 ` Christoph Hellwig [this message]
2022-08-01 15:31 ` Johannes Weiner
2022-08-10 20:43 ` Matthew Wilcox
2022-08-10 21:32 ` Andreas Grünbacher
2022-08-10 23:17 ` Matthew Wilcox
2022-08-11 5:58 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220729141145.GA31605@lst.de \
--to=hch@lst.de \
--cc=agruenba@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=djwong@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=jack@suse.cz \
--cc=jth@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=naohiro.aota@wdc.com \
--cc=rpeterso@redhat.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox