From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 797B3C19F2C for ; Fri, 29 Jul 2022 08:01:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 91AE1940007; Fri, 29 Jul 2022 04:01:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A3076B0073; Fri, 29 Jul 2022 04:01:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 71C5A940007; Fri, 29 Jul 2022 04:01:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5418C6B0072 for ; Fri, 29 Jul 2022 04:01:27 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2709041124 for ; Fri, 29 Jul 2022 08:01:27 +0000 (UTC) X-FDA: 79739392614.27.401DD0F Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf15.hostedemail.com (Postfix) with ESMTP id 46C7BA00D5 for ; Fri, 29 Jul 2022 08:01:26 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4LvKfq2ZH9zmVNZ; Fri, 29 Jul 2022 15:59:31 +0800 (CST) Received: from huawei.com (10.175.124.27) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 29 Jul 2022 16:01:22 +0800 From: Miaohe Lin To: CC: , , , , Subject: [PATCH v2 4/5] hugetlb_cgroup: use helper macro NUMA_NO_NODE Date: Fri, 29 Jul 2022 16:01:05 +0800 Message-ID: <20220729080106.12752-5-linmiaohe@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20220729080106.12752-1-linmiaohe@huawei.com> References: <20220729080106.12752-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.175.124.27] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659081686; a=rsa-sha256; cv=none; b=TIG2psfPnh2rPkeD0Qb/u3nKMTCoqvGEL5odQlex1IbDyKtCYARUSOfGe58g4vUHn8va81 1fih2k15TMkAaLjjdijNlmW8BKj7jyZ7gmOmKeilpdc5nD55OOp0oaqfve8U9TW02iS+ZT q8uxNSQEYn+JZ31OyRhJoPx0etRrPKM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659081686; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Cuc1UCRZifJPaEX4MPOhp55MOFrR3oLg/Dm/LwuUxLU=; b=NCIPqiM4/aWyUStdHna/tXM6a7ibyZTwHKU4/K5wQMSDC/odihS49l17AvtUEa9SNf2L5p EPdYscxd4nsojruR4wxmX3ijo8tY3bRSEsZ7v7baNgRoq3x3qlqU1o049DfSZs2zrbhPmk 2F2hbnaVW4B11tZA/yLsMYjIDiBMU/E= X-Stat-Signature: jp6s6xgg6pp9ku5kr8uo8poomoi3jggb X-Rspamd-Queue-Id: 46C7BA00D5 X-Rspam-User: Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspamd-Server: rspam02 X-HE-Tag: 1659081686-410357 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: It's better to use NUMA_NO_NODE instead of magic number -1. Minor readability improvement. Signed-off-by: Miaohe Lin Reviewed-by: Mina Almasry --- mm/hugetlb_cgroup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c index 01a709468937..2affccfe59f1 100644 --- a/mm/hugetlb_cgroup.c +++ b/mm/hugetlb_cgroup.c @@ -154,9 +154,9 @@ hugetlb_cgroup_css_alloc(struct cgroup_subsys_state *parent_css) * function. */ for_each_node(node) { - /* Set node_to_alloc to -1 for offline nodes. */ + /* Set node_to_alloc to NUMA_NO_NODE for offline nodes. */ int node_to_alloc = - node_state(node, N_NORMAL_MEMORY) ? node : -1; + node_state(node, N_NORMAL_MEMORY) ? node : NUMA_NO_NODE; h_cgroup->nodeinfo[node] = kzalloc_node(sizeof(struct hugetlb_cgroup_per_node), GFP_KERNEL, node_to_alloc); -- 2.23.0