* [PATCH] memblock tests: compiling error
@ 2022-07-26 3:05 Liu Xinpeng
2022-07-27 1:01 ` Souptick Joarder
2022-07-27 1:53 ` mawupeng
0 siblings, 2 replies; 7+ messages in thread
From: Liu Xinpeng @ 2022-07-26 3:05 UTC (permalink / raw)
To: rppt, linux-mm, david; +Cc: linux-kernel, Liu Xinpeng
memblock.o: In function `memblock_find_in_range.constprop.9':
memblock.c:(.text+0x4651): undefined reference to `pr_warn_ratelimited'
memblock.o: In function `memblock_mark_mirror':
memblock.c:(.text+0x7171): undefined reference to `mirrored_kernelcore'
Fixs: 902c2d91582 ("memblock: Disable mirror feature if kernelcore is not
specified")
Fixs: 14d9a675fd0 ("mm: Ratelimited mirrored memory related warning")
Signed-off-by: Liu Xinpeng <liuxp11@chinatelecom.cn>
---
tools/testing/memblock/internal.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/testing/memblock/internal.h b/tools/testing/memblock/internal.h
index c2a492c..cf67e6e 100644
--- a/tools/testing/memblock/internal.h
+++ b/tools/testing/memblock/internal.h
@@ -9,6 +9,9 @@
static int memblock_debug = 1;
#endif
+#define pr_warn_ratelimited(fmt, ...) printf(fmt, ##__VA_ARGS__);
+
+bool mirrored_kernelcore = false;
struct page {};
void memblock_free_pages(struct page *page, unsigned long pfn,
--
1.8.3.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] memblock tests: compiling error
2022-07-26 3:05 [PATCH] memblock tests: compiling error Liu Xinpeng
@ 2022-07-27 1:01 ` Souptick Joarder
2022-07-27 1:03 ` Randy Dunlap
2022-07-27 1:53 ` mawupeng
2022-07-27 1:53 ` mawupeng
1 sibling, 2 replies; 7+ messages in thread
From: Souptick Joarder @ 2022-07-27 1:01 UTC (permalink / raw)
To: Liu Xinpeng; +Cc: Mike Rapoport, Linux-MM, David Hildenbrand, linux-kernel
On Tue, Jul 26, 2022 at 8:35 AM Liu Xinpeng <liuxp11@chinatelecom.cn> wrote:
>
> memblock.o: In function `memblock_find_in_range.constprop.9':
> memblock.c:(.text+0x4651): undefined reference to `pr_warn_ratelimited'
> memblock.o: In function `memblock_mark_mirror':
> memblock.c:(.text+0x7171): undefined reference to `mirrored_kernelcore'
>
what is the steps to hit this compile error ?
> Fixs: 902c2d91582 ("memblock: Disable mirror feature if kernelcore is not
> specified")
> Fixs: 14d9a675fd0 ("mm: Ratelimited mirrored memory related warning")
>
> Signed-off-by: Liu Xinpeng <liuxp11@chinatelecom.cn>
> ---
> tools/testing/memblock/internal.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/testing/memblock/internal.h b/tools/testing/memblock/internal.h
> index c2a492c..cf67e6e 100644
> --- a/tools/testing/memblock/internal.h
> +++ b/tools/testing/memblock/internal.h
> @@ -9,6 +9,9 @@
> static int memblock_debug = 1;
> #endif
>
> +#define pr_warn_ratelimited(fmt, ...) printf(fmt, ##__VA_ARGS__);
> +
> +bool mirrored_kernelcore = false;
> struct page {};
>
> void memblock_free_pages(struct page *page, unsigned long pfn,
> --
> 1.8.3.1
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] memblock tests: compiling error
2022-07-27 1:01 ` Souptick Joarder
@ 2022-07-27 1:03 ` Randy Dunlap
2022-07-27 1:53 ` mawupeng
1 sibling, 0 replies; 7+ messages in thread
From: Randy Dunlap @ 2022-07-27 1:03 UTC (permalink / raw)
To: Souptick Joarder, Liu Xinpeng
Cc: Mike Rapoport, Linux-MM, David Hildenbrand, linux-kernel
On 7/26/22 18:01, Souptick Joarder wrote:
> On Tue, Jul 26, 2022 at 8:35 AM Liu Xinpeng <liuxp11@chinatelecom.cn> wrote:
>>
>> memblock.o: In function `memblock_find_in_range.constprop.9':
>> memblock.c:(.text+0x4651): undefined reference to `pr_warn_ratelimited'
>> memblock.o: In function `memblock_mark_mirror':
>> memblock.c:(.text+0x7171): undefined reference to `mirrored_kernelcore'
>>
>
> what is the steps to hit this compile error ?
or what kernel .config file?
>
>> Fixs: 902c2d91582 ("memblock: Disable mirror feature if kernelcore is not
>> specified")
>> Fixs: 14d9a675fd0 ("mm: Ratelimited mirrored memory related warning")
>>
>> Signed-off-by: Liu Xinpeng <liuxp11@chinatelecom.cn>
>> ---
>> tools/testing/memblock/internal.h | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/tools/testing/memblock/internal.h b/tools/testing/memblock/internal.h
>> index c2a492c..cf67e6e 100644
>> --- a/tools/testing/memblock/internal.h
>> +++ b/tools/testing/memblock/internal.h
>> @@ -9,6 +9,9 @@
>> static int memblock_debug = 1;
>> #endif
>>
>> +#define pr_warn_ratelimited(fmt, ...) printf(fmt, ##__VA_ARGS__);
>> +
>> +bool mirrored_kernelcore = false;
>> struct page {};
>>
>> void memblock_free_pages(struct page *page, unsigned long pfn,
>> --
>> 1.8.3.1
>>
>>
--
~Randy
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] memblock tests: compiling error
2022-07-27 1:01 ` Souptick Joarder
2022-07-27 1:03 ` Randy Dunlap
@ 2022-07-27 1:53 ` mawupeng
1 sibling, 0 replies; 7+ messages in thread
From: mawupeng @ 2022-07-27 1:53 UTC (permalink / raw)
To: jrdr.linux, liuxp11; +Cc: mawupeng1, rppt, linux-mm, david, linux-kernel
On 2022/7/27 9:01, Souptick Joarder wrote:
> On Tue, Jul 26, 2022 at 8:35 AM Liu Xinpeng <liuxp11@chinatelecom.cn> wrote:
>>
>> memblock.o: In function `memblock_find_in_range.constprop.9':
>> memblock.c:(.text+0x4651): undefined reference to `pr_warn_ratelimited'
>> memblock.o: In function `memblock_mark_mirror':
>> memblock.c:(.text+0x7171): undefined reference to `mirrored_kernelcore'
>>
>
> what is the steps to hit this compile error ?
Do make -C tools/testing/memblock can hit this compile error.
>
>> Fixs: 902c2d91582 ("memblock: Disable mirror feature if kernelcore is not
>> specified")
>> Fixs: 14d9a675fd0 ("mm: Ratelimited mirrored memory related warning")
>>
>> Signed-off-by: Liu Xinpeng <liuxp11@chinatelecom.cn>
>> ---
>> tools/testing/memblock/internal.h | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/tools/testing/memblock/internal.h b/tools/testing/memblock/internal.h
>> index c2a492c..cf67e6e 100644
>> --- a/tools/testing/memblock/internal.h
>> +++ b/tools/testing/memblock/internal.h
>> @@ -9,6 +9,9 @@
>> static int memblock_debug = 1;
>> #endif
>>
>> +#define pr_warn_ratelimited(fmt, ...) printf(fmt, ##__VA_ARGS__);
>> +
>> +bool mirrored_kernelcore = false;
>> struct page {};
>>
>> void memblock_free_pages(struct page *page, unsigned long pfn,
>> --
>> 1.8.3.1
>>
>>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] memblock tests: compiling error
2022-07-26 3:05 [PATCH] memblock tests: compiling error Liu Xinpeng
2022-07-27 1:01 ` Souptick Joarder
@ 2022-07-27 1:53 ` mawupeng
2022-07-27 2:06 ` liuxp11
1 sibling, 1 reply; 7+ messages in thread
From: mawupeng @ 2022-07-27 1:53 UTC (permalink / raw)
To: liuxp11, rppt, linux-mm, david; +Cc: mawupeng1, linux-kernel
On 2022/7/26 11:05, Liu Xinpeng wrote:
> memblock.o: In function `memblock_find_in_range.constprop.9':
> memblock.c:(.text+0x4651): undefined reference to `pr_warn_ratelimited'
> memblock.o: In function `memblock_mark_mirror':
> memblock.c:(.text+0x7171): undefined reference to `mirrored_kernelcore'
>
> Fixs: 902c2d91582 ("memblock: Disable mirror feature if kernelcore is not
> specified")
Fixs should not have word warp.
Tested-by: Ma Wupeng <mawupeng1@huawei.com>
> Fixs: 14d9a675fd0 ("mm: Ratelimited mirrored memory related warning")
>
> Signed-off-by: Liu Xinpeng <liuxp11@chinatelecom.cn>
> ---
> tools/testing/memblock/internal.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/testing/memblock/internal.h b/tools/testing/memblock/internal.h
> index c2a492c..cf67e6e 100644
> --- a/tools/testing/memblock/internal.h
> +++ b/tools/testing/memblock/internal.h
> @@ -9,6 +9,9 @@
> static int memblock_debug = 1;
> #endif
>
> +#define pr_warn_ratelimited(fmt, ...) printf(fmt, ##__VA_ARGS__);
> +
> +bool mirrored_kernelcore = false;
> struct page {};
>
> void memblock_free_pages(struct page *page, unsigned long pfn,
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: Re: [PATCH] memblock tests: compiling error
2022-07-27 1:53 ` mawupeng
@ 2022-07-27 2:06 ` liuxp11
2022-07-27 2:20 ` Kefeng Wang
0 siblings, 1 reply; 7+ messages in thread
From: liuxp11 @ 2022-07-27 2:06 UTC (permalink / raw)
To: mawupeng, rppt, linux-mm, david; +Cc: linux-kernel
>On 2022/7/26 11:05, Liu Xinpeng wrote:
>> memblock.o: In function `memblock_find_in_range.constprop.9':
>> memblock.c:(.text+0x4651): undefined reference to `pr_warn_ratelimited'
>> memblock.o: In function `memblock_mark_mirror':
>> memblock.c:(.text+0x7171): undefined reference to `mirrored_kernelcore'
>> Fixs: 902c2d91582 ("memblock: Disable mirror feature if kernelcore is not
>> specified")
>Fixs should not have word warp.
>Tested-by: Ma Wupeng <mawupeng1@huawei.com>
I will send patch v2, such as,
Fixs: 902c2d91582 ("memblock: Disable mirror feature if kernelcore is not
specified") and 14d9a675fd0 ("mm: Ratelimited mirrored memory related warning")
> +#define pr_warn_ratelimited(fmt, ...) printf(fmt, ##__VA_ARGS__);
And removed the comma.
thanks your test,
Liu Xinpeng
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] memblock tests: compiling error
2022-07-27 2:06 ` liuxp11
@ 2022-07-27 2:20 ` Kefeng Wang
0 siblings, 0 replies; 7+ messages in thread
From: Kefeng Wang @ 2022-07-27 2:20 UTC (permalink / raw)
To: liuxp11, mawupeng, rppt, linux-mm, david; +Cc: linux-kernel
[-- Attachment #1: Type: text/plain, Size: 976 bytes --]
On 2022/7/27 10:06, liuxp11@chinatelecom.cn wrote:
>> On 2022/7/26 11:05, Liu Xinpeng wrote:
>>> memblock.o: In function `memblock_find_in_range.constprop.9':
>>> memblock.c:(.text+0x4651): undefined reference to `pr_warn_ratelimited'
>>> memblock.o: In function `memblock_mark_mirror':
>>> memblock.c:(.text+0x7171): undefined reference to `mirrored_kernelcore'
>>> Fixs: 902c2d91582 ("memblock: Disable mirror feature if kernelcore is not
>>> specified")
>> Fixs should not have word warp.
>
>> Tested-by: Ma Wupeng<mawupeng1@huawei.com>
> I will send patch v2, such as,
>
> Fixs: 902c2d91582 ("memblock: Disable mirror feature if kernelcore is not
> specified") and 14d9a675fd0 ("mm: Ratelimited mirrored memory related warning")
no, see https://kernel.org/doc/html/latest/process/submitting-patches.html
please check fixes part.
>> +#define pr_warn_ratelimited(fmt, ...) printf(fmt, ##__VA_ARGS__);
> And removed the comma.
>
>
> thanks your test,
> Liu Xinpeng
>
[-- Attachment #2: Type: text/html, Size: 3978 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-07-27 2:20 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-26 3:05 [PATCH] memblock tests: compiling error Liu Xinpeng
2022-07-27 1:01 ` Souptick Joarder
2022-07-27 1:03 ` Randy Dunlap
2022-07-27 1:53 ` mawupeng
2022-07-27 1:53 ` mawupeng
2022-07-27 2:06 ` liuxp11
2022-07-27 2:20 ` Kefeng Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox