From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62E69C04A68 for ; Wed, 27 Jul 2022 07:46:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E51D5940008; Wed, 27 Jul 2022 03:46:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E00EC6B0081; Wed, 27 Jul 2022 03:46:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA28A940008; Wed, 27 Jul 2022 03:46:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BAA256B0080 for ; Wed, 27 Jul 2022 03:46:25 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 90D31A0B4F for ; Wed, 27 Jul 2022 07:46:25 +0000 (UTC) X-FDA: 79732097130.15.290343E Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) by imf17.hostedemail.com (Postfix) with ESMTP id 5699D400AD for ; Wed, 27 Jul 2022 07:46:24 +0000 (UTC) Received: from epcas1p4.samsung.com (unknown [182.195.41.48]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20220727074621epoutp02019d060e787fe8d15abc5cf782db0897~FoAUCL0Wq3255832558epoutp021 for ; Wed, 27 Jul 2022 07:46:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20220727074621epoutp02019d060e787fe8d15abc5cf782db0897~FoAUCL0Wq3255832558epoutp021 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1658907981; bh=CtbrmE5mtbwmdtJprAHDtXpLA8uc08KEWRUQJGjNkUE=; h=Subject:Reply-To:From:To:CC:In-Reply-To:Date:References:From; b=SZzi3Bs/bezEjCoMt6nQedw6R8CNLkCuhRiNz2eZLSkxR03ekpId0aD3OtxmHMqKu VhWqNjHr6yVNeD5MAvjBe2504kqD2wLPFVGGbr2MSe3UwKFrJjmH8mGBzanjzPV05l pHy+fijjGFLkRkFEVAruAh1KcsdXItrx5H/ifA4A= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas1p1.samsung.com (KnoxPortal) with ESMTP id 20220727074620epcas1p10318d08312608dfabd43eb68621e1615~FoATaoZ3a0632806328epcas1p1j; Wed, 27 Jul 2022 07:46:20 +0000 (GMT) Received: from epsmges1p3.samsung.com (unknown [182.195.36.227]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4Lt5SX0y5fz4x9Q6; Wed, 27 Jul 2022 07:46:20 +0000 (GMT) X-AuditID: b6c32a37-aea59a80000025bd-7a-62e0ed4bcca1 Received: from epcas1p4.samsung.com ( [182.195.41.48]) by epsmges1p3.samsung.com (Symantec Messaging Gateway) with SMTP id A6.A1.09661.B4DE0E26; Wed, 27 Jul 2022 16:46:20 +0900 (KST) Mime-Version: 1.0 Subject: RE: [PATCH v2] page_alloc: fix invalid watemark check on a negative value Reply-To: jaewon31.kim@samsung.com From: Jaewon Kim To: Andrew Morton , Jaewon Kim CC: "minchan@kernel.org" , "bhe@redhat.com" , "vbabka@suse.cz" , "mgorman@techsingularity.net" , "hannes@cmpxchg.org" , "mhocko@kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , GyeongHwan Hong , YongTaek Lee , "jaewon31.kim@gmail.com" X-Priority: 3 X-Content-Kind-Code: NORMAL In-Reply-To: <20220725113707.e03007d0761423f642c15749@linux-foundation.org> X-Drm-Type: N,general X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Message-ID: <20220727074619epcms1p7285bceab31c4e04406094eee84862803@epcms1p7> Date: Wed, 27 Jul 2022 16:46:19 +0900 X-CMS-MailID: 20220727074619epcms1p7285bceab31c4e04406094eee84862803 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE X-CPGSPASS: Y X-CPGSPASS: Y CMS-TYPE: 101P X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrLJsWRmVeSWpSXmKPExsWy7bCmga7P2wdJBocmMlvMWb+GzeL8g19s Fi8PaVps+f2G0WL1Jl+L7s0zGS16379isri8aw6bxb01/1ktdizdx2Tx+tsyZotlX9+zW8xu 7GO0eLye24HP4/Cb98weO2fdZffYtKqTzWPTp0nsHidm/GbxeL/vKptH35ZVjB5nFhxh99j6 y87j8ya5AK6obJuM1MSU1CKF1Lzk/JTMvHRbJe/geOd4UzMDQ11DSwtzJYW8xNxUWyUXnwBd t8wcoPOVFMoSc0qBQgGJxcVK+nY2RfmlJakKGfnFJbZKqQUpOQVmBXrFibnFpXnpenmpJVaG BgZGpkCFCdkZMyZ9Zy3YIlYx5fkV1gbGV6JdjJwcEgImEksvN7B1MXJxCAnsYJR4saKJqYuR g4NXQFDi7w5hkBphgRCJg3e3MoLYQgJKEmd/XGGHiOtKNHWvZgGx2QS0Jd4vmMQKYosIhEk0 P/nEAjKTWeAPs0TT969MEMt4JWa0P2WBsKUlti+HGMop4C3x9NNUdoi4qMTN1W/h7PfH5jNC 2CISrffOMkPYghIPfu6GiktJnOs+DnazhECExIs96hDhHIn3O+ewQtjmEs82tICN5BXwlXhz 9gLYCSwCqhIvjk9khWh1kZg7Tx4kzAz0yrKFr5lBwswCmhLrd+lDTFGU2Pl7LiPMIw0bf7Oj s5kF+CTefe1hhYnvmPcE6nE1iZZnX6HiMhJ//z1jncCoNAsRzrOQLJ6FsHgBI/MqRrHUguLc 9NRiwwJjeNQm5+duYgSnYy3zHYzT3n7QO8TIxMF4iFGCg1lJhDch+n6SEG9KYmVValF+fFFp TmrxIUZToI8nMkuJJucDM0JeSbyhiaWBiZmRiYWxpbGZkjjvqmmnE4UE0hNLUrNTUwtSi2D6 mDg4pRqYJh3YcPqh4UGm/Y1yTOHFvXsX2AR98/Cu5rioLqH6fsfx2HKzt1KHmj+mz2l4NqGq +ya70ZyOfZtfWRnP19V21yvfs2Gvtef9Q+4+yTP3PylcoSB+KiKgaKPTrQzuzZk7j+u9VowT DFjZuKvyWVt3ZJJ51039g/3HRA51Xb2f47Os7RvDiS//Dzcbl1yZyV/hJRJzz0y59Tjnh5Cq rwebZwmxs51jP6H/sd10eqAmzwN/rpc/NvBW7NmXcOCd4NYLKdHCL2z9mTrnO/30CVPfZm/U fKnXr3fbbq4H8ootM+u15Pf8jVM+Wr/N2ChbfLWrZEd+ZkxNXvbjaCulW/VrTl/1vd+TH8Oa lfGhb40SS3FGoqEWc1FxIgA+TeqcUAQAAA== DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20220725095214epcas1p1cc2019c792560da07d673809a3fc7ef3 References: <20220725113707.e03007d0761423f642c15749@linux-foundation.org> <20220725095212.25388-1-jaewon31.kim@samsung.com> ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b="SZzi3Bs/"; spf=pass (imf17.hostedemail.com: domain of jaewon31.kim@samsung.com designates 203.254.224.25 as permitted sender) smtp.mailfrom=jaewon31.kim@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658907985; a=rsa-sha256; cv=none; b=RCbNFiRGHyRSZY68ttjPxgeJBwXAP0Z6xPlDWAg63morNpclZGKFh2RP5jXXdJltykuRZY F2bRb9AoTjbt6Bc2Lxk0geLYBjrhBJrCCQg0bctD0p0XWg1NBfyI9mdfSIREI1njZMu8av JcYEoa0EJCrKj/ouGSNTa88Xe6QNJA0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658907985; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CtbrmE5mtbwmdtJprAHDtXpLA8uc08KEWRUQJGjNkUE=; b=Wa+F4ZaJ7/gaF3X1NLR8nsKDEXxgLgJmx8O8gRr1sFuWdlLmkUZoVG4AI3mXN7bWoBBgTC ThuAWgOB5NGdehcGGEJWhalqJY1OnS1Iuk/Iaj8OqeGRV+Q/qis9pjb1ijdPv89rpDiaiU oS3m+pwFeqIGkdzFyCOp8QWpkZ0u3AM= X-Rspamd-Server: rspam10 X-Rspam-User: Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b="SZzi3Bs/"; spf=pass (imf17.hostedemail.com: domain of jaewon31.kim@samsung.com designates 203.254.224.25 as permitted sender) smtp.mailfrom=jaewon31.kim@samsung.com; dmarc=pass (policy=none) header.from=samsung.com X-Stat-Signature: yozcgxofft1ndps8kwrbkr97r8yewofa X-Rspamd-Queue-Id: 5699D400AD X-HE-Tag: 1658907984-693898 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >=C2=A0=0D=0A>=C2=A0=0D=0A>---------=20Original=20Message=20---------=0D=0A= >Sender=20:=20Andrew=20Morton=C2=A0=0D=0A>Date= =20:=202022-07-26=2003:37=20(GMT+9)=0D=0A>Title=20:=20Re:=20=5BPATCH=20v2= =5D=20page_alloc:=20fix=20invalid=20watemark=20check=20on=20a=20negative=20= value=0D=0A>=C2=A0=0D=0A>On=C2=A0Mon,=C2=A025=C2=A0Jul=C2=A02022=C2=A018:52= :12=C2=A0+0900=C2=A0Jaewon=C2=A0Kim=C2=A0=C2=A0= wrote:=0D=0A>=0D=0A>>=C2=A0There=C2=A0was=C2=A0a=C2=A0report=C2=A0that=C2= =A0a=C2=A0task=C2=A0is=C2=A0waiting=C2=A0at=C2=A0the=0D=0A>>=C2=A0throttle_= direct_reclaim.=C2=A0The=C2=A0pgscan_direct_throttle=C2=A0in=C2=A0vmstat=C2= =A0was=0D=0A>>=C2=A0increasing.=0D=0A>>=C2=A0=0D=0A>>=C2=A0This=C2=A0is=C2= =A0a=C2=A0bug=C2=A0where=C2=A0zone_watermark_fast=C2=A0returns=C2=A0true=C2= =A0even=C2=A0when=C2=A0the=C2=A0free=0D=0A>>=C2=A0is=C2=A0very=C2=A0low.=C2= =A0The=C2=A0commit=C2=A0f27ce0e14088=C2=A0(=22page_alloc:=C2=A0consider=C2= =A0highatomic=0D=0A>>=C2=A0reserve=C2=A0in=C2=A0watermark=C2=A0fast=22)=C2= =A0changed=C2=A0the=C2=A0watermark=C2=A0fast=C2=A0to=C2=A0consider=0D=0A>>= =C2=A0highatomic=C2=A0reserve.=C2=A0But=C2=A0it=C2=A0did=C2=A0not=C2=A0hand= le=C2=A0a=C2=A0negative=C2=A0value=C2=A0case=C2=A0which=0D=0A>>=C2=A0can=C2= =A0be=C2=A0happened=C2=A0when=C2=A0reserved_highatomic=C2=A0pageblock=C2=A0= is=C2=A0bigger=C2=A0than=C2=A0the=0D=0A>>=C2=A0actual=C2=A0free.=0D=0A>>=C2= =A0=0D=0A>>=C2=A0If=C2=A0watermark=C2=A0is=C2=A0considered=C2=A0as=C2=A0ok= =C2=A0for=C2=A0the=C2=A0negative=C2=A0value,=C2=A0allocating=0D=0A>>=C2=A0c= ontexts=C2=A0for=C2=A0order-0=C2=A0will=C2=A0consume=C2=A0all=C2=A0free=C2= =A0pages=C2=A0without=C2=A0direct=C2=A0reclaim,=0D=0A>>=C2=A0and=C2=A0final= ly=C2=A0free=C2=A0page=C2=A0may=C2=A0become=C2=A0depleted=C2=A0except=C2=A0= highatomic=C2=A0free.=0D=0A>>=C2=A0=0D=0A>>=C2=A0Then=C2=A0allocating=C2=A0= contexts=C2=A0may=C2=A0fall=C2=A0into=C2=A0throttle_direct_reclaim.=C2=A0Th= is=0D=0A>>=C2=A0symptom=C2=A0may=C2=A0easily=C2=A0happen=C2=A0in=C2=A0a=C2= =A0system=C2=A0where=C2=A0wmark=C2=A0min=C2=A0is=C2=A0low=C2=A0and=C2=A0oth= er=0D=0A>>=C2=A0reclaimers=C2=A0like=C2=A0kswapd=C2=A0does=C2=A0not=C2=A0ma= ke=C2=A0free=C2=A0pages=C2=A0quickly.=0D=0A>>=C2=A0=0D=0A>>=C2=A0Handle=C2= =A0the=C2=A0negative=C2=A0case=C2=A0by=C2=A0using=C2=A0MIN.=0D=0A>>=C2=A0= =0D=0A>=0D=0A>Thanks,=C2=A0I=C2=A0added=C2=A0cc:stable=C2=A0to=C2=A0this.= =0D=0A>=0D=0A=0D=0ASorry=20for=20your=20inconvenience.=0D=0A=0D=0ACould=20y= ou=20fix=20a=20typo=20by=20adding=20r=20to=20watermark=20on=20title=0D=0A= =0D=0A-=20page_alloc:=20fix=20invalid=20watemark=20check=20on=20a=20negativ= e=20value=0D=0A+=20page_alloc:=20fix=20invalid=20watermark=20check=20on=20a= =20negative=20value=0D=0A=0D=0A=0D=0AI've=20appreciated=20it=20in=20advance.