From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E9E1C04A68 for ; Tue, 26 Jul 2022 19:06:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9FF198E0002; Tue, 26 Jul 2022 15:06:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9AE358E0001; Tue, 26 Jul 2022 15:06:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 875E18E0002; Tue, 26 Jul 2022 15:06:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 762368E0001 for ; Tue, 26 Jul 2022 15:06:51 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2B0E71207C6 for ; Tue, 26 Jul 2022 19:06:51 +0000 (UTC) X-FDA: 79730183022.09.4CEAEAE Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf29.hostedemail.com (Postfix) with ESMTP id A34A6120094 for ; Tue, 26 Jul 2022 19:06:50 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 475C0B819F1; Tue, 26 Jul 2022 19:06:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A09CCC433C1; Tue, 26 Jul 2022 19:06:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1658862408; bh=uVEK4X3+ZAd5ynFN+0mycH9egCEFflQb/U7Rl/9aE40=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YSZcv8S3Oyisik20CD/uHqwVLjKt9rboPRdX6IuG7G3g3qB44JA+zkP84BG3V07jy IRDFMCD2MCVFwoIwgciLDUCLk4/Dclfff6Hvz55V08ehW3jfpk3CHvOZwYfd3nkehx FLevyaWl+fvHscl/mvqD+4W0vmPksGTU2NB3b0so= Date: Tue, 26 Jul 2022 12:06:46 -0700 From: Andrew Morton To: Ralph Campbell Cc: Alistair Popple , linux-mm@kvack.org, Felix Kuehling , Philip Yang , Jason Gunthorpe , stable@vger.kernel.org Subject: Re: [PATCH v2 1/2] mm/hmm: fault non-owner device private entries Message-Id: <20220726120646.88badf17bf26527d9238bc14@linux-foundation.org> In-Reply-To: <13611387-35ce-b03c-261d-96ba305c9061@nvidia.com> References: <20220725183615.4118795-1-rcampbell@nvidia.com> <20220725183615.4118795-2-rcampbell@nvidia.com> <87mtcwacg7.fsf@nvdebian.thelocal> <13611387-35ce-b03c-261d-96ba305c9061@nvidia.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658862410; a=rsa-sha256; cv=none; b=UfqKxREb2TrTAYV54GIiLATK+GujgFm37IW7xy3K6zzAtQFWcbek5v/6hkdboEqbyMGPBg VkiHCUgSATSO/1QJmYUv0yALBEEHPjGGS1tqb8eLqvSNKJ3qrkzRYyl1Aw+CJdCdqrtW2x XGA6p2CshsXwz2QjE8f0z2Oc1cQb8yU= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=YSZcv8S3; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658862410; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rHwufFP/qW3F4zQl1BuO3PHNORTuti5DWtdm0AKYEW0=; b=uSF7Oaq/BAOjd/0EHrqVWnusHEWVmjr0zd0yjeY0WHJoHrhPlFjy9VdsECgqp47cdCZJnA ohmf8omFyUAPrKWC6bdGmn/WkeuTolP8zgLN/yqnv56r9/Wj5Thm+Q+UsoX6kENLV+Bxa4 0Z8p4HT/xBVzmI+LnVUXKp3XqhQuMvY= X-Rspamd-Queue-Id: A34A6120094 X-Rspam-User: X-Stat-Signature: ouxhhd69b77sodq8oqzgqsixb4d9kab4 Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=YSZcv8S3; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Server: rspam08 X-HE-Tag: 1658862410-647853 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 26 Jul 2022 09:51:24 -0700 Ralph Campbell wrote: > >> Cc: stable@vger.kernel.org > >> Fixes: 76612d6ce4cc ("mm/hmm: reorganize how !pte_present is handled in hmm_vma_handle_pte()") > > This should be 08ddddda667b ("mm/hmm: check the device private page owner in hmm_range_fault()") > > Looks better to me too. > I assume Andrew will update the tags. Yes, I updated the patch.