From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 577D1C00140 for ; Tue, 26 Jul 2022 19:05:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B0328E0002; Tue, 26 Jul 2022 15:05:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 95FD18E0001; Tue, 26 Jul 2022 15:05:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 802708E0002; Tue, 26 Jul 2022 15:05:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 713468E0001 for ; Tue, 26 Jul 2022 15:05:10 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3F6B180A14 for ; Tue, 26 Jul 2022 19:05:10 +0000 (UTC) X-FDA: 79730178780.24.D6F67BC Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf23.hostedemail.com (Postfix) with ESMTP id 9AA071400AA for ; Tue, 26 Jul 2022 19:05:09 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 90DD9B819BF; Tue, 26 Jul 2022 19:05:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7469C433C1; Tue, 26 Jul 2022 19:05:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1658862306; bh=8HO1+0RNEW20BOdzYYpK3e0czzp1ctqmJl8m1mL5930=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jtWtbCvK3nAkuqT2HuiCQ7VGsG6UUqOPsV6eZjfDx6mo6ENgUYGB52rsb2vBlQWwz w2cz8xupjrK9I0ISykF/uaB+onTvwra4lMAK6ilCsMeHDnXFebfJemPcSOKKQIAeVv eDoEcuJScyoa0uvCKR+qZSe8ejnDGj1gw5J79dF0= Date: Tue, 26 Jul 2022 12:05:04 -0700 From: Andrew Morton To: "Sierra Guiza, Alejandro (Alex)" Cc: David Hildenbrand , jgg@nvidia.com, Felix.Kuehling@amd.com, linux-mm@kvack.org, rcampbell@nvidia.com, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, hch@lst.de, jglisse@redhat.com, apopple@nvidia.com, willy@infradead.org Subject: Re: [PATCH v9 06/14] mm/gup: migrate device coherent pages when pinning instead of failing Message-Id: <20220726120504.39498eff3843baf1d8fd5168@linux-foundation.org> In-Reply-To: References: <20220715150521.18165-1-alex.sierra@amd.com> <20220715150521.18165-7-alex.sierra@amd.com> <225554c2-9174-555e-ddc0-df95c39211bc@redhat.com> <20220718133235.4fdbd6ec303219e5a3ba49cf@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658862309; a=rsa-sha256; cv=none; b=kbb6AMFqxaZXXpjKGBplOSFPvZkK5R3KMrb6E7OoogXEc46jD6ZIqU0G+dkG5XNDm6PeMU gH2UJBq1rBzuMNePj9zF5JNoKcXVHzT8EvVwSP/QCNNKxqLYKJBjjpVbGuIN88pt2ShH0a HyDU1QhNt6GSotA+uGsB7uTt/w/Leow= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=jtWtbCvK; dmarc=none; spf=pass (imf23.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658862309; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MzZXP/vj/Abz2WtBVVozJ7dXPkYbx3otQAg0rA87LoQ=; b=ZNCJl8JW8usVghtdHscz3wtwJiTQStdc0TEn/dVmQ9HMYW6xTQjS7Q3QQtQvxxIGbgSeLF 6AI6CoVg5/g1sOt0SXKJ1b4IMCLd6QG42pkUx+g9gLZzsW3MyreKSmlo9PXRlX9x83KJfL mpsrHnXesycdwqy8PK1EtvG8MysaBTE= X-Rspamd-Queue-Id: 9AA071400AA X-Rspam-User: Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=jtWtbCvK; dmarc=none; spf=pass (imf23.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspamd-Server: rspam09 X-Stat-Signature: io58n957p1g4bomc9qj4nkomfngyqiqw X-HE-Tag: 1658862309-391531 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 25 Jul 2022 21:22:06 -0500 "Sierra Guiza, Alejandro (Alex)" wrote: > >> a) add the || to the end of the previous line > >> b) indent such the we have a nice-to-read alignment > >> > >> if (!list_empty(&movable_page_list) || isolation_error_count || > >> coherent_pages) > >> > > I missed that. This series is now in mm-stable so any fix will need to > > be a standalone followup patch, please. > Hi Andrew, > Just wanted to make sure nothing is missing from our side to merge this > patch series. It's queued in mm-stable and all looks good for a 5.20-rc1 merge.