From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2AD5C43334 for ; Fri, 22 Jul 2022 16:23:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0175A8E0003; Fri, 22 Jul 2022 12:23:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE1AD8E0001; Fri, 22 Jul 2022 12:23:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA9CA8E0003; Fri, 22 Jul 2022 12:23:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C768F8E0001 for ; Fri, 22 Jul 2022 12:23:01 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8554C80D63 for ; Fri, 22 Jul 2022 16:23:01 +0000 (UTC) X-FDA: 79715254962.27.708A4BF Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf11.hostedemail.com (Postfix) with ESMTP id 0FA954001E for ; Fri, 22 Jul 2022 16:23:00 +0000 (UTC) Received: by mail-yb1-f202.google.com with SMTP id m5-20020a2598c5000000b0066faab590c5so3948102ybo.7 for ; Fri, 22 Jul 2022 09:23:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=1v2THhkhdYklOspAmtCEFIjJCUUKeZARMXv38MhEpow=; b=UdOoN7qszmGcLnXMR4Ew1xMk2ipFrNQlnWb3XVRdsbye4OO074AP9hVBoaK+o/nqK/ CwKsZVRH5EgCwsoFrJMaA1WNLMs35xMsQgcbYZN/OGUI1c0YAVZY7U60QZJ0pz/GkYg1 O53wc4BVKC5ra0Dz2rtYq9nfp8be8Fz1BprUoXtxN1kdcLIcWwcoFHfg5otCLDGgQVeN KxJVE/sLDbVrbc17rkla+7UpCEF4GFgUU1vEEoDCBaSF+fDLyzn89cShgYYjgx7BnkNB XPBHkIJ6zv2qG5FtDrr9wveeK/ub8/0hS0rM0Wu1atXR494PpbVCtp3fMS5dI5EyK9jU wUTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=1v2THhkhdYklOspAmtCEFIjJCUUKeZARMXv38MhEpow=; b=3x/Oll8snE/+cqFM57K+DvPLxO/qvPOs01xnWb3lOjIW5wLbkMYRRlFmazphzNFIcm SULp1TtMSA5Ts+D86P83QvDjg3WRuns7O7UePlvVHG7D3YWfnnca7XhopBPid3RTf+H/ STSTypZEzljtnpveWEzMdtAJdPvXd/XS2F7aBZS02aTORMXg2BJFtue+TTAnMuVLarak DUjX6dsosDF6Jm4i0hHfO5e/WPhqDcSeLqSyhmP0WmNq2vcy9lFLOmlXuKzIDZdBkeQN Y7xa7nyURNcxjqJkWSalqICKC1epJhKXSAnoTpMAJfcUJ6CSWKx+UUBrIvrUXAvV5K2C wLRQ== X-Gm-Message-State: AJIora8BURl7Z43FdVFozIYqzUjXPKEQC0UvodoZqfXmu332pHGXbj+d h+twuWuMFI656AFILae3px5e25qUQZu1wQ== X-Google-Smtp-Source: AGRyM1sCNegJrDtUYTOOamWo7IQ6uTZYQOQ02ojmyPBnKh++Q7EWMLoeNc8UwznTaOuo39YXrVrI3Msk2Qp5Zg== X-Received: from shakeelb.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:28b]) (user=shakeelb job=sendgmr) by 2002:a25:d406:0:b0:66e:c6b3:f11e with SMTP id m6-20020a25d406000000b0066ec6b3f11emr692378ybf.354.1658506980198; Fri, 22 Jul 2022 09:23:00 -0700 (PDT) Date: Fri, 22 Jul 2022 16:22:57 +0000 In-Reply-To: <20220722164949.47760-1-jiebin.sun@intel.com> Message-Id: <20220722162257.bl5zhc7ta6jvuy5e@google.com> Mime-Version: 1.0 References: <20220722164949.47760-1-jiebin.sun@intel.com> Subject: Re: [PATCH] mm: Remove the redundant updating of stats_flush_threshold From: Shakeel Butt To: Jiebin Sun Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, songmuchun@bytedance.com, akpm@linux-foundation.org, tim.c.chen@intel.com, ying.huang@intel.com, amadeuszx.slawinski@linux.intel.com, tianyou.li@intel.com, wangyang.guo@intel.com Content-Type: text/plain; charset="us-ascii" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658506981; a=rsa-sha256; cv=none; b=ALw34KrEmv+fmJhjVlzXpPof1iwse139rgEYRm1IWGr2nUcltzymgRpDvYfgk2lAHpaN5r fRIkPbrjqZtMfQxeQ07loL/yuFC6xqeQaPruMGKyE0cR/KPp4XXp9oPC8bwb1HLvxIN293 GnB4XX2c3+8a/be1U/8Ui5K/zNwHff0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=UdOoN7qs; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of 35M7aYggKCAs3slvppwmrzzrwp.nzxwty58-xxv6lnv.z2r@flex--shakeelb.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=35M7aYggKCAs3slvppwmrzzrwp.nzxwty58-xxv6lnv.z2r@flex--shakeelb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658506981; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1v2THhkhdYklOspAmtCEFIjJCUUKeZARMXv38MhEpow=; b=RYKPmAQnHqujnQ/7P4aEMbNh2vwagNOmaH888+vWet4H2krxsS+DS3Z7xo5Nbzr2oU5AvV LaPuNE3yM5Q11BY0i/dTEMz4HExBlpgKoksH8XXEcuCcckefsq3IwqD5J3F0z3aoAMx8XO e7DwhcHDlw15U/QQyTjV9f0I7jzC0Kg= Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=UdOoN7qs; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of 35M7aYggKCAs3slvppwmrzzrwp.nzxwty58-xxv6lnv.z2r@flex--shakeelb.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=35M7aYggKCAs3slvppwmrzzrwp.nzxwty58-xxv6lnv.z2r@flex--shakeelb.bounces.google.com X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0FA954001E X-Stat-Signature: m5mz5r89t3mdp56f38ahgf5s9ftyinzw X-HE-Tag: 1658506980-867904 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jul 23, 2022 at 12:49:49AM +0800, Jiebin Sun wrote: > From: jiebin sun > > Remove the redundant updating of stats_flush_threshold. If the > global var stats_flush_threshold has exceeded the trigger value > for __mem_cgroup_flush_stats, further increment is unnecessary. > > Apply the patch and test the pts/hackbench-1.0.0 Count:4 (160 threads). > > Score gain: 1.95x > Reduce CPU cycles in __mod_memcg_lruvec_state (44.88% -> 0.12%) > > CPU: ICX 8380 x 2 sockets > Core number: 40 x 2 physical cores > Benchmark: pts/hackbench-1.0.0 Count:4 (160 threads) > > Signed-off-by: Jiebin Sun Yes, this makes sense. No need to dirty a cacheline if we are already over the threshold. Acked-by: Shakeel Butt