From: Alistair Popple <apopple@nvidia.com>
To: akpm@linux-foundation.org
Cc: david@redhat.com, alex.sierra@amd.com, Felix.Kuehling@amd.com,
linux-mm@kvack.org, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org,
Alistair Popple <apopple@nvidia.com>
Subject: [PATCH] mm/gup.c: Fix formating in check_and_migrate_movable_page()
Date: Thu, 21 Jul 2022 12:05:52 +1000 [thread overview]
Message-ID: <20220721020552.1397598-2-apopple@nvidia.com> (raw)
In-Reply-To: <20220721020552.1397598-1-apopple@nvidia.com>
Commit b05a79d4377f ("mm/gup: migrate device coherent pages when pinning
instead of failing") added a badly formatted if statement. Fix it.
Signed-off-by: Alistair Popple <apopple@nvidia.com>
Reported-by: David Hildenbrand <david@redhat.com>
---
Apologies Andrew for missing this. Hopefully this fixes things.
mm/gup.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/gup.c b/mm/gup.c
index 364b274a10c2..c6d060dee9e0 100644
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -1980,8 +1980,8 @@ static long check_and_migrate_movable_pages(unsigned long nr_pages,
folio_nr_pages(folio));
}
- if (!list_empty(&movable_page_list) || isolation_error_count
- || coherent_pages)
+ if (!list_empty(&movable_page_list) || isolation_error_count ||
+ coherent_pages)
goto unpin_pages;
/*
--
2.35.1
next prev parent reply other threads:[~2022-07-21 2:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-21 2:05 Alistair Popple
2022-07-21 2:05 ` Alistair Popple [this message]
2022-07-21 8:01 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220721020552.1397598-2-apopple@nvidia.com \
--to=apopple@nvidia.com \
--cc=Felix.Kuehling@amd.com \
--cc=akpm@linux-foundation.org \
--cc=alex.sierra@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=david@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox