From: "Zach O'Keefe" <zokeefe@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, Hugh Dickins <hughd@google.com>,
Yang Shi <shy828301@gmail.com>,
Miaohe Lin <linmiaohe@huawei.com>,
"Zach O'Keefe" <zokeefe@google.com>
Subject: [PATCH mm-unstable 4/4] Revert "mm/madvise: add huge_memory:mm_madvise_collapse tracepoint"
Date: Wed, 20 Jul 2022 07:06:03 -0700 [thread overview]
Message-ID: <20220720140603.1958773-5-zokeefe@google.com> (raw)
In-Reply-To: <20220720140603.1958773-1-zokeefe@google.com>
In the anonymous collapse path, huge_memory:mm_khugepaged_scan_pmd can
be used to get roughly the same information as this proposed tracepoint.
Remove it.
Fixes: 0fff8a0de881 ("mm/madvise: add huge_memory:mm_madvise_collapse tracepoint")
Link: https://lore.kernel.org/linux-mm/Ys2vzYyVFmljt+B8@google.com/
Signed-off-by: Zach O'Keefe <zokeefe@google.com>
---
include/trace/events/huge_memory.h | 22 ----------------------
mm/khugepaged.c | 2 --
2 files changed, 24 deletions(-)
diff --git a/include/trace/events/huge_memory.h b/include/trace/events/huge_memory.h
index 38d339ffdb16..55392bf30a03 100644
--- a/include/trace/events/huge_memory.h
+++ b/include/trace/events/huge_memory.h
@@ -167,27 +167,5 @@ TRACE_EVENT(mm_collapse_huge_page_swapin,
__entry->ret)
);
-TRACE_EVENT(mm_madvise_collapse,
-
- TP_PROTO(struct mm_struct *mm, unsigned long addr, int result),
-
- TP_ARGS(mm, addr, result),
-
- TP_STRUCT__entry(__field(struct mm_struct *, mm)
- __field(unsigned long, addr)
- __field(int, result)
- ),
-
- TP_fast_assign(__entry->mm = mm;
- __entry->addr = addr;
- __entry->result = result;
- ),
-
- TP_printk("mm=%p addr=%#lx result=%s",
- __entry->mm,
- __entry->addr,
- __print_symbolic(__entry->result, SCAN_STATUS))
-);
-
#endif /* __HUGE_MEMORY_H */
#include <trace/define_trace.h>
diff --git a/mm/khugepaged.c b/mm/khugepaged.c
index 70e9d9950415..28cb8429dad4 100644
--- a/mm/khugepaged.c
+++ b/mm/khugepaged.c
@@ -2452,8 +2452,6 @@ int madvise_collapse(struct vm_area_struct *vma, struct vm_area_struct **prev,
if (!mmap_locked)
*prev = NULL; /* Tell caller we dropped mmap_lock */
- trace_mm_madvise_collapse(mm, addr, result);
-
switch (result) {
case SCAN_SUCCEED:
case SCAN_PMD_MAPPED:
--
2.37.0.170.g444d1eabd0-goog
next prev parent reply other threads:[~2022-07-20 14:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 14:05 [PATCH mm-unstable 0/4] mm: fixes for userspace hugepage collapse, v7 Zach O'Keefe
2022-07-20 14:06 ` [PATCH mm-unstable 1/4] mm/khugepaged: Use minimal bits to store num page < HPAGE_PMD_NR Zach O'Keefe
2022-07-20 17:26 ` Yang Shi
2022-07-21 0:41 ` David Rientjes
2022-07-20 14:06 ` [PATCH mm-unstable 2/4] mm/khugepaged: consistently order cc->is_khugepaged and pte_* checks Zach O'Keefe
2022-07-20 17:27 ` Yang Shi
2022-07-20 19:09 ` Zach O'Keefe
2022-07-21 0:42 ` David Rientjes
2022-07-20 14:06 ` [PATCH mm-unstable 3/4] mm/khugepaged: delay computation of hpage boundaries until use Zach O'Keefe
2022-07-20 17:30 ` Yang Shi
2022-07-21 0:43 ` David Rientjes
2022-07-20 14:06 ` Zach O'Keefe [this message]
2022-07-20 17:30 ` [PATCH mm-unstable 4/4] Revert "mm/madvise: add huge_memory:mm_madvise_collapse tracepoint" Yang Shi
2022-07-21 0:43 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220720140603.1958773-5-zokeefe@google.com \
--to=zokeefe@google.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linmiaohe@huawei.com \
--cc=linux-mm@kvack.org \
--cc=shy828301@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox