From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2A76C433EF for ; Wed, 20 Jul 2022 06:58:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0DAA16B0072; Wed, 20 Jul 2022 02:58:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 08C536B0073; Wed, 20 Jul 2022 02:58:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E94086B0074; Wed, 20 Jul 2022 02:58:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DADE06B0072 for ; Wed, 20 Jul 2022 02:58:21 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A22C81A04E1 for ; Wed, 20 Jul 2022 06:58:21 +0000 (UTC) X-FDA: 79706574402.31.75F540C Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by imf09.hostedemail.com (Postfix) with ESMTP id 3824A140097 for ; Wed, 20 Jul 2022 06:58:21 +0000 (UTC) Received: by mail-pg1-f169.google.com with SMTP id o18so15584096pgu.9 for ; Tue, 19 Jul 2022 23:58:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=AF+KtcQcuFeKsfB6J6qxSptBOPPY8MNLklD1mjEET1o=; b=VRCq53cYNSDyBLSgveHJIkDyFrcNcVtzhsy5iMjhubVqaq4jcpMqJ9oYTP+MzSbY82 UAbEyfZ4oPvv4q1iADvhggNOfrn1oSl4zSZYn1/+cfBl27yU4jZcpC9AZHk4Kh3ulHzv iJGqmnB4CG/wFSwt09/Vtf/b8l3p0/9JDcH5b+aM4EwjMIh4XfBqeaxBVlll4t/El0x6 WS0RtSy5CAZ/WFSCD247Lfog/EShj7J3FlBVY22x03rrq25NRE7CPdpp59ih6+NIHhup q/b5BewK7+XUA4ltxxWf0kUy4AlUcjp/71y3CG2lxQtsUYOb+9HKFagxu6s+mp+DPC78 4Vcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=AF+KtcQcuFeKsfB6J6qxSptBOPPY8MNLklD1mjEET1o=; b=mzW+fOiqSqwXBUxUje/kimT4dW1UNp61WI73Sho/Y0MuYsYuvpHCOv/jv8+miXLk0G M0X6r5V5so82nTQz6PXlNXumjENWYInn1pAapz3fZ45VEdE7nyTloQaSQFKK71Cy/7Ej tZbSeCr6v4xDpTtbnp4++HsDOUFCJlE57s/QUdfIPczRCl3StEHuibeRaLzYHLUbesC3 quJFddva9CzQ5Ncqd0gM9CgEjm3ktU7bHnMKlWrXz9gXKt1Ujp7NF5qVvTrA0ACRXMD2 iq2RU4TVl4OrHjvOj4xhRttitfPZNwS8CEWpAG7gXBI/ClD7cSdZsJLDLfSCBPjH7hXn pm0A== X-Gm-Message-State: AJIora/3tKOTZjssVqpXa9UIvQZ7+AaNTS6GoJFDzdWGOrrWUjjl+Nsb lLoNjEsvaHHkVra8we4wmI4= X-Google-Smtp-Source: AGRyM1ttMlhZniegm1mHRwgoJ8M+tVlGTnaE3XuxDhaTCJ3hXSgnasW42hbWPv7tAuZTaVQQPmdYbQ== X-Received: by 2002:a05:6a00:793:b0:52a:b261:f8e7 with SMTP id g19-20020a056a00079300b0052ab261f8e7mr37269509pfu.20.1658300300172; Tue, 19 Jul 2022 23:58:20 -0700 (PDT) Received: from localhost.localdomain ([43.132.141.4]) by smtp.gmail.com with ESMTPSA id c6-20020a63d146000000b0040d75537824sm11201782pgj.86.2022.07.19.23.58.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 23:58:19 -0700 (PDT) From: zengjx95@gmail.com To: vitaly.wool@konsulko.com, linmiaohe@huawei.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zeng Jingxiang Subject: [PATCH] mm/z3fold: do not unlock in z3fold_page_putback() Date: Wed, 20 Jul 2022 14:57:44 +0800 Message-Id: <20220720065744.1006305-1-zengjx95@gmail.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=VRCq53cY; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of zengjx95@gmail.com designates 209.85.215.169 as permitted sender) smtp.mailfrom=zengjx95@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658300301; a=rsa-sha256; cv=none; b=JKaJBbvWd/AhcNR4HW/4Z6TlCGQThlnNXk3XPVrOnqVjeyAC2OHLsqoaSARaup4RgOcxOI VT3Q7LIswX5PQmx4LvucDBP5VpbNqUH7BIQKXYpk1v489Au9MP1xhhuDJ/U2uO4lrY8ctp 177Wx4w6K/ccsCzQy+TXLfb28aK+2lI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658300301; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=AF+KtcQcuFeKsfB6J6qxSptBOPPY8MNLklD1mjEET1o=; b=6PCk885/8tb8ek7VKFDXi+W28idAebuRL2iATOd+G/U3TJAs2b8n/UiadGl1RRIClSmagc woUZ/gfYeMLryItAU02a9Qu7xHe9Nmwlh3L95rjvKQFtGh1DyJn5/arDRlS4NeVm/RPRFr 3wgf2HoGHE6cLjEm9LHmXGM11LCiBeo= X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 3824A140097 Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=VRCq53cY; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of zengjx95@gmail.com designates 209.85.215.169 as permitted sender) smtp.mailfrom=zengjx95@gmail.com X-Stat-Signature: bkn8r16ytggw9c5ams5aa9tj86n635ky X-HE-Tag: 1658300301-462634 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Zeng Jingxiang z3fold_page_lock() will lock zhdr->page_lock 1630 z3fold_page_lock(zhdr); return without unlocking zhdr->page_lock 1634 if (kref_put(&zhdr->refcount, release_z3fold_page_locked)) 1635 return; Signed-off-by: Zeng Jingxiang --- mm/z3fold.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/z3fold.c b/mm/z3fold.c index f41f8b0d9e9a..03785832ad47 100644 --- a/mm/z3fold.c +++ b/mm/z3fold.c @@ -1632,13 +1632,14 @@ static void z3fold_page_putback(struct page *page) list_del_init(&zhdr->buddy); INIT_LIST_HEAD(&page->lru); if (kref_put(&zhdr->refcount, release_z3fold_page_locked)) - return; + goto ret; spin_lock(&pool->lock); list_add(&page->lru, &pool->lru); spin_unlock(&pool->lock); if (list_empty(&zhdr->buddy)) add_to_unbuddied(pool, zhdr); clear_bit(PAGE_CLAIMED, &page->private); +ret: z3fold_page_unlock(zhdr); } -- 2.27.0