From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3101C433EF for ; Wed, 20 Jul 2022 01:12:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2EF0D6B0072; Tue, 19 Jul 2022 21:12:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 29FA26B0073; Tue, 19 Jul 2022 21:12:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 18DAF6B0074; Tue, 19 Jul 2022 21:12:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 098C26B0072 for ; Tue, 19 Jul 2022 21:12:02 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C86D71603DA for ; Wed, 20 Jul 2022 01:12:01 +0000 (UTC) X-FDA: 79705701642.07.A223FDA Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id 4FE1440061 for ; Wed, 20 Jul 2022 01:12:01 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 71E8D6173B; Wed, 20 Jul 2022 01:12:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E463DC341CA; Wed, 20 Jul 2022 01:11:58 +0000 (UTC) Date: Tue, 19 Jul 2022 21:11:56 -0400 From: Steven Rostedt To: Kent Overstreet Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, pmladek@suse.com, enozhatsky@chromium.org, linux@rasmusvillemoes.dk, willy@infradead.org Subject: Re: [PATCH v4 00/34] Printbufs - new data structure for building strings Message-ID: <20220719211156.75ea9255@rorschach.local.home> In-Reply-To: References: <20220620004233.3805-1-kent.overstreet@gmail.com> <20220719191522.4002a5fb@gandalf.local.home> <7462e934-f746-eef7-ff92-0eeb8cc08b82@gmail.com> <20220719200507.361b06ee@rorschach.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658279521; a=rsa-sha256; cv=none; b=k+3BxnZPY1Rrffi1aHFKcnDdKjmHhuntvAFaTzXYNoxQ+WA9GwvshmhqHPT7AEs+9TER1G jzMaTOaK3KlsdNmKBOXJAjbw++lT+P35c08W7SlHaBdx/Om5hnfQ1Y0D9K5HAT+1Sj3aeH Zo3pdjJ08a5FpYQQ55Kvb9IS6RN4mFE= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of "SRS0=7KbO=XZ=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=7KbO=XZ=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658279521; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=okjvJ95zFh/IHjvJB7Xjiq8iad5ivKqw9bXddEwFagY=; b=8Es51ej23g//4LRLOZRs9OqATz8tjT5jpKkdlYuoBK2eJQYTTZxcdkKjTte97uVMmJfS0T JWI1qnrlIEpSs7FvDFyZq0IttpP7Jgx6A+P41i6DFEbr2GLylpTPFEFF5MHgkMw7RmeiIJ 3RQ/fXaoOWIVOZcMX4FP/xQWWYu70kc= X-Stat-Signature: r9h9b8us8crn4rzgjq87y6nywesa5q8j X-Rspamd-Queue-Id: 4FE1440061 Authentication-Results: imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of "SRS0=7KbO=XZ=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=7KbO=XZ=goodmis.org=rostedt@kernel.org"; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1658279521-76674 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 19 Jul 2022 20:17:45 -0400 Kent Overstreet wrote: > > More specific please. > > Steve, look at the man page for snprintf if you don't see what I mean. > This discussion has become entirely too tedious, and your _only_ > contribution to the discussion on pretty-printers has been "why isn't > this using this thing I made?". No, my response is, why should we replace something that is working just fine? The burden is on you. For this to get accepted you have to show why a risk of regression in the Linux kernel is worth the update. We don't just say "hey this is better, take it!". That's not how this works. There needs to be real needs to be met. > > You haven't been contributing to the discussion, you haven't been > helping figure out what the APIs, helpers, data structures should look > like, IOW _actually_ building something that could serve as a low level > string formatting library. What exactly is it that is better. In stead of yelling about what I haven't done, tell me what you plan on doing that will make *our* lives better. Code is "pulled" not "pushed". If all you can do is push, then you are going to end up being quite disappointed. What exactly is the use case here? > > I get that you're busy - but look, we all are, and this patch series has > already been set back what, a month and a half while I was waiting on you. Sorry, but I did warn you. I did start a new job and then I had several conferences that I was writing code to present. That is, the things I was talking about wasn't even finished yet. So those were very *hard* deadlines (on top of my day job). I told you upfront that it may be months before I can look at it. I was fully transparent. > > I've got the tests now, I'll CC you when v5 is posted. And I expect you to have an explanation on why this is worth the effort. -- Steve