From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0880C433EF for ; Tue, 19 Jul 2022 23:15:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0534A6B0072; Tue, 19 Jul 2022 19:15:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0033B6B0073; Tue, 19 Jul 2022 19:15:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E349A6B0074; Tue, 19 Jul 2022 19:15:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D3B9B6B0072 for ; Tue, 19 Jul 2022 19:15:26 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A3EE7A03C2 for ; Tue, 19 Jul 2022 23:15:26 +0000 (UTC) X-FDA: 79705407852.12.EE91146 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 41589140099 for ; Tue, 19 Jul 2022 23:15:26 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9982D60E08; Tue, 19 Jul 2022 23:15:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B313C341C6; Tue, 19 Jul 2022 23:15:24 +0000 (UTC) Date: Tue, 19 Jul 2022 19:15:22 -0400 From: Steven Rostedt To: Kent Overstreet Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, pmladek@suse.com, enozhatsky@chromium.org, linux@rasmusvillemoes.dk, willy@infradead.org Subject: Re: [PATCH v4 00/34] Printbufs - new data structure for building strings Message-ID: <20220719191522.4002a5fb@gandalf.local.home> In-Reply-To: <20220620004233.3805-1-kent.overstreet@gmail.com> References: <20220620004233.3805-1-kent.overstreet@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf09.hostedemail.com: domain of "SRS0=c0m8=XY=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=c0m8=XY=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658272526; a=rsa-sha256; cv=none; b=K0YsUcz6Se2TqkJKnNYjolYrBTz0dOgDfxklSvkjj6sdymWGH/D3cq0P3JvMAFRlvgeEJY ifIbv4cg66ztD514uCTOEHY5Hf7WIm/uQOaqTDTqvfzNPbojrdtbKICK5FrHq8c/qTvdqX d2ayVLKI5Uom3Fb0ueuWe2XlHH1r7Ec= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658272526; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KkdLd46sPJqoaK4Y2kM0IqPJi3nlBjxUbTWP3FfuYqo=; b=uvp2DzaBiUD3Lfl7Lv85IZotfaaPbJ6LMzieW3nQt1YFKHvoXf3GuUobrd8+4H54FQzeF/ 7LZGlSPtxWkO/zGPj+2J1ZNmvfyZHrxuOS8/+lEPfw7FxQU5UBuEjL5a1MdfNSi35iWIVn kS3LhS2IvHtDsnCItnVhj8hdTAtjlUI= X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 41589140099 Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf09.hostedemail.com: domain of "SRS0=c0m8=XY=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=c0m8=XY=goodmis.org=rostedt@kernel.org" X-Stat-Signature: ggx76ppxt4uhroqakopdsuh69h5g9idh X-HE-Tag: 1658272526-268976 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 19 Jun 2022 20:41:59 -0400 Kent Overstreet wrote: > Core idea: Wouldn't it be nice if we had a common data structure and calling > convention for outputting strings? Because seq_buf gives us this already, the cover letter really just needs to state exactly what the benefit is to replace seq_buf with printbuf (and why seq_buf can not be simply extended to do some extra features). I just applied your series and ran the tracing selftests and several of them failed. # cd tools/testing/selftests/ftrace/ # ./ftracetest This means that this is not a simple replacement and that there's going to be regressions with this change. The question is, is the added benefits of doing the change greater than the fallout of the regressions? -- Steve