From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DD90C433EF for ; Mon, 18 Jul 2022 14:58:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C4A2D6B0072; Mon, 18 Jul 2022 10:58:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BFAEB6B0073; Mon, 18 Jul 2022 10:58:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE8736B0074; Mon, 18 Jul 2022 10:58:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A056D6B0072 for ; Mon, 18 Jul 2022 10:58:30 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 5BBAA120CFD for ; Mon, 18 Jul 2022 14:58:30 +0000 (UTC) X-FDA: 79700526780.31.458DA9B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf09.hostedemail.com (Postfix) with ESMTP id D121E14008E for ; Mon, 18 Jul 2022 14:58:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658156309; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=y84+fqq0ic53Qb8imRAdbfxigr2ZrJ0QF7UhEw8hqwU=; b=Ar4qt2cB7rmwkvzjXwVblIR3fKjMTJvEi7GA5FYLF93gewy6z0Hy6MTSi50tepMYiZAjii kfy0G26VlfqmWmNGYtISFvnePRO/M0EBh88/7PN08/6jYESvNWKzK5Vl76zE0JbiioOzbm k7lASd/+QiGUlzguZp9FMnb6FSkG7uM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-111-5T98dFsXOhOuqQwQ7WlcJg-1; Mon, 18 Jul 2022 10:58:28 -0400 X-MC-Unique: 5T98dFsXOhOuqQwQ7WlcJg-1 Received: by mail-wm1-f71.google.com with SMTP id n19-20020a05600c3b9300b003a314062cf4so2140424wms.0 for ; Mon, 18 Jul 2022 07:58:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=y84+fqq0ic53Qb8imRAdbfxigr2ZrJ0QF7UhEw8hqwU=; b=Dgs30E5zU5TgcB7M2LXwzMek1dXWhYOR9a50tlznwY4RBPOrL4COUR1Xpo6KOUHWOL s7Qp72brD0kXRYego2SPjujs/UJ7RD498JW1fKZtdpJIaZoenl/QAiexzk7BFbO2/bKz rPOp4PIt7ghuHPibT9yLvbzyntuthpI3x41t/qzeysCed2iUz37jBXFSXDrWBnTx4HOI PvgJSNHYOqBHBySBGApgFLAaAf24KaZqHF4HS8fHfJFqN6V4t8w86PD8CXPJxTRcL1iU DndaUIlJWt1ZPxYmOnC7NFekVU6WAF9GmowXUHGcoxiG3SIgboXWxMtrrXzn1Qce0RgA LVlQ== X-Gm-Message-State: AJIora9S4YpslhBtxYbThkFRGivqX24eM32JgXnuTtICHLAkZ/jtcDRh 96TEMyQEdPQtg/j27SFav5E7dWBr9ptapfL/S4iXyLDSH4xOG63psXZ7wgiC28OFCuOa+pdtr4c ARlDBBBfssQ== X-Received: by 2002:a7b:c30d:0:b0:3a1:861a:b9bc with SMTP id k13-20020a7bc30d000000b003a1861ab9bcmr26347261wmj.97.1658156307243; Mon, 18 Jul 2022 07:58:27 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uSr7sUpCPiES1pHGOAztVCqqEUoPZgST6vOGQw2A0+oXcpwZHEXiCM7up4uQSFVn2Yki3ZPQ== X-Received: by 2002:a7b:c30d:0:b0:3a1:861a:b9bc with SMTP id k13-20020a7bc30d000000b003a1861ab9bcmr26347243wmj.97.1658156307039; Mon, 18 Jul 2022 07:58:27 -0700 (PDT) Received: from localhost (cpc111743-lutn13-2-0-cust979.9-3.cable.virginm.net. [82.17.115.212]) by smtp.gmail.com with ESMTPSA id bd20-20020a05600c1f1400b003a3211112f8sm78442wmb.46.2022.07.18.07.58.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Jul 2022 07:58:26 -0700 (PDT) Date: Mon, 18 Jul 2022 15:58:25 +0100 From: Aaron Tomlin To: Marcelo Tosatti Cc: frederic@kernel.org, cl@linux.com, tglx@linutronix.de, mingo@kernel.org, peterz@infradead.org, pauld@redhat.com, neelx@redhat.com, oleksandr@natalenko.name, atomlin@atomlin.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH v4] tick/sched: Ensure quiet_vmstat() is called when the idle tick was stopped too Message-ID: <20220718145825.ojncoyjoumjibisx@ava.usersys.com> X-PGP-Key: http://pgp.mit.edu/pks/lookup?search=atomlin%40redhat.com X-PGP-Fingerprint: 7906 84EB FA8A 9638 8D1E 6E9B E2DE 9658 19CC 77D6 References: <20220621172207.1501641-1-atomlin@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658156310; a=rsa-sha256; cv=none; b=ZekdQ6ynKw6q076HrL18fZwOdXY4bXmEP0Y19hZ3CUrqtN2pKLSsAw5lv5pO80eId15DPv eDMmNaxzv/GvM/ltgB9Tlt9xc7nsu3QAyISQ21syBoAd7ZYxBqflmEx9/fGnCLtX4yYGPY XdquhcL3ch6lpUPBm5ufakTTyLhO9FU= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ar4qt2cB; spf=none (imf09.hostedemail.com: domain of atomlin@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=atomlin@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658156310; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y84+fqq0ic53Qb8imRAdbfxigr2ZrJ0QF7UhEw8hqwU=; b=b5suf08dTyXiiCo7pph5cQ5VBQzymdxQgfAioC0FKZIAdjxLiDRYwwTIGakgQIbipWwfFf TpaP5H2QKRAhc2gV6o18ZkVb2iIoMP6tlj1jGFarIiEDyS7KfMkQNp6641j40308QQO06G kDdVI4LCIQRUilTYaCxFXvnF4aVzR6k= X-Stat-Signature: zkbcgc6y3me9mpfg8umxa34yobkqudgo X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D121E14008E X-Rspam-User: Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ar4qt2cB; spf=none (imf09.hostedemail.com: domain of atomlin@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=atomlin@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1658156309-613009 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 2022-07-18 10:46 -0300, Marcelo Tosatti wrote: > Aaron, Hi Marcelo, > You'd probably want to separate the vmstat_dirty changes from the > tick_nohz_user_enter_prepare changes, for bisectability. Thank you for the feedback and will do. > Otherwise looks good to me (and comments made on previous > RFC versions have been addressed). Kind regards, -- Aaron Tomlin