From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8B6DC43334 for ; Mon, 18 Jul 2022 20:32:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 611658E0001; Mon, 18 Jul 2022 16:32:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C1316B0073; Mon, 18 Jul 2022 16:32:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D7008E0001; Mon, 18 Jul 2022 16:32:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3A7F46B0071 for ; Mon, 18 Jul 2022 16:32:41 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 08A2332F34 for ; Mon, 18 Jul 2022 20:32:41 +0000 (UTC) X-FDA: 79701368922.13.F63966D Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf15.hostedemail.com (Postfix) with ESMTP id 7E168A0076 for ; Mon, 18 Jul 2022 20:32:39 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 92AE3B8179F; Mon, 18 Jul 2022 20:32:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC1B2C341C0; Mon, 18 Jul 2022 20:32:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1658176356; bh=tVhY1ahFLjj6vTGPep6MAG7OR+bCm6MQ/EAA9xTV0WI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=0dw4cFB42gg7zj8HiQLc7D+Npd1QELSrzQuuDGx8jBrtkX5XSY6IdxrkIDJPU2Cda tAqDaeoI64/mIBlrH5Ua4Ub73MSKc4+PLVOj1xGe4Ppk7yJT8pAdAbIMDrWigRp2+7 0rgoEva+ImYH2rnIxXKDMOVONVzb6MdwtWcG4A/A= Date: Mon, 18 Jul 2022 13:32:35 -0700 From: Andrew Morton To: David Hildenbrand Cc: Alex Sierra , jgg@nvidia.com, Felix.Kuehling@amd.com, linux-mm@kvack.org, rcampbell@nvidia.com, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, hch@lst.de, jglisse@redhat.com, apopple@nvidia.com, willy@infradead.org Subject: Re: [PATCH v9 06/14] mm/gup: migrate device coherent pages when pinning instead of failing Message-Id: <20220718133235.4fdbd6ec303219e5a3ba49cf@linux-foundation.org> In-Reply-To: <225554c2-9174-555e-ddc0-df95c39211bc@redhat.com> References: <20220715150521.18165-1-alex.sierra@amd.com> <20220715150521.18165-7-alex.sierra@amd.com> <225554c2-9174-555e-ddc0-df95c39211bc@redhat.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658176359; a=rsa-sha256; cv=none; b=efSHhe1bI8kuZbT0+5HnfirzIqHZcD0HLiwI7yBuIEeba9YRV4LHvNSc0SmIvTj9R578nA Be6XpNQMsJZ3L8RMHNxiGTZKt9lHOFVS3U3UgUboDYVpZxCTmxOQ3H7m0q8OWSZYxSPc5K VP+y6H+66GBJD/BGYKCWRyE/vuAsLpU= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=0dw4cFB4; dmarc=none; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658176359; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Go5bRj6nbg5zp/JOzdEXeYLKiS3yn4uksbgwmbd8Tf8=; b=J83iOqUWw3x6owmGIhpiI7tGoE99zUMeR6BUscMdf86PXi0D7CPVVD3pMz2YuosYdViwrW glj/R9+iQlz/QX6t6KjE4YSTgukS4LSITr8FniihBAZOLTm5gvXgCBg4JzzSGJnZLgAttV 2lVTN0CuELW6mNDo9dEI7w3dXd17KvA= X-Rspam-User: Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=0dw4cFB4; dmarc=none; spf=pass (imf15.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Stat-Signature: 3nzpff8u5a8woyydmzq3m44p15stg8z4 X-Rspamd-Queue-Id: 7E168A0076 X-Rspamd-Server: rspam02 X-HE-Tag: 1658176359-654392 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 18 Jul 2022 12:56:29 +0200 David Hildenbrand wrote: > > /* > > * Try to move out any movable page before pinning the range. > > */ > > @@ -1919,7 +1948,8 @@ static long check_and_migrate_movable_pages(unsigned long nr_pages, > > folio_nr_pages(folio)); > > } > > > > - if (!list_empty(&movable_page_list) || isolation_error_count) > > + if (!list_empty(&movable_page_list) || isolation_error_count > > + || coherent_pages) > > The common style is to > > a) add the || to the end of the previous line > b) indent such the we have a nice-to-read alignment > > if (!list_empty(&movable_page_list) || isolation_error_count || > coherent_pages) > I missed that. This series is now in mm-stable so any fix will need to be a standalone followup patch, please. > Apart from that lgtm. > > Reviewed-by: David Hildenbrand And your reviewed-by's will be lost. Stupid git.