From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F831C43334 for ; Mon, 18 Jul 2022 04:27:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D0976B0071; Mon, 18 Jul 2022 00:27:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 48DC56B0072; Mon, 18 Jul 2022 00:27:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36D206B0073; Mon, 18 Jul 2022 00:27:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 275C76B0071 for ; Mon, 18 Jul 2022 00:27:36 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C8D283F3 for ; Mon, 18 Jul 2022 04:27:35 +0000 (UTC) X-FDA: 79698936870.18.D948B6C Received: from smtpbg150.qq.com (smtpbg150.qq.com [18.132.163.193]) by imf23.hostedemail.com (Postfix) with ESMTP id 9665F140066 for ; Mon, 18 Jul 2022 04:27:32 +0000 (UTC) X-QQ-mid: bizesmtp72t1658118445tnsmgzp7 Received: from 38c3a67cb865 ( [223.72.63.90]) by bizesmtp.qq.com (ESMTP) with id ; Mon, 18 Jul 2022 12:27:12 +0800 (CST) X-QQ-SSF: 0140000000000070C000B00A0000000 X-QQ-FEAT: mVJZl7SIEggJ8So9Qm8JLcX2FlSmkb6rX44MwRzxJ64PDsZXzEz6o9eLzZxkU inGEFsA0I0sVIXUp40WF29n1mYQbZ02cNGSH4Hd0RJbg8/Y/1D25Er616jJbiNlQ+FV509n 7Eap6/w5jfyiFE+SjXFkO9IaMhfXkhrrCPZ2bhKDS+aR0la2fPkadOHQxgmzO4IWiiD3ZGc VUaUNCmITDBIddVwYDl0ut7bjMhhU/D6UafNMST6w2QuC1q+5HeGPq8RwniL8Y14QDrgS4h Hv8rHa+ioAab/T0fh4ipEFalHq5kFXGKccinVzS4AT9i/FR8hP3NJjlYTsMpLWsgDIyqEV7 CKdebvgTOa+OG/iktKmb7KQvTn5QJBaoZy8keuv6++EnNEsIRk= X-QQ-GoodBg: 2 Date: Mon, 18 Jul 2022 13:27:09 +0900 From: Li Hongyu To: Matthew Wilcox Cc: "Liam R. Howlett" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Miguel Ojeda Subject: Re: [PATCH] maple: change the pointer name from maple_enode to maple_enode_p Message-ID: <20220718042709.GA18848@38c3a67cb865>+87DA8F192079809D References: <20220717120652.GA9281@38c3a67cb865> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:bupt.edu.cn:qybgforeign:qybgforeign4 X-QQ-Bgrelay: 1 ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=bupt.edu.cn (policy=none); spf=none (imf23.hostedemail.com: domain of lihongyu1999@bupt.edu.cn has no SPF policy when checking 18.132.163.193) smtp.mailfrom=lihongyu1999@bupt.edu.cn ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658118454; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bUvYIee0dxY0PodGQ07t4JVNxT/hOCUlYJ2N+9Owobs=; b=leGHjZ0RUtUD3Q1KvjB5o5lbSgPrHJpogYJXTuETBh8IIouODu3ima/CPyFc7IVkYZ1zzu FQ3190cXUL/ensEqe9DiUyESgzOdC9FrW0uNp96pGyz+SDpYyXIaQUyoVOVyBLOeiRIWr+ YImD6333q9YtxdtSfcvQkKLppQp+XGw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658118454; a=rsa-sha256; cv=none; b=lINqJQ/on8p5cfJYfwBhjjrJwKlpYFvnYtXZjGrE3zxzl+hSVj5LAtdbVjsw+yFj0iNvD2 znzZc25Pl0EeAIz9MHgdbngHoEFcbNyaSExpjPDsY8B+6LR9sNF9pVB2lAAgrK3HXsXuwp EtxfdZjyL+IPYUF7CdlwfYcRE6eMDWU= X-Rspamd-Queue-Id: 9665F140066 X-Rspam-User: Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=bupt.edu.cn (policy=none); spf=none (imf23.hostedemail.com: domain of lihongyu1999@bupt.edu.cn has no SPF policy when checking 18.132.163.193) smtp.mailfrom=lihongyu1999@bupt.edu.cn X-Rspamd-Server: rspam11 X-Stat-Signature: rtkpirx9dsou9ry47zhxj16k4hwfwnuk X-HE-Tag: 1658118452-779688 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jul 17, 2022 at 03:47:55PM +0100, Matthew Wilcox wrote: > If this is the only change needed, then clearly they're not being used, > so just delete them? There is no definition of the struct maple_enode or maple_pnode. This struct is only used as a pointer. There are some comments about this pointer, which will be gone if we delete these two typedef statements. If you worry about generating a not used data type, it may be better to change `struct maple_enode *foo` to `maple_enode_p foo`. This keeps the code more readable and used the maple_enode_p type.