From: Li Hongyu <lihongyu1999@bupt.edu.cn>
To: Matthew Wilcox <willy@infradead.org>
Cc: "Liam R. Howlett" <Liam.Howlett@oracle.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Subject: Re: [PATCH] maple: change the pointer name from maple_enode to maple_enode_p
Date: Mon, 18 Jul 2022 13:27:09 +0900 [thread overview]
Message-ID: <20220718042709.GA18848@38c3a67cb865> (raw)
In-Reply-To: <YtQhGyEw5Tn2eNPh@casper.infradead.org>
On Sun, Jul 17, 2022 at 03:47:55PM +0100, Matthew Wilcox wrote:
> If this is the only change needed, then clearly they're not being used,
> so just delete them?
There is no definition of the struct maple_enode or maple_pnode. This
struct is only used as a pointer. There are some comments about this
pointer, which will be gone if we delete these two typedef statements.
If you worry about generating a not used data type, it may be better to
change `struct maple_enode *foo` to `maple_enode_p foo`. This keeps the
code more readable and used the maple_enode_p type.
prev parent reply other threads:[~2022-07-18 4:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-17 12:12 Li Hongyu
2022-07-17 14:47 ` Matthew Wilcox
2022-07-18 4:27 ` Li Hongyu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220718042709.GA18848@38c3a67cb865 \
--to=lihongyu1999@bupt.edu.cn \
--cc=Liam.Howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox