From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 790B8C433EF for ; Sun, 17 Jul 2022 12:12:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1A676B0071; Sun, 17 Jul 2022 08:12:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A3786B0072; Sun, 17 Jul 2022 08:12:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 891956B0073; Sun, 17 Jul 2022 08:12:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7A9E66B0071 for ; Sun, 17 Jul 2022 08:12:58 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 46AFA2CE for ; Sun, 17 Jul 2022 12:12:58 +0000 (UTC) X-FDA: 79696480836.31.778D981 Received: from smtpbg506.qq.com (smtpbg506.qq.com [203.205.250.33]) by imf05.hostedemail.com (Postfix) with ESMTP id 7452910005A for ; Sun, 17 Jul 2022 12:12:53 +0000 (UTC) X-QQ-mid: bizesmtp66t1658059965tdvcffof Received: from 38c3a67cb865 ( [223.72.63.90]) by bizesmtp.qq.com (ESMTP) with id ; Sun, 17 Jul 2022 20:12:42 +0800 (CST) X-QQ-SSF: 0140000000200070C000B00A0000000 X-QQ-FEAT: nI2I22XnCu6OlB5eMAVVezsBD0tdc4ZxGjCBJJhklKBlXVzkumsWwHG8zo+0F vzohogj+ZA6ARj872R/wp0GAxSUmF6B8mpAbTp48E26XlRNaDrTF4A/NybbVk1rv8c9dL2q GPE7G294v8GA9b5YJB56zbEf3Sd1vKu2JhOyQZylf/fq/LDCowOwaC0vWCakaJRzVBGUGc3 w4vKUqJLvx225p5vmGJ64tqizGGCPYvQzPp92T85cibTSU7QgtJeA/2sTSXTyKjYapy71pF /RSvTLgwWMwNJITB9sOpD9Iyxc/eTnZbFjygnJzAGxu545kS5oUHFIDWdYJwjU4EqzPXYNX O2Au/NB0nx5qJ5PNk53dxLTid3+x1PkSDPXLjutTlhWNu+KFP5k8SUMFqhR64U/3AHqliYD X-QQ-GoodBg: 2 Date: Sun, 17 Jul 2022 21:12:42 +0900 From: Li Hongyu To: "Liam R. Howlett" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Cc: Miguel Ojeda Subject: [PATCH] maple: change the pointer name from maple_enode to maple_enode_p Message-ID: <20220717120652.GA9281@38c3a67cb865>+02520B995FA07857 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:bupt.edu.cn:qybgforeign:qybgforeign3 X-QQ-Bgrelay: 1 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658059975; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references; bh=CCmAErFgJqhgfQsrOHD0Nuo2BN9Ct+hS4r2upChPFfE=; b=G+Bc1f5xat/OzutWsNdO45eYGnJpvjob95nCct9gq/+fQsVurkfhw54FgoSXwnjcZS/F0/ Kz02mtQ0m58gXRBAd/0emSLsKWpWIN/9+P5MWBYJx/Pd3ey3w8GiTPqqosrrGeYagpmuS3 RgtsKJpNVHL4jWVl+DgjiatAaQYuI3o= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; spf=none (imf05.hostedemail.com: domain of lihongyu1999@bupt.edu.cn has no SPF policy when checking 203.205.250.33) smtp.mailfrom=lihongyu1999@bupt.edu.cn; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=bupt.edu.cn (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658059975; a=rsa-sha256; cv=none; b=A3qC2dDn/6QXJK7L73qfWn/AkbinSuVHrqwIm53g/4muzaSRGeAh7grg2k55xNlpScT9fP KpTo/lEsYf8pRF8P3EDI1UpR0yIe/8QW7XHCmnVr49FSo5qdSQIUmJr0YC7vi9dDeVTwgm Hc9JN0mFVzL23Qir8lr/KukNbrmHcOA= X-Stat-Signature: xzi96aqdsw3od4fg54txnergy7dtoacu X-Rspamd-Queue-Id: 7452910005A X-Rspamd-Server: rspam02 X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=none; spf=none (imf05.hostedemail.com: domain of lihongyu1999@bupt.edu.cn has no SPF policy when checking 203.205.250.33) smtp.mailfrom=lihongyu1999@bupt.edu.cn; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=bupt.edu.cn (policy=none) X-HE-Tag: 1658059973-814164 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The current name of the pointer to struct maple_enode is also maple_enode. This is correct from the grammar point but can be comfusing. Besides it seems in Linux it prefers typedef struct foo *foo_p;, e.g. typedef struct cpumask *cpumask_var_t; and typedef struct cgraph_node *cgraph_node_ptr;. I use re to search in the Linux project and cannot find another example in typedef struct foo *foo; style. This also results in a bug in the bindings of the rust-for-linux subsystem, which can be seen in this github issue. https://github.com/Rust-for-Linux/linux/issues/795 The struct pointer maple_enode and maple_pnode are not used. It is safe to change it to a new name. Signed-off-by: Li Hongyu --- include/linux/maple_tree.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/maple_tree.h b/include/linux/maple_tree.h index 2c9dede989c7..4886e019a2b5 100644 --- a/include/linux/maple_tree.h +++ b/include/linux/maple_tree.h @@ -72,8 +72,8 @@ * 0x010 : 32 bit values, type in 0-2, slot in 3-6 * 0x110 : 64 bit values, type in 0-2, slot in 3-6 */ -typedef struct maple_enode *maple_enode; /* encoded node */ -typedef struct maple_pnode *maple_pnode; /* parent node */ +typedef struct maple_enode *maple_enode_p; /* encoded node */ +typedef struct maple_pnode *maple_pnode_p; /* parent node */ /* * This metadata is used to optimize the gap updating code and in reverse -- 2.17.1