From: Andrew Morton <akpm@linux-foundation.org>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: <mike.kravetz@oracle.com>, <songmuchun@bytedance.com>,
<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
Axel Rasmussen <axelrasmussen@google.com>,
Peter Xu <peterx@redhat.com>
Subject: Re: [PATCH] mm/hugetlb: avoid corrupting page->mapping in hugetlb_mcopy_atomic_pte
Date: Sat, 16 Jul 2022 16:06:29 -0700 [thread overview]
Message-ID: <20220716160629.d065828c84ad2423c10f7733@linux-foundation.org> (raw)
In-Reply-To: <a47922cf-eb30-1ad9-fc96-1896254564ef@huawei.com>
On Thu, 14 Jul 2022 17:59:53 +0800 Miaohe Lin <linmiaohe@huawei.com> wrote:
> On 2022/7/14 1:23, Andrew Morton wrote:
> > On Tue, 12 Jul 2022 21:05:42 +0800 Miaohe Lin <linmiaohe@huawei.com> wrote:
> >
> >> In MCOPY_ATOMIC_CONTINUE case with a non-shared VMA, pages in the page
> >> cache are installed in the ptes. But hugepage_add_new_anon_rmap is called
> >> for them mistakenly because they're not vm_shared. This will corrupt the
> >> page->mapping used by page cache code.
> >
> > Well that sounds bad. And theories on why this has gone unnoticed for
> > over a year? I assume this doesn't have coverage in our selftests?
>
> As discussed in another thread, when minor fault handling is proposed, only
> VM_SHARED vma is expected to be supported
So... do we feel that this fix should be backported? And if so, is
there a suitable commit for the Fixes:?
next prev parent reply other threads:[~2022-07-16 23:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 13:05 Miaohe Lin
2022-07-12 17:39 ` Mike Kravetz
2022-07-13 2:10 ` Miaohe Lin
2022-07-13 14:24 ` Peter Xu
2022-07-13 16:10 ` Peter Xu
2022-07-13 22:46 ` Axel Rasmussen
2022-07-13 23:36 ` Mike Kravetz
2022-07-14 0:20 ` Axel Rasmussen
2022-07-14 10:09 ` Miaohe Lin
2022-07-14 15:45 ` Peter Xu
2022-07-15 2:50 ` Miaohe Lin
2022-07-13 17:23 ` Andrew Morton
2022-07-14 9:59 ` Miaohe Lin
2022-07-14 15:52 ` Peter Xu
2022-07-15 3:56 ` Miaohe Lin
2022-07-15 12:35 ` Peter Xu
2022-07-15 16:45 ` Axel Rasmussen
2022-07-15 17:07 ` Peter Xu
2022-07-15 17:28 ` Axel Rasmussen
2022-07-15 17:39 ` Peter Xu
2022-07-15 17:51 ` Axel Rasmussen
2022-07-16 1:32 ` Miaohe Lin
2022-07-15 17:29 ` Mike Kravetz
2022-07-15 17:38 ` Peter Xu
2022-07-16 23:06 ` Andrew Morton [this message]
2022-07-18 2:25 ` Miaohe Lin
2022-07-18 18:07 ` Axel Rasmussen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220716160629.d065828c84ad2423c10f7733@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=peterx@redhat.com \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox