From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6B0AC43334 for ; Thu, 14 Jul 2022 23:11:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0CE879401BE; Thu, 14 Jul 2022 19:11:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 07E9F9401A5; Thu, 14 Jul 2022 19:11:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E884C9401BE; Thu, 14 Jul 2022 19:11:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D99429401A5 for ; Thu, 14 Jul 2022 19:11:54 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A2949349BC for ; Thu, 14 Jul 2022 23:11:54 +0000 (UTC) X-FDA: 79687254948.20.9CF3270 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by imf08.hostedemail.com (Postfix) with ESMTP id 02B9716006A for ; Thu, 14 Jul 2022 23:11:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657840314; x=1689376314; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=IunArioJRyKGylYp46cCoRbmsuO9aqT5+jvNSjPLQZE=; b=WfTgBWXlREQv4c1bmbW+UC36DiMxyg1itNgSFe5fI+duQeAIiWI01EAX jb94UBiv31Ek1toSgr0NbQS8Q3t+5iSh3tBbOHG4FnJ05b0bJWbFPi8lv FnRgoIi0or3uSU4/tD562d/5wHxAQxYu9HsBvw/efqFMq8QrqMRmudm7L s2nOsm6lXbNKKc/I+vdBZ9DslACjAcWBBAWdVuU9lgJRwCDKeMhDB2Tm9 qX3Iv8/XdbKRy6LUpSxgGkMW72u2R6xCg3PAzpdIYxXBJ2cVpe1Zkds+p Vs1Qke7jzqzXpHp5fghpgOvN9C6uQHYStWFxRaS67v00MKBt9nRI0Emw1 g==; X-IronPort-AV: E=McAfee;i="6400,9594,10408"; a="347328589" X-IronPort-AV: E=Sophos;i="5.92,272,1650956400"; d="scan'208";a="347328589" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2022 16:11:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,272,1650956400"; d="scan'208";a="546445779" Received: from lkp-server01.sh.intel.com (HELO fd2c14d642b4) ([10.239.97.150]) by orsmga003.jf.intel.com with ESMTP; 14 Jul 2022 16:11:50 -0700 Received: from kbuild by fd2c14d642b4 with local (Exim 4.95) (envelope-from ) id 1oC7zp-0001Ft-LX; Thu, 14 Jul 2022 23:11:49 +0000 Date: Fri, 15 Jul 2022 07:11:38 +0800 From: kernel test robot To: Theodore Ts'o , Hugh Dickins Cc: kbuild-all@lists.01.org, Andrew Morton , Linux Memory Management List , Theodore Ts'o Subject: Re: [PATCH] mm/shmem: add support for FS_IOC_[SG]ETFLAGS for tmpfs Message-ID: <202207150754.j4ldkYik-lkp@intel.com> References: <20220713145234.2356641-1-tytso@mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220713145234.2356641-1-tytso@mit.edu> ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657840314; a=rsa-sha256; cv=none; b=oD4pW0sKcRO5QF1syP4ikCXs1aOpQK2/KRDX5u93ufTEqgFoIL4PHlsglMZKInwwUDsg5C 0zZNE+nY83h6g7LxpOUJ8UcANHVAYj0X8pEg6OoS3pLgtdKVIzNS+kNq5paMK8HuHClr2Z Rn7MagRg2ontwQkgKkuI2p/awaBX58U= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=WfTgBWXl; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf08.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 134.134.136.31) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657840314; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZX/Aanw4ycjVcf2IAthiCbjbfTCNw+xKHW8Klbr5V0k=; b=M/O8A/A7JdmrH5YTOOWAtbYFHR3lsD2Zdtl7fmnQOd3hEoN35qN7OumuC+X+GjNK9ENpSw jcmW0rnh2dAru4rXovQalusvMAY4WPD0dAEHTpJ15UMlZC1FOKV//gCA3j/XShCebRj9uk JPu5md7fTgVXDHF/8axx4Q7vDeZao/M= X-Stat-Signature: fds5rqomb5ei4qmrrg8zsupskzxhwinm X-Rspam-User: X-Rspamd-Queue-Id: 02B9716006A Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=WfTgBWXl; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf08.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 134.134.136.31) smtp.mailfrom=lkp@intel.com X-Rspamd-Server: rspam11 X-HE-Tag: 1657840313-740194 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Theodore, I love your patch! Yet something to improve: [auto build test ERROR on akpm-mm/mm-everything] url: https://github.com/intel-lab-lkp/linux/commits/Theodore-Ts-o/mm-shmem-add-support-for-FS_IOC_-SG-ETFLAGS-for-tmpfs/20220713-225257 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20220715/202207150754.j4ldkYik-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/2a3164ac6dafb6c7a3cd8a1002e89370eec359c1 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Theodore-Ts-o/mm-shmem-add-support-for-FS_IOC_-SG-ETFLAGS-for-tmpfs/20220713-225257 git checkout 2a3164ac6dafb6c7a3cd8a1002e89370eec359c1 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All error/warnings (new ones prefixed by >>): mm/shmem.c: In function 'shmem_getattr': >> mm/shmem.c:1062:29: error: 'EXT2_APPEND_FL' undeclared (first use in this function); did you mean 'FS_APPEND_FL'? 1062 | if (info->fsflags & EXT2_APPEND_FL) | ^~~~~~~~~~~~~~ | FS_APPEND_FL mm/shmem.c:1062:29: note: each undeclared identifier is reported only once for each function it appears in >> mm/shmem.c:1064:29: error: 'EXT2_IMMUTABLE_FL' undeclared (first use in this function); did you mean 'FS_IMMUTABLE_FL'? 1064 | if (info->fsflags & EXT2_IMMUTABLE_FL) | ^~~~~~~~~~~~~~~~~ | FS_IMMUTABLE_FL >> mm/shmem.c:1066:29: error: 'EXT2_NODUMP_FL' undeclared (first use in this function); did you mean 'FS_NODUMP_FL'? 1066 | if (info->fsflags & EXT2_NODUMP_FL) | ^~~~~~~~~~~~~~ | FS_NODUMP_FL mm/shmem.c: At top level: >> mm/shmem.c:2840:5: warning: no previous prototype for 'shmem_fileattr_get' [-Wmissing-prototypes] 2840 | int shmem_fileattr_get(struct dentry *dentry, struct fileattr *fa) | ^~~~~~~~~~~~~~~~~~ >> mm/shmem.c:2851:5: warning: no previous prototype for 'shmem_fileattr_set' [-Wmissing-prototypes] 2851 | int shmem_fileattr_set(struct user_namespace *mnt_userns, | ^~~~~~~~~~~~~~~~~~ vim +1062 mm/shmem.c 1049 1050 static int shmem_getattr(struct user_namespace *mnt_userns, 1051 const struct path *path, struct kstat *stat, 1052 u32 request_mask, unsigned int query_flags) 1053 { 1054 struct inode *inode = path->dentry->d_inode; 1055 struct shmem_inode_info *info = SHMEM_I(inode); 1056 1057 if (info->alloced - info->swapped != inode->i_mapping->nrpages) { 1058 spin_lock_irq(&info->lock); 1059 shmem_recalc_inode(inode); 1060 spin_unlock_irq(&info->lock); 1061 } > 1062 if (info->fsflags & EXT2_APPEND_FL) 1063 stat->attributes |= STATX_ATTR_APPEND; > 1064 if (info->fsflags & EXT2_IMMUTABLE_FL) 1065 stat->attributes |= STATX_ATTR_IMMUTABLE; > 1066 if (info->fsflags & EXT2_NODUMP_FL) 1067 stat->attributes |= STATX_ATTR_NODUMP; 1068 stat->attributes_mask |= (STATX_ATTR_APPEND | 1069 STATX_ATTR_IMMUTABLE | 1070 STATX_ATTR_NODUMP); 1071 generic_fillattr(&init_user_ns, inode, stat); 1072 1073 if (shmem_is_huge(NULL, inode, 0)) 1074 stat->blksize = HPAGE_PMD_SIZE; 1075 1076 if (request_mask & STATX_BTIME) { 1077 stat->result_mask |= STATX_BTIME; 1078 stat->btime.tv_sec = info->i_crtime.tv_sec; 1079 stat->btime.tv_nsec = info->i_crtime.tv_nsec; 1080 } 1081 1082 return 0; 1083 } 1084 -- 0-DAY CI Kernel Test Service https://01.org/lkp