From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8031C43334 for ; Fri, 15 Jul 2022 07:30:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 35EA79401D1; Fri, 15 Jul 2022 03:30:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 30E5C9401A5; Fri, 15 Jul 2022 03:30:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D5F19401D1; Fri, 15 Jul 2022 03:30:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0D7249401A5 for ; Fri, 15 Jul 2022 03:30:09 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D2A722067E for ; Fri, 15 Jul 2022 07:30:08 +0000 (UTC) X-FDA: 79688510496.01.9DA66B4 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by imf25.hostedemail.com (Postfix) with ESMTP id 74ADAA0011 for ; Fri, 15 Jul 2022 07:30:08 +0000 (UTC) Received: by mail-ed1-f42.google.com with SMTP id fd6so5207678edb.5 for ; Fri, 15 Jul 2022 00:30:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CHnTn6VhmtnfWqf0g7Gj+G785dxWqdgYwW9ZzmaeJh4=; b=AVIZkYqmlFqGyQyc7TgsQ34JecaSIs4T8qLG5N3Hp0xrVzxcXrS3uzP60Pb8HTdcmT NNGLnCb4Z9g7363Stm9NWRyWEhV7UQj1cA1KUh9ersScVzQznP+DuLsHeTVH54CzogV6 sDh41C5MSXZZjAFvypRAwrByZXHmsniHxPdoY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CHnTn6VhmtnfWqf0g7Gj+G785dxWqdgYwW9ZzmaeJh4=; b=vQ1z/ukrtDwFnuUgkWEgqxMbtj3JI0Zf45i9nB62DwfPSKii1QXi4mBHhizqPFBxUa GF4UoPSZAs84pvUUSUjSNKA/FKAZkGdpptg2Kl1j00sDBCtlrN31k9eEU1a3rW+yMei/ X9N3YQD7uGYWTvaViogG0EOrW0x0EW/Noz97GidZ1koZrHc2S4LDWH6XBsL6gvgtCMha fbaA60oGWR1LSIYWpP+jrXDgc4CKZzs8iWt0cmyLzNVdTRABex8t4eY2tvafh1lXZp8M iOSVXzgQOueAamQUo5mEHrsqZGKsoE/oVRh3/da8jx+/7xmGIitJ1yVU5XWiR+fvZdWg 1nag== X-Gm-Message-State: AJIora/+Sib8w18mhqa4ScSePEYvjuRvfgMvMVHnM4hKMWgW7Fr0jsXt l7H+fr8dWbnyYuaaUEWQKIsrhw== X-Google-Smtp-Source: AGRyM1veMbMMZYqaMJnj/C70UuvPpYLJnS6n0L96smOnFkBPJaiYLrr37MwwvBcLdyxnSZvMMZunqw== X-Received: by 2002:aa7:c585:0:b0:43a:725b:9851 with SMTP id g5-20020aa7c585000000b0043a725b9851mr17229990edq.399.1657870207114; Fri, 15 Jul 2022 00:30:07 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.pdxnet.pdxeng.ch (host-80-182-13-224.retail.telecomitalia.it. [80.182.13.224]) by smtp.gmail.com with ESMTPSA id lb11-20020a170907784b00b007246492658asm1692756ejc.117.2022.07.15.00.30.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jul 2022 00:30:06 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: ltp@lists.linux.it, Jeroen Hofstee , lkp@intel.com, Richard Palethorpe , kernel test robot , lkp@lists.01.org, Jiri Slaby , Linux Memory Management List , Dario Binacchi , "David S. Miller" , Eric Dumazet , Greg Kroah-Hartman , Jakub Kicinski , Marc Kleine-Budde , Paolo Abeni , Sebastian Andrzej Siewior , Vincent Mailhol , Wolfgang Grandegger , linux-can@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v3] can: slcan: do not sleep with a spin lock held Date: Fri, 15 Jul 2022 09:29:51 +0200 Message-Id: <20220715072951.859586-1-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657870208; a=rsa-sha256; cv=none; b=Dkpz+or9hu5inccWsy8QcpqFYcndmp8/lA7DPYXZ49lPTB7C3LHOzthsI1pW2lkUYDq3Xp xfQojI32UilurL0ZA9+eDfX2ko45ueeRFwAizwuDDGKRDRcXL1hmjbWN2PUwsdiHb9f9hT XtagRXqklPrj/fhwatNIY/abwibRGWI= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=amarulasolutions.com header.s=google header.b=AVIZkYqm; dmarc=pass (policy=none) header.from=amarulasolutions.com; spf=pass (imf25.hostedemail.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657870208; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=CHnTn6VhmtnfWqf0g7Gj+G785dxWqdgYwW9ZzmaeJh4=; b=5uJpH+aeJU6TWEzrYHBz+AmAd1dCkVV/V1z+LCtvSuqt54PBPVEUYxTe8h0c43iluxMkbg 1QmHCksaDqhvAI0z8fQr1zntZSIp6rGD1qtci6Zz0IVnH5ZxGDuaaQm0OIKmBjfjFMVU3c VCZGy2Q16ZvF4K0U9nNlKB+Kld0LgHg= X-Stat-Signature: yp9gze4eb4kb9c74qo4n4crxxgkypywa X-Rspamd-Queue-Id: 74ADAA0011 Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=amarulasolutions.com header.s=google header.b=AVIZkYqm; dmarc=pass (policy=none) header.from=amarulasolutions.com; spf=pass (imf25.hostedemail.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1657870208-908609 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: We can't call close_candev() with a spin lock held, so release the lock before calling it. After calling close_candev(), we can update the fields of the private `struct can_priv' without having to acquire the lock. Fixes: c4e54b063f42f ("can: slcan: use CAN network device driver API") Reported-by: kernel test robot Link: https://lore.kernel.org/linux-kernel/Ysrf1Yc5DaRGN1WE@xsang-OptiPlex-9020/ Signed-off-by: Dario Binacchi --- Changes in v3: - Update the commit message. - Reset sl->rcount and sl->xleft before releasing the spin lock. Changes in v2: - Release the lock just before calling the close_candev(). drivers/net/can/slcan/slcan-core.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/can/slcan/slcan-core.c b/drivers/net/can/slcan/slcan-core.c index 54d29a410ad5..d40ddc596596 100644 --- a/drivers/net/can/slcan/slcan-core.c +++ b/drivers/net/can/slcan/slcan-core.c @@ -689,15 +689,14 @@ static int slc_close(struct net_device *dev) clear_bit(TTY_DO_WRITE_WAKEUP, &sl->tty->flags); } netif_stop_queue(dev); + sl->rcount = 0; + sl->xleft = 0; + spin_unlock_bh(&sl->lock); close_candev(dev); sl->can.state = CAN_STATE_STOPPED; if (sl->can.bittiming.bitrate == CAN_BITRATE_UNKNOWN) sl->can.bittiming.bitrate = CAN_BITRATE_UNSET; - sl->rcount = 0; - sl->xleft = 0; - spin_unlock_bh(&sl->lock); - return 0; } -- 2.32.0