From: kernel test robot <lkp@intel.com>
To: Theodore Ts'o <tytso@mit.edu>, Hugh Dickins <hughd@google.com>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Theodore Ts'o <tytso@mit.edu>
Subject: Re: [PATCH] mm/shmem: add support for FS_IOC_[SG]ETFLAGS for tmpfs
Date: Fri, 15 Jul 2022 07:01:23 +0800 [thread overview]
Message-ID: <202207150617.dHbSxB55-lkp@intel.com> (raw)
In-Reply-To: <20220713145234.2356641-1-tytso@mit.edu>
Hi Theodore,
I love your patch! Yet something to improve:
[auto build test ERROR on akpm-mm/mm-everything]
url: https://github.com/intel-lab-lkp/linux/commits/Theodore-Ts-o/mm-shmem-add-support-for-FS_IOC_-SG-ETFLAGS-for-tmpfs/20220713-225257
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
config: hexagon-randconfig-r024-20220714 (https://download.01.org/0day-ci/archive/20220715/202207150617.dHbSxB55-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 5e61b9c556267086ef9b743a0b57df302eef831b)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/2a3164ac6dafb6c7a3cd8a1002e89370eec359c1
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Theodore-Ts-o/mm-shmem-add-support-for-FS_IOC_-SG-ETFLAGS-for-tmpfs/20220713-225257
git checkout 2a3164ac6dafb6c7a3cd8a1002e89370eec359c1
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All error/warnings (new ones prefixed by >>):
>> mm/shmem.c:1062:22: error: use of undeclared identifier 'EXT2_APPEND_FL'
if (info->fsflags & EXT2_APPEND_FL)
^
>> mm/shmem.c:1064:22: error: use of undeclared identifier 'EXT2_IMMUTABLE_FL'
if (info->fsflags & EXT2_IMMUTABLE_FL)
^
>> mm/shmem.c:1066:22: error: use of undeclared identifier 'EXT2_NODUMP_FL'
if (info->fsflags & EXT2_NODUMP_FL)
^
>> mm/shmem.c:2840:5: warning: no previous prototype for function 'shmem_fileattr_get' [-Wmissing-prototypes]
int shmem_fileattr_get(struct dentry *dentry, struct fileattr *fa)
^
mm/shmem.c:2840:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int shmem_fileattr_get(struct dentry *dentry, struct fileattr *fa)
^
static
>> mm/shmem.c:2851:5: warning: no previous prototype for function 'shmem_fileattr_set' [-Wmissing-prototypes]
int shmem_fileattr_set(struct user_namespace *mnt_userns,
^
mm/shmem.c:2851:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int shmem_fileattr_set(struct user_namespace *mnt_userns,
^
static
2 warnings and 3 errors generated.
vim +/EXT2_APPEND_FL +1062 mm/shmem.c
1049
1050 static int shmem_getattr(struct user_namespace *mnt_userns,
1051 const struct path *path, struct kstat *stat,
1052 u32 request_mask, unsigned int query_flags)
1053 {
1054 struct inode *inode = path->dentry->d_inode;
1055 struct shmem_inode_info *info = SHMEM_I(inode);
1056
1057 if (info->alloced - info->swapped != inode->i_mapping->nrpages) {
1058 spin_lock_irq(&info->lock);
1059 shmem_recalc_inode(inode);
1060 spin_unlock_irq(&info->lock);
1061 }
> 1062 if (info->fsflags & EXT2_APPEND_FL)
1063 stat->attributes |= STATX_ATTR_APPEND;
> 1064 if (info->fsflags & EXT2_IMMUTABLE_FL)
1065 stat->attributes |= STATX_ATTR_IMMUTABLE;
> 1066 if (info->fsflags & EXT2_NODUMP_FL)
1067 stat->attributes |= STATX_ATTR_NODUMP;
1068 stat->attributes_mask |= (STATX_ATTR_APPEND |
1069 STATX_ATTR_IMMUTABLE |
1070 STATX_ATTR_NODUMP);
1071 generic_fillattr(&init_user_ns, inode, stat);
1072
1073 if (shmem_is_huge(NULL, inode, 0))
1074 stat->blksize = HPAGE_PMD_SIZE;
1075
1076 if (request_mask & STATX_BTIME) {
1077 stat->result_mask |= STATX_BTIME;
1078 stat->btime.tv_sec = info->i_crtime.tv_sec;
1079 stat->btime.tv_nsec = info->i_crtime.tv_nsec;
1080 }
1081
1082 return 0;
1083 }
1084
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-07-14 23:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 14:52 Theodore Ts'o
2022-07-13 19:11 ` Andrew Morton
2022-07-14 1:40 ` Theodore Ts'o
2022-07-14 2:24 ` [PATCH -v2] mm/shmem: support FS_IOC_[SG]ETFLAGS in tmpfs Theodore Ts'o
2022-07-15 1:59 ` [PATCH -v3] " Theodore Ts'o
2022-07-20 11:10 ` Theodore Ts'o
2022-07-20 16:59 ` Andrew Morton
2022-08-11 4:44 ` Hugh Dickins
2022-07-14 23:01 ` kernel test robot [this message]
2022-07-15 11:09 ` [PATCH] mm/shmem: add support for FS_IOC_[SG]ETFLAGS for tmpfs Arnd Bergmann
2022-07-15 11:36 ` Theodore Ts'o
2022-07-14 23:11 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202207150617.dHbSxB55-lkp@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-mm@kvack.org \
--cc=llvm@lists.linux.dev \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox