From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63AB3C43334 for ; Wed, 13 Jul 2022 15:45:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6F7B940148; Wed, 13 Jul 2022 11:45:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D1E08940134; Wed, 13 Jul 2022 11:45:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C0D6A940148; Wed, 13 Jul 2022 11:45:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B4B6F940134 for ; Wed, 13 Jul 2022 11:45:04 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7C4A73332A for ; Wed, 13 Jul 2022 15:45:04 +0000 (UTC) X-FDA: 79682500128.10.5BD71F3 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by imf28.hostedemail.com (Postfix) with ESMTP id 2CA48C007A for ; Wed, 13 Jul 2022 15:45:04 +0000 (UTC) Received: by mail-ed1-f45.google.com with SMTP id g1so14611196edb.12 for ; Wed, 13 Jul 2022 08:45:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=0RDV3LfY9Xy3Jm7IZZiFccn5WkHlef0xh/HmK2Mp+Vk=; b=LmfgKrINvMuZlEn8iqQZ6HTz4/4vGZBsH9SLwcu8sX9PonQhZBiBxh8DCeWKAiLQC+ /BzHsdGUcTbypRZkH4ipYSSiPo/BXDKF9BzxRia+hgVobwfLaiwTbS/MXU2oIVMvfUbQ L9nfav3udmn5ekoPnxs4iQq4PKnO+U5eZx0Rs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=0RDV3LfY9Xy3Jm7IZZiFccn5WkHlef0xh/HmK2Mp+Vk=; b=JtZTQGG/IfZCl8kTAX8uHj6cnkySdO8bzOZ7V5t0Jio+w2y2J68mkZbYnOYUwsloF8 1Vl1tJ1gR8bGxzt9UnY4QDP6xvgu+hbXn3yo+dK4tMIsBSJ8+5M9jLIG19xI+Ou2Pls8 F+pi7RFIU/2T7BxPIuSTsnaUp++OWTwMkP7M6t5jHsvbrt/O+weHiw8S4NBROI4pJXDm D2hMKU5+L+goRtaRJJ5EPC+d6b5Rgitub+lBcrb3v7e4hM9OD2l2TLCxBxpkqOibmrfj PyQ2fXOt/OoFkwaRmtnNzMWVywdQP3m3DK1RwRewlNCtpsgG5HTKDB47YInyET3ANU8Z xmnA== X-Gm-Message-State: AJIora/2E7ln+S3ymRTiqT8NvW4Lu73IUq2NxThhw/s8VITrZ1kunkBW A4ekEIkdKUCu3sG2QCZWe4aH1Q== X-Google-Smtp-Source: AGRyM1t3DmASLYur8LXJjGGYj+/MpBaNAz/lRVvtFJB89fZFe2d4pgQ0c2/XFlStz8o/Fp8tJfUASQ== X-Received: by 2002:a05:6402:28c4:b0:43a:cdde:e047 with SMTP id ef4-20020a05640228c400b0043acddee047mr5753304edb.368.1657727102841; Wed, 13 Jul 2022 08:45:02 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-80-182-13-224.pool80182.interbusiness.it. [80.182.13.224]) by smtp.gmail.com with ESMTPSA id 4-20020a170906300400b006fe9e717143sm5122181ejz.94.2022.07.13.08.45.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jul 2022 08:45:02 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: lkp@lists.01.org, Jeroen Hofstee , lkp@intel.com, kernel test robot , Richard Palethorpe , Linux Memory Management List , ltp@lists.linux.it, Dario Binacchi , "David S. Miller" , Eric Dumazet , Greg Kroah-Hartman , Jakub Kicinski , Jiri Slaby , Marc Kleine-Budde , Paolo Abeni , Sebastian Andrzej Siewior , Vincent Mailhol , Wolfgang Grandegger , linux-can@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v2] can: slcan: do not sleep with a spin lock held Date: Wed, 13 Jul 2022 17:44:58 +0200 Message-Id: <20220713154458.253076-1-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657727104; a=rsa-sha256; cv=none; b=X7FG944HY7OHm3e1rbQ9C7Bc3RBY3/qOuzWzx3gP9hHpt1yV7LFRBd6I9pa4S2CcRxJ0cQ FgxNvV2W6/I2HQj8ykHUezkuv69nSBZ5STweohy5e8andzuygi6SA7Hmlh+l9+95Jjy6LB Ef76GxWBLejEj8sNGIHvIAIjA4cuwVk= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=amarulasolutions.com header.s=google header.b=LmfgKrIN; spf=pass (imf28.hostedemail.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (policy=none) header.from=amarulasolutions.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657727104; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=0RDV3LfY9Xy3Jm7IZZiFccn5WkHlef0xh/HmK2Mp+Vk=; b=XdSDIq7oLFRTo8xeD0rYf082qjoc0P4fOLIQTW07O7XMQ4wZGK791mhdmQpOXcPRrHsL7u /zdZlmj0qMwLA4C0HqFnT7cOgNeb0r+Vde3OtG9n9g3Kb7+u27GADJ8g6KFY8DFbKoz1X9 RyPMnVB2IdEcxYEOuG9mXQRB0PE55Qc= X-Rspamd-Queue-Id: 2CA48C007A Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=amarulasolutions.com header.s=google header.b=LmfgKrIN; spf=pass (imf28.hostedemail.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (policy=none) header.from=amarulasolutions.com X-Rspamd-Server: rspam02 X-Rspam-User: X-Stat-Signature: q5xfdktgdoyw857udukwhn9nxicguq5e X-HE-Tag: 1657727104-667498 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: We can't call close_candev() with a spin lock held, so release the lock before calling it. Fixes: c4e54b063f42f ("can: slcan: use CAN network device driver API") Reported-by: kernel test robot Link: https://lore.kernel.org/linux-kernel/Ysrf1Yc5DaRGN1WE@xsang-OptiPlex-9020/ Signed-off-by: Dario Binacchi --- Changes in v2: - Release the lock just before calling the close_candev(). drivers/net/can/slcan/slcan-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/slcan/slcan-core.c b/drivers/net/can/slcan/slcan-core.c index 54d29a410ad5..5214421dedf3 100644 --- a/drivers/net/can/slcan/slcan-core.c +++ b/drivers/net/can/slcan/slcan-core.c @@ -689,6 +689,7 @@ static int slc_close(struct net_device *dev) clear_bit(TTY_DO_WRITE_WAKEUP, &sl->tty->flags); } netif_stop_queue(dev); + spin_unlock_bh(&sl->lock); close_candev(dev); sl->can.state = CAN_STATE_STOPPED; if (sl->can.bittiming.bitrate == CAN_BITRATE_UNKNOWN) @@ -696,7 +697,6 @@ static int slc_close(struct net_device *dev) sl->rcount = 0; sl->xleft = 0; - spin_unlock_bh(&sl->lock); return 0; } -- 2.32.0