From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FB1FC43334 for ; Wed, 13 Jul 2022 15:20:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7BE17940145; Wed, 13 Jul 2022 11:20:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 76EAD940134; Wed, 13 Jul 2022 11:20:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6379A940145; Wed, 13 Jul 2022 11:20:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 576F8940134 for ; Wed, 13 Jul 2022 11:20:15 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 265108078F for ; Wed, 13 Jul 2022 15:20:15 +0000 (UTC) X-FDA: 79682437590.22.F0BFAAD Received: from mail-oa1-f49.google.com (mail-oa1-f49.google.com [209.85.160.49]) by imf24.hostedemail.com (Postfix) with ESMTP id 795001800A7 for ; Wed, 13 Jul 2022 15:20:14 +0000 (UTC) Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-10bffc214ffso14457422fac.1 for ; Wed, 13 Jul 2022 08:20:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LKNJ81XHX1rVWPGtQSPsv7xkRycDjY6KgGLmlaN+gNY=; b=UGv5W4X0AgNs0e90Jxbuk8yoqkf1YIvPuG32cxJaOFdhOKMYtLT3UzjNMyJo3NmCSB h/K0iglgBA1TRNjZsaY3WPDnmRX23YpSMViygd9NRIhPlSo9yiPb+fbPadGOwbmeYz9x 0j6tumQO78ZJbjdyG1XX+ZjluB6BIV4JYujzA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LKNJ81XHX1rVWPGtQSPsv7xkRycDjY6KgGLmlaN+gNY=; b=SWMNkXARw3CFO2o/Dwu+ohry6zfl2dfmYJRTZ0pyvr7q8ZJCVHZMQaKj3Ig72T+0oH akrTireTjDlyzpGcRvnbJhY/LpzDXCxsacFClBvkqMM5MqpGC0NGxzr8yvpf+gT4l9qW YKX50M8MEnHBEG5V+8EOt6NQ/i38+4TXlHNp2bvlw5IQhnRnF6d91IuBcdPgMlhugJxs lvGrDoROzroL3oCJP5ZVqj4gop36RZy6+SDQq6UuebNzjX3fV+Akg0a7bkAPQsa6ugiF bUqRo3zY2ZfH7jn6q0xaiHU81r0PST8Gx1tQ4lB/0fDB5S9ng0XyZHro5eSmBMk1MF1f 4/aw== X-Gm-Message-State: AJIora8zr6Ux4xLV7cDIiPrzymmwAXtUJOALVqarHAaVLVSlU0QIeCjF 8ymSfGzGhYZP52xWPm2AzroIqg== X-Google-Smtp-Source: AGRyM1usHml13CDD+aHqFlxY8s5H+Eng7j9UX5kgdAqCwghIPyT60PRhwo1GRoZ8vA6nrb+/q/6Bdg== X-Received: by 2002:a05:6871:60c:b0:10b:ee7c:2e28 with SMTP id w12-20020a056871060c00b0010bee7c2e28mr4774059oan.21.1657725613728; Wed, 13 Jul 2022 08:20:13 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.pdxnet.pdxeng.ch (host-80-182-13-224.pool80182.interbusiness.it. [80.182.13.224]) by smtp.gmail.com with ESMTPSA id x24-20020a4a3f58000000b00432ac97ad09sm4895477ooe.26.2022.07.13.08.20.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jul 2022 08:20:12 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Richard Palethorpe , Jeroen Hofstee , Linux Memory Management List , kernel test robot , lkp@intel.com, lkp@lists.01.org, ltp@lists.linux.it, Dario Binacchi , "David S. Miller" , Eric Dumazet , Greg Kroah-Hartman , Jakub Kicinski , Jiri Slaby , Marc Kleine-Budde , Paolo Abeni , Sebastian Andrzej Siewior , Vincent Mailhol , Wolfgang Grandegger , linux-can@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH] can: slcan: do not sleep with a spin lock held Date: Wed, 13 Jul 2022 17:19:47 +0200 Message-Id: <20220713151947.56379-1-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657725614; a=rsa-sha256; cv=none; b=AHYVtCx9SrmonAB3669aR9fy8Yqi4AQVmPtA3ve3bV2sbiyQQ+664ErGY7VjL14HbpP397 242twR5uNyHnrdhk7K414U3klnZRMZ2jwnlUG99HTlcsUDZC/jG5wWIClvw3XcJ9OAjjev CXeXnWGUoMD+KUgJDkK0nSD6UICI/MY= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=amarulasolutions.com header.s=google header.b=UGv5W4X0; spf=pass (imf24.hostedemail.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.160.49 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (policy=none) header.from=amarulasolutions.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657725614; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=LKNJ81XHX1rVWPGtQSPsv7xkRycDjY6KgGLmlaN+gNY=; b=7z5Gnx41m/R1mNgR8fPI8plMc8ChTY3QjvuFy69N09aEoXb7VaCRLuR6mFn5Gwno12B4Cc H4XrNy+AeOUNrtz4wWhLSMOuuY0/Ob3hlAYQrUeFWXgJrcqCe6BGYUydy7daJdk6t2aTHD Mj114jm7o6uorVy/IXKjdlC7LtvYU20= X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 795001800A7 X-Rspam-User: Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=amarulasolutions.com header.s=google header.b=UGv5W4X0; spf=pass (imf24.hostedemail.com: domain of dario.binacchi@amarulasolutions.com designates 209.85.160.49 as permitted sender) smtp.mailfrom=dario.binacchi@amarulasolutions.com; dmarc=pass (policy=none) header.from=amarulasolutions.com X-Stat-Signature: ffrstd8mkab8no69cnj6ptuua3zu93sn X-HE-Tag: 1657725614-194226 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: We can't call close_candev() with a spin lock held, so release the lock before calling it. Fixes: c4e54b063f42f ("can: slcan: use CAN network device driver API") Reported-by: kernel test robot Link: https://lore.kernel.org/linux-kernel/Ysrf1Yc5DaRGN1WE@xsang-OptiPlex-9020/ Signed-off-by: Dario Binacchi --- drivers/net/can/slcan/slcan-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/slcan/slcan-core.c b/drivers/net/can/slcan/slcan-core.c index 54d29a410ad5..6aaf2986effc 100644 --- a/drivers/net/can/slcan/slcan-core.c +++ b/drivers/net/can/slcan/slcan-core.c @@ -688,6 +688,7 @@ static int slc_close(struct net_device *dev) /* TTY discipline is running. */ clear_bit(TTY_DO_WRITE_WAKEUP, &sl->tty->flags); } + spin_unlock_bh(&sl->lock); netif_stop_queue(dev); close_candev(dev); sl->can.state = CAN_STATE_STOPPED; @@ -696,7 +697,6 @@ static int slc_close(struct net_device *dev) sl->rcount = 0; sl->xleft = 0; - spin_unlock_bh(&sl->lock); return 0; } -- 2.32.0