From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBB23C43334 for ; Wed, 13 Jul 2022 19:11:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6BEC294015D; Wed, 13 Jul 2022 15:11:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 66EE0940134; Wed, 13 Jul 2022 15:11:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55E9294015D; Wed, 13 Jul 2022 15:11:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 46D2B940134 for ; Wed, 13 Jul 2022 15:11:27 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 13B0380655 for ; Wed, 13 Jul 2022 19:11:27 +0000 (UTC) X-FDA: 79683020214.26.F3455F5 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf25.hostedemail.com (Postfix) with ESMTP id 9076EA0082 for ; Wed, 13 Jul 2022 19:11:26 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id ADC44B820D7; Wed, 13 Jul 2022 19:11:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44D27C34114; Wed, 13 Jul 2022 19:11:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1657739483; bh=nJw01M1mf5W4wFcFeAl0QXZeCIODEHT5T/sXSIkb1+k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Xxx+eciYEfptww+Yi9yg1HZD/mbpGTxNNryw4y+ki96ETQWKPxm1S9mEu5eE1lSzW zpsFFTZfZxGoj9p+/wlZZy9J0Ky9Ucj527Ud5KBavkWWHp/SNqc1zP9JoU5/eweRqj PQPBscJO+eRMudphm+dx3mvHzLSNy0+jE2QXseSo= Date: Wed, 13 Jul 2022 12:11:22 -0700 From: Andrew Morton To: "Theodore Ts'o" Cc: Hugh Dickins , linux-mm@kvack.org Subject: Re: [PATCH] mm/shmem: add support for FS_IOC_[SG]ETFLAGS for tmpfs Message-Id: <20220713121122.a0cce6a35cdd734c3b2df12d@linux-foundation.org> In-Reply-To: <20220713145234.2356641-1-tytso@mit.edu> References: <20220713145234.2356641-1-tytso@mit.edu> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657739486; a=rsa-sha256; cv=none; b=PFZlCRifcjbdwYntp2eZKIb9zCXFVmCuECXCyG4ChM3Ke1LTId01vZXkoc3ApV6XV/mGwc qnh9hgAhk8GkNk5Z+WoVyuqB9oI3sPBVItDZebIgWHpsAmWAy7X9zmH9vV83IxeLuVWOeP 1rVqZm91vT1oINTJEJyOw7/asdRajpo= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Xxx+eciY; dmarc=none; spf=pass (imf25.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657739486; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NDSOOIqQb9G2N1906zBvt5OlyJKuaoKjcuqozWyh3Js=; b=Ia1IEVcWYEa3slloIPzsLFwJMECobUuJpYUXHx08wuP6Y2o1wi9ZaswtfAG92esSDBiH4O 270WT3yVbHIAjTyZo1IXcyZgvLjk2H0MmkvhzjJ8xyQFgNjIHwuJO2R3sB2CcbQzvbfBYg WJkbGpZOPVzjXgpoCAEnmqhNdHGu694= Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Xxx+eciY; dmarc=none; spf=pass (imf25.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspam-User: X-Stat-Signature: 5ai1ew1d4oxmftpqdzsf7pfnwnnbijad X-Rspamd-Queue-Id: 9076EA0082 X-Rspamd-Server: rspam08 X-HE-Tag: 1657739486-249516 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 13 Jul 2022 10:52:34 -0400 "Theodore Ts'o" wrote: > This allows userspace to set flags like FS_APPEND_FL, FS_IMMUTABLE_FL, > FS_NODUMP_FL, etc., like all other standard Linux file systems. > > ... > > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -28,6 +28,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -1058,6 +1059,15 @@ static int shmem_getattr(struct user_namespace *mnt_userns, > shmem_recalc_inode(inode); > spin_unlock_irq(&info->lock); > } > + if (info->fsflags & EXT2_APPEND_FL) > + stat->attributes |= STATX_ATTR_APPEND; > + if (info->fsflags & EXT2_IMMUTABLE_FL) > + stat->attributes |= STATX_ATTR_IMMUTABLE; > + if (info->fsflags & EXT2_NODUMP_FL) > + stat->attributes |= STATX_ATTR_NODUMP; > + stat->attributes_mask |= (STATX_ATTR_APPEND | > + STATX_ATTR_IMMUTABLE | > + STATX_ATTR_NODUMP); > generic_fillattr(&init_user_ns, inode, stat); > > if (shmem_is_huge(NULL, inode, 0)) hm, how did you even test this? mm/shmem.c: In function 'shmem_getattr': mm/shmem.c:1062:29: error: 'EXT2_APPEND_FL' undeclared (first use in this function); did you mean 'FS_APPEND_FL'? 1062 | if (info->fsflags & EXT2_APPEND_FL) | ^~~~~~~~~~~~~~ | FS_APPEND_FL this --- a/mm/shmem.c~mm-shmem-add-support-for-fs_ioc_etflags-for-tmpfs-fix-2 +++ a/mm/shmem.c @@ -40,6 +40,8 @@ #include #include "swap.h" +#include <../fs/ext2/ext2.h> + static struct vfsmount *shm_mnt; #ifdef CONFIG_SHMEM seems quite wrong.