From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2BB9C433EF for ; Wed, 13 Jul 2022 15:28:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 10C37940146; Wed, 13 Jul 2022 11:28:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BBAD940134; Wed, 13 Jul 2022 11:28:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EEE11940146; Wed, 13 Jul 2022 11:28:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E2342940134 for ; Wed, 13 Jul 2022 11:28:21 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A909E2113F for ; Wed, 13 Jul 2022 15:28:21 +0000 (UTC) X-FDA: 79682458002.18.BF12D48 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf28.hostedemail.com (Postfix) with ESMTP id 09A14C007C for ; Wed, 13 Jul 2022 15:28:20 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 1CAB7CE22E0; Wed, 13 Jul 2022 15:28:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C844C34114; Wed, 13 Jul 2022 15:28:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1657726095; bh=+sYtzRt5PQbQ0/p3DzT91u31zbs8+wzBS9KqY7HgVfg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Au5TqmDme4AtytyDA8z8kxa9rg4n/3/VpmMJ+XFR9S5EPMdIPdnPxtveFPYJ/eJ8j zBd3g4818o3kXssT4v/eAGjB/Z+KPNvBNuZvmONVzXrJyvd23JH0RjhOewN+mIhTGD wuayz/1LefEG3b5cgJXtAgXiYQ2gxvx3TBAPhniM= Date: Wed, 13 Jul 2022 08:28:14 -0700 From: Andrew Morton To: Chuyi Zhou Cc: linux-mm@kvack.org, Mel Gorman Subject: Re: [PATCH v3] mm/compaction: fix set skip in fast_find_migrateblock Message-Id: <20220713082814.bed234e00d7f5ceb3858352a@linux-foundation.org> In-Reply-To: <20220713062009.597255-1-zhouchuyi@bytedance.com> References: <20220713062009.597255-1-zhouchuyi@bytedance.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Au5TqmDm; dmarc=none; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657726101; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N0FM1o9BNdgg65YucmpGtrLs3X4KsR+jvburnkjZMAI=; b=jJ3cfNZV39bvylOo14HD+8kLgZJacWJjDtAbFGbHti408Vzh+tAf0/+66+luoUsAsqP/x0 Ib54np6YPhT1/DV1+h2ooBnf1tVs3cZK6ThRXpPoHLs4RGN6tWglbD+XujC274DCV5kKcA I1S+77bfIyomeMG9TD3GV3jhsYUc1tI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657726101; a=rsa-sha256; cv=none; b=xFpYySbP7YbatGEBPmMu/f85BraNEPblZVRR9a9sYNnguzdc6BOsNvoMMgvvyEFv/oj0jp 2wlJV6Kc9wX30fQ5lKIE08ZnZTckkP5opnWmb1c6CfqrjHRiab5QzgOXs66/X+ufkay+1j Y42cOntgaCbXFeuCYbD++pdMGLpzj2Q= X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 09A14C007C X-Stat-Signature: io4yryrz3ib8bgrzs4aux6bhyimbuezb Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Au5TqmDm; dmarc=none; spf=pass (imf28.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspam-User: X-HE-Tag: 1657726100-543716 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: (cc Mel) On Wed, 13 Jul 2022 14:20:09 +0800 Chuyi Zhou wrote: > From: zhouchuyi > > When we successfully find a pageblock in fast_find_migrateblock(), > the block will be set skip-flag through set_pageblock_skip(). However, > when entering isolate_migratepages_block(), the whole pageblock will > be skipped due to the branch > 'if (!valid_page && IS_ALIGNED(low_pfn, pageblock_nr_pages))'. > Eventually we will goto isolate_abort and isolate nothing. That cause > fast_find_migrateblock useless. > > In this Patch, when we find a suitable pageblock in fast_find_ > migrateblock, we do noting but let isolate_migratepages_block > to set skip flag to the pageblock after scan it. Normally, > we would isolate some pages from the fast-find block. > > I use mmtest/thpscale-madvhugepage test it. Here is the result: > baseline patch > Amean fault-both-1 1331.66 ( 0.00%) 1261.04 * 5.30%* > Amean fault-both-3 1383.95 ( 0.00%) 1191.69 * 13.89%* > Amean fault-both-5 1568.13 ( 0.00%) 1445.20 * 7.84%* > Amean fault-both-7 1819.62 ( 0.00%) 1555.13 * 14.54%* > Amean fault-both-12 1106.96 ( 0.00%) 1149.43 * -3.84%* > Amean fault-both-18 2196.93 ( 0.00%) 1875.77 * 14.62%* > Amean fault-both-24 2642.69 ( 0.00%) 2671.21 * -1.08%* > Amean fault-both-30 2901.89 ( 0.00%) 2857.32 * 1.54%* > Amean fault-both-32 3747.00 ( 0.00%) 3479.23 * 7.15%* > > Fixes: 70b44595eafe9 ("mm, compaction: use free lists to quickly locate a migration source") > > Signed-off-by: zhouchuyi > --- > mm/compaction.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index 962d05d1e187..abc7b0834471 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1850,7 +1850,6 @@ static unsigned long fast_find_migrateblock(struct compact_control *cc) > pfn = cc->zone->zone_start_pfn; > cc->fast_search_fail = 0; > found_block = true; > - set_pageblock_skip(freepage); > break; > } > } > -- > 2.20.1 >