linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Miaohe Lin <linmiaohe@huawei.com>
To: <akpm@linux-foundation.org>, <mike.kravetz@oracle.com>,
	<songmuchun@bytedance.com>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
	<linmiaohe@huawei.com>
Subject: [PATCH] mm/hugetlb: avoid corrupting page->mapping in hugetlb_mcopy_atomic_pte
Date: Tue, 12 Jul 2022 21:05:42 +0800	[thread overview]
Message-ID: <20220712130542.18836-1-linmiaohe@huawei.com> (raw)

In MCOPY_ATOMIC_CONTINUE case with a non-shared VMA, pages in the page
cache are installed in the ptes. But hugepage_add_new_anon_rmap is called
for them mistakenly because they're not vm_shared. This will corrupt the
page->mapping used by page cache code.

Fixes: f619147104c8 ("userfaultfd: add UFFDIO_CONTINUE ioctl")
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
 mm/hugetlb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 8d379e03f672..b232e1508e49 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -6038,7 +6038,7 @@ int hugetlb_mcopy_atomic_pte(struct mm_struct *dst_mm,
 	if (!huge_pte_none_mostly(huge_ptep_get(dst_pte)))
 		goto out_release_unlock;
 
-	if (vm_shared) {
+	if (page_in_pagecache) {
 		page_dup_file_rmap(page, true);
 	} else {
 		ClearHPageRestoreReserve(page);
-- 
2.23.0



             reply	other threads:[~2022-07-12 13:06 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-12 13:05 Miaohe Lin [this message]
2022-07-12 17:39 ` Mike Kravetz
2022-07-13  2:10   ` Miaohe Lin
2022-07-13 14:24   ` Peter Xu
2022-07-13 16:10     ` Peter Xu
2022-07-13 22:46       ` Axel Rasmussen
2022-07-13 23:36         ` Mike Kravetz
2022-07-14  0:20           ` Axel Rasmussen
2022-07-14 10:09             ` Miaohe Lin
2022-07-14 15:45               ` Peter Xu
2022-07-15  2:50                 ` Miaohe Lin
2022-07-13 17:23 ` Andrew Morton
2022-07-14  9:59   ` Miaohe Lin
2022-07-14 15:52     ` Peter Xu
2022-07-15  3:56       ` Miaohe Lin
2022-07-15 12:35         ` Peter Xu
2022-07-15 16:45           ` Axel Rasmussen
2022-07-15 17:07             ` Peter Xu
2022-07-15 17:28               ` Axel Rasmussen
2022-07-15 17:39                 ` Peter Xu
2022-07-15 17:51                   ` Axel Rasmussen
2022-07-16  1:32                     ` Miaohe Lin
2022-07-15 17:29               ` Mike Kravetz
2022-07-15 17:38                 ` Peter Xu
2022-07-16 23:06     ` Andrew Morton
2022-07-18  2:25       ` Miaohe Lin
2022-07-18 18:07         ` Axel Rasmussen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220712130542.18836-1-linmiaohe@huawei.com \
    --to=linmiaohe@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mike.kravetz@oracle.com \
    --cc=songmuchun@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox