* [PATCH] maple_tree: Fix mas_empty_area_rev() search exhaustion at root node
@ 2022-07-12 1:50 Liam Howlett
2022-07-12 11:51 ` Alexander Gordeev
0 siblings, 1 reply; 2+ messages in thread
From: Liam Howlett @ 2022-07-12 1:50 UTC (permalink / raw)
To: maple-tree, linux-mm, linux-kernel, Andrew Morton, Alexander Gordeev
When the possibilities of finding a gap are exhausted at the root node,
the error code was not returned which results in returning a range that
is currently occupied. Add the necessary check for the error code and
return to the caller.
Reported-by: Alexander Gordeev <agordeev@linux.ibm.com>
Fixes: d0aac5e48048 (Maple Tree: add new data structure)
Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
---
lib/maple_tree.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index 9dc4ffff18d0..14e9ab14c1da 100644
--- a/lib/maple_tree.c
+++ b/lib/maple_tree.c
@@ -5287,6 +5287,9 @@ int mas_empty_area_rev(struct ma_state *mas, unsigned long min,
}
}
+ if (mas_is_err(mas))
+ return xa_err(mas->node);
+
if (unlikely(mas->offset == MAPLE_NODE_SLOTS))
return -EBUSY;
--
2.35.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] maple_tree: Fix mas_empty_area_rev() search exhaustion at root node
2022-07-12 1:50 [PATCH] maple_tree: Fix mas_empty_area_rev() search exhaustion at root node Liam Howlett
@ 2022-07-12 11:51 ` Alexander Gordeev
0 siblings, 0 replies; 2+ messages in thread
From: Alexander Gordeev @ 2022-07-12 11:51 UTC (permalink / raw)
To: Liam Howlett; +Cc: maple-tree, linux-mm, linux-kernel, Andrew Morton
On Tue, Jul 12, 2022 at 01:50:36AM +0000, Liam Howlett wrote:
> When the possibilities of finding a gap are exhausted at the root node,
> the error code was not returned which results in returning a range that
> is currently occupied. Add the necessary check for the error code and
> return to the caller.
>
> Reported-by: Alexander Gordeev <agordeev@linux.ibm.com>
> Fixes: d0aac5e48048 (Maple Tree: add new data structure)
> Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
> ---
> lib/maple_tree.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index 9dc4ffff18d0..14e9ab14c1da 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -5287,6 +5287,9 @@ int mas_empty_area_rev(struct ma_state *mas, unsigned long min,
> }
> }
>
> + if (mas_is_err(mas))
> + return xa_err(mas->node);
> +
> if (unlikely(mas->offset == MAPLE_NODE_SLOTS))
> return -EBUSY;
Tested-by: Alexander Gordeev <agordeev@linux.ibm.com>
Thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-12 11:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-12 1:50 [PATCH] maple_tree: Fix mas_empty_area_rev() search exhaustion at root node Liam Howlett
2022-07-12 11:51 ` Alexander Gordeev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox