From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 295CFC43334 for ; Mon, 11 Jul 2022 12:32:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE5DF6B00DB; Mon, 11 Jul 2022 08:32:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A96436B00DC; Mon, 11 Jul 2022 08:32:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95D136B00DD; Mon, 11 Jul 2022 08:32:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 83B856B00DB for ; Mon, 11 Jul 2022 08:32:24 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 5A9E2120A7E for ; Mon, 11 Jul 2022 12:32:24 +0000 (UTC) X-FDA: 79674757008.09.86150C0 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by imf29.hostedemail.com (Postfix) with ESMTP id 069AE120069 for ; Mon, 11 Jul 2022 12:32:22 +0000 (UTC) Received: by mail-pj1-f52.google.com with SMTP id z12-20020a17090a7b8c00b001ef84000b8bso8160051pjc.1 for ; Mon, 11 Jul 2022 05:32:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vjEIDYTwgzQwUXH2f68J7EYDQYkAJzHrlxM7OU8I4+M=; b=GOLxIBW2h9pIhKAtwi39ZgJaKyQ3t0urb663wt246UFYfA0hhGaaH8fbLvvOqQP2O6 kTv/1yWEj3Ttw4OrDeIvhu5ftHnSR9CpTUXXPZsAzfSRci03RN/tae/Tm057MMYcdi6R ZExNYUhkyGpmsnDpP7nj8kyZUxZAOoxw+h4u63kbo6rgmg+4DfO8ZjKbskcOAwCd7iZ8 0JuDS4SdBFhODsYsgZYZyBzWe+buUYM59T8eiqzfYR93EzkJc5nbL2d9JpDgY+g3NF7i C7FGaufD+u4b8ZCBHVRU4yqkx4007RBv8+Rm3UES6CGSfd8WlC96gN/MinQbPeWv8nfH X5FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vjEIDYTwgzQwUXH2f68J7EYDQYkAJzHrlxM7OU8I4+M=; b=bmd03fQb+GvoHwlJCLdY7n+M3dTYdZo76f8Ysd4WM8EUMG9tBT1Q0LTgvszaly+rvc QO24STsUNzR5eO7wtJ7q3LvIxj43Ic6BifQP+Q3Ly558Eb/K+AzELIPZz3D8CeAktM9N 29Y3Dr2cNb+Dt1f0KA5DmrMqsShxn/kAUc9ObLtjRBHJ0JKY+aiFEKizQzLNZl0YjeKZ wWIT8vDMuTCf37mSDR95Qd5A6yf65Wz2oo6FfxNOCPq13+couIG3ORj0ENxlntTd95Fm GIzTfOHhX7C3h8hiH4AlPqwKs4A1L4Lw2KgcoUSm7jxd3AalfGt5nvTkW+jCWKOjBb6n lZ4Q== X-Gm-Message-State: AJIora+ZraDNoY8xCNlfHrurA6Gsl9o6baUoPxBAWt9r81vBq2iwyf4I 4gYim6XG8iTEJ1OZ/AYw5s6+zIwecP/OAQ== X-Google-Smtp-Source: AGRyM1tDh7E1+OmqIoTAHnZZk6TYgb1s6nv01qLwCLJBaHxsmHSu7JlzIO873YX5vgkvsCs1LfUHZQ== X-Received: by 2002:a17:90b:1094:b0:1ef:ab92:2af2 with SMTP id gj20-20020a17090b109400b001efab922af2mr17821647pjb.227.1657542741352; Mon, 11 Jul 2022 05:32:21 -0700 (PDT) Received: from n248-144-242.byted.org. ([121.30.179.140]) by smtp.gmail.com with ESMTPSA id z11-20020a63c04b000000b00415e47f82e7sm3139418pgi.60.2022.07.11.05.32.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jul 2022 05:32:20 -0700 (PDT) From: Zhou Chuyi To: linux-mm@kvack.org Cc: linmiaohe@huawei.com, zhouchuyi Subject: [PATCH] mm/compaction: fix set skip in fast_find_migrateblock Date: Mon, 11 Jul 2022 20:32:13 +0800 Message-Id: <20220711123213.66068-1-zhouchuyi@bytedance.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657542744; a=rsa-sha256; cv=none; b=nzdE8wYwmKZYZishvAL5lijHx+oHY92BKt0wga5f6NFh0OqWU+EdwHkYFBhWbYJWojOR9B hLGrgmivw85ZSS0aDygpDGM15dcbG75qLCCvLxbDzL2RJb/2zydpvPvO63CVEPYKYDpImU 4DpeGlkhbgihE7bbx6QHxt4ziFuxgxM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657542744; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=vjEIDYTwgzQwUXH2f68J7EYDQYkAJzHrlxM7OU8I4+M=; b=pP7PkNHq6RKlUuxMwuqe0yiO3kbOYRuGsvaR/jhIh9pb5mW55LPsYRsHJJgHaG9KNRo+7F 2H3USCvpSWhPCoXz/te93QisWkOQLz+1N/X5RHH7BHji8lInlTucoCpy8HTJF5gInOc2+h jSQI4OmJj2AZAcube4IAs/5TrjqSQ/M= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=GOLxIBW2; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf29.hostedemail.com: domain of zhouchuyi@bytedance.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=zhouchuyi@bytedance.com Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=GOLxIBW2; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf29.hostedemail.com: domain of zhouchuyi@bytedance.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=zhouchuyi@bytedance.com X-Rspamd-Server: rspam03 X-Stat-Signature: eo4q6ecfa73gkwyqwsat5rem8ctp6fjh X-Rspamd-Queue-Id: 069AE120069 X-Rspam-User: X-HE-Tag: 1657542742-105015 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: zhouchuyi When we successfully find a pageblock in fast_find_migrateblock(), the block will be set skip-flag through set_pageblock_skip(). However, when entering isolate_migratepages_block(), the whole pageblock will be skipped due to the branch 'if (!valid_page && IS_ALIGNED(low_pfn, pageblock_nr_pages))'. Eventually we will goto isolate_abort and isolate nothing. Signed-off-by: zhouchuyi --- mm/compaction.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/compaction.c b/mm/compaction.c index 1f89b969c..a1a2b50c8 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -1852,7 +1852,6 @@ static unsigned long fast_find_migrateblock(struct compact_control *cc) pfn = cc->zone->zone_start_pfn; cc->fast_search_fail = 0; found_block = true; - set_pageblock_skip(freepage); break; } } -- 2.20.1