From: Zhou Chuyi <zhouchuyi@bytedance.com>
To: linux-mm@kvack.org
Cc: linmiaohe@huawei.com, zhouchuyi <zhouchuyi@bytedance.com>
Subject: [PATCH] mm/compaction: fix set skip in fast_find_migrateblock
Date: Mon, 11 Jul 2022 20:32:13 +0800 [thread overview]
Message-ID: <20220711123213.66068-1-zhouchuyi@bytedance.com> (raw)
From: zhouchuyi <zhouchuyi@bytedance.com>
When we successfully find a pageblock in fast_find_migrateblock(), the block will be set skip-flag through set_pageblock_skip(). However, when entering isolate_migratepages_block(), the whole pageblock will be skipped due to the branch 'if (!valid_page && IS_ALIGNED(low_pfn, pageblock_nr_pages))'. Eventually we will goto isolate_abort and isolate nothing.
Signed-off-by: zhouchuyi <zhouchuyi@bytedance.com>
---
mm/compaction.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/compaction.c b/mm/compaction.c
index 1f89b969c..a1a2b50c8 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -1852,7 +1852,6 @@ static unsigned long fast_find_migrateblock(struct compact_control *cc)
pfn = cc->zone->zone_start_pfn;
cc->fast_search_fail = 0;
found_block = true;
- set_pageblock_skip(freepage);
break;
}
}
--
2.20.1
next reply other threads:[~2022-07-11 12:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 12:32 Zhou Chuyi [this message]
2022-07-12 2:26 ` Miaohe Lin
2022-07-12 8:44 ` [External] " 周俶易
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220711123213.66068-1-zhouchuyi@bytedance.com \
--to=zhouchuyi@bytedance.com \
--cc=linmiaohe@huawei.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox