From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C378C433EF for ; Tue, 12 Jul 2022 16:48:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D88269400A9; Tue, 12 Jul 2022 12:48:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3792940063; Tue, 12 Jul 2022 12:48:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD7D69400A9; Tue, 12 Jul 2022 12:48:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AEF5E940063 for ; Tue, 12 Jul 2022 12:48:49 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7350821004 for ; Tue, 12 Jul 2022 16:48:49 +0000 (UTC) X-FDA: 79679031978.28.79B3239 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf27.hostedemail.com (Postfix) with ESMTP id E21554007D for ; Tue, 12 Jul 2022 16:48:48 +0000 (UTC) Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26CCtUU0014903; Tue, 12 Jul 2022 14:01:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : content-type : mime-version; s=corp-2021-07-09; bh=bUcUoqfxTAR95/KiABZG7ABLW6Mm3TbBJ9ffeHS4/RU=; b=fKbh8/G9Kkqfm8nai8W50xUjLeF2k/ogbJTLudcX13x6KCyEQrWNT6J+DZG58kgRimIA oV1esAXz98YNLz1FOca8330UY63ijJhjert15aRU/ZJD0BwErd71NizpL5ktqp/V43o+ 1n6PhTK+qF99oF2YqyiayLkvWboQiWogOg1ennD4PjqUWq0RE4nlB59NSgVUsmNACVP0 X0cbHxAyjBFOjSLl2kadSCo6b1abo0RU0kn1YiVPEHigW2dpMkN7oqNa5cyPYolgPitE YcwHK8ijxsR5P3WfkwZLPjmwWBYqVjqRFts23Mi8m6uOQOkSgd3RBFSepGk2aPXGExXt Cw== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3h71rfxs6m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Jul 2022 14:01:37 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 26CE1ajC038401; Tue, 12 Jul 2022 14:01:36 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2040.outbound.protection.outlook.com [104.47.66.40]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id 3h7043fw9r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Jul 2022 14:01:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gsNlAB21SI+oOuRsfZOz17BnuuiHNjDy6DkEsC7xaw/asRejkIiXj86VHOcUAoTUc/NPvBjkaUTrl/Rq3Q3Z5c/cGENs0x9vLz1JyFg/42izLf5SBTzHkmIXzl+dKFWLHvolkPorsCRHFaqs6EtHwCSZska+j7C1AsAtTWRdRgWQolwM5btPLF/aBJKU0agn1Orb4zpEKFRrczYl8DKqboIbUGXOKLpUbmGoSftAhhfWSWAD1cJeuePin6aVZYL4znGwIfAg9fPVSlwHjZNgPzVbXixH7irowe+TCfthFxGP37U7pev3k4n1k0waN31kBE3hoS/qY4Y4ChvErEKQPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bUcUoqfxTAR95/KiABZG7ABLW6Mm3TbBJ9ffeHS4/RU=; b=O/bBKPz5hwXZJ9UCMSu3EMuwo1ltfjUhCWAz6C+ULoHuTTvcei4nJEF6NVTRb12KbygQfhkUfsqz7LKAOvwB0pxUfnrX+hikAozefXi6fBr5UTRI6jfbwq4W5tv43urekOakhgheAL4gXZIuQ414uoiVV1jVaYc8VjcIPlcAh/nQj0PzLxPwPEL6FXRhIwV+6iMwceMdtLy2QUzPPmIlKs706BMZ1mNML+hUhQwHk7s3znmNyffAcjhdr8UZA5zY/v5tJbsSTGkRq/sCHpUYS2Z5WU4qx0qO0gfAWgTRBH9gr/sm0drbiEwFrjKbZKP6GoiWM2EzXzwMK4wfQ+uO0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bUcUoqfxTAR95/KiABZG7ABLW6Mm3TbBJ9ffeHS4/RU=; b=SMF/tqlqCN1QpGt240DvyIXgobeUXvKpVjMpJS4SIX9SpH4YcDcC9uCem6jDdPcQswhLU+OIFPJnNNJbmWT2gsPyEThyqLLg04nm/7uCkoJRJTL64cN/y5rOYNhPrEusFZe5eySdyBBffJS9WOdh2fH00K2tVtr5vxeKuztBPAs= Received: from MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) by CY4PR10MB1704.namprd10.prod.outlook.com (2603:10b6:910:8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.23; Tue, 12 Jul 2022 14:01:32 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::5020:9b82:5917:40b]) by MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::5020:9b82:5917:40b%6]) with mapi id 15.20.5417.026; Tue, 12 Jul 2022 14:01:32 +0000 Date: Tue, 12 Jul 2022 17:01:21 +0300 From: Dan Carpenter To: kbuild@lists.01.org, Tyrone Ting Cc: lkp@intel.com, kbuild-all@lists.01.org, Linux Memory Management List , Wolfram Sang , Andy Shevchenko Subject: [linux-next:master 1342/8914] drivers/i2c/busses/i2c-npcm7xx.c:639 npcm_i2c_slave_enable() error: buffer overflow 'npcm_i2caddr' 2 <= 9 Message-ID: <202207110811.lWIJpo4l-lkp@intel.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-ClientProxiedBy: MR2P264CA0101.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:33::17) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bf033847-8517-41ed-f7fa-08da640f0627 X-MS-TrafficTypeDiagnostic: CY4PR10MB1704:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hUa4W/BLEhoBVDwiv1hJu8jLgjarxYJMUm0F1If0Fm43WZv/CFjoL3ngo0HDfY8lZRgk0gW9IZugQMuGgXmWpgOjj3LNjod/90ZJuZlrrfr9DLhLa2AM0BR8WKhBMq2pjtoYiulSUUvQouSvXDTtnUnT2wX4VVjbq23DbAN3owfErt1HYPyWAj42CDbI7BM6oT7QQ0GyYzFRLOH7Tk8kdttPSf5xC0+1P08/ybNaYnFUPXBVJFLtp8SwaSQVeXbp7zgOvQwgducB+2FGD0JZVdXH2u27zx6zWKVBBp8h8zaZUMpWMQP8FSGkcZ3CPQj6ewsvHPgpWDnYFXqC39OgK6+Yy3kSDNVB9V1uLs+ad6yBiJrPQCy4SVXUznrAH6nY4OqTt479mLYGS05kl7ceXvGNwgSqqbLZNVNBR/JfFEPd1Ltc68On699lacy2u4YDhEpoo+triAdAAoYkVah540wBvPzR3B42Pim9ay+WGB/cDtbKFd9beDEFwIdgGa535X4K5xMiS0D0uLRZVB84IMIp8MLrUU8GoMt9mvaZ5d6nBqRyIkAdabA7e25F1EN33Of6NgGSo4Jqh/+ioyCQcMrHab0VB5PifqgVj46+Ii+L5OFXlyLxWfGRRWvHqD6tv/wuP9OKSatlxbq4q0HjzbBgLRzEmPIeS5b35ukXeCrmo3n1G7N0stuCQ5zDxq+LCdQuW8KLaqqp29KXa4oY6UM/lXKvlgywNj6LA0CwgKOXkd62VgV/YiEtpE6KbW++h7h4iw6nQq5HrWbEhM0MXFauWllOKdUddGUyZPOLblBwjBWISf4wq8Rjj3jBVoE6p1Ep0a3a2v5qo3/3QRWcvMK/06FuvktxrXTFTcH2bHPMCpkaviXjh0mpapdzGlLIxv5QTwwB2lX4jcAsQh1evmdPcPajVJhQLMgW9AxFvo0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(346002)(366004)(376002)(136003)(39860400002)(9686003)(52116002)(6512007)(478600001)(26005)(5660300002)(6506007)(36756003)(6666004)(2906002)(966005)(41300700001)(8936002)(86362001)(6486002)(6916009)(44832011)(38100700002)(38350700002)(83380400001)(1076003)(186003)(54906003)(66476007)(66556008)(316002)(66946007)(8676002)(4326008)(70780200001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?b996pnx+TiU+vnmsw8GoYoIvwcVH82n/ECxt+VxIGJ7gBiKE2ZHeJWiOxSPB?= =?us-ascii?Q?uiJVZnxgXUnIgySbY6UAXa4hZmglI5aozn2C9nMg6jaW+gIoYWNDQ/CBym/2?= =?us-ascii?Q?f6SfOccbecK82M+qyGr17LYoJ1J0nV9A86lFtK4fE4O2o44RF1fTGk9PeLbS?= =?us-ascii?Q?wcc4kGJPgY5yFsVV3w7aHzeZl1YBsWE+m3A+gugJ2mrrXXa6J3CvLgV4SEvB?= =?us-ascii?Q?J48ZzgAzYjySNlPdOfFaPFu15bjCRNQoygu1H0nHWCAiZFSu4PWdQXqRhdAQ?= =?us-ascii?Q?8fGf8BP2YeDGCCGtBDNPKoweuYiTGrZ1vh1AXMi6PzXVGzzA59LnmLR037hn?= =?us-ascii?Q?ciwZYUHxnPomiWmGxp2u/SHoDEELYrQFkQMFeDL5kdoFfZDzOB7OVc11c/+q?= =?us-ascii?Q?etwrx+udt4l8RaLFA70SAV7wPsPHHul8YfhbZ0wf7m8EtXCIq/bsMwOOu3kb?= =?us-ascii?Q?boGpvqX5in8AA5vu2ERAteGRYAFCcag3d6+RDI4Vem+nQvYTX5ucOs72GDEA?= =?us-ascii?Q?GpYSC1vvy6k21612PKUDSJZYOO2k0Yobdc153q98HwdaoSr0ei9c/2yxV5M9?= =?us-ascii?Q?hzSwhYEOHJEr+X5iQn2IHE3P1HW1U2b75HkAFuwyPFoT3WJDtaXCt+hsdRw9?= =?us-ascii?Q?qVj8JTpfbvCC8E2YQNjYg/pBtpiqt5jLog0RJ7KgAQNlsYzjVO8d1t8Ewg3B?= =?us-ascii?Q?t7aT7WYQknuwr6d7nRQfo7fW5CMGrW32Ax4+ukYe5pTzYLzrryD3+YTIFlVT?= =?us-ascii?Q?WaYAHpcdg6HKydP+aiUX1MyDNawKPY5R3R/frOZC45sWpdm82VBWu57SBtt9?= =?us-ascii?Q?w1MTdeSDl0yPRMqFdSB5FMNDFbv0yxTGuhhWLx35nevNxH+nAsm7x30nkCXW?= =?us-ascii?Q?ozxdM4c3go2I6pkF8T7A4rKkqIX57o3mPxFoDTsx3Jx0/RzMAhmOlBJq7LK4?= =?us-ascii?Q?bJYj8BUccMwH3IaQjCTsR9fO3JoRK/wHg1SkjoZ4V32VsuuF5SZumHknlVip?= =?us-ascii?Q?QiDdyVIRCvfxOX6zw1soSX8iHGsvuZI05uBZkej7w4cGJ4IuyKlT3a2ri0Vi?= =?us-ascii?Q?zNftmSLbDbLUK9fMhZ+4ONArxWXp1/6Vretw34Fx/24zWec9d5/4Zvv7IP2U?= =?us-ascii?Q?6Ws6ebi/mUVD2wjQLecIXmIUTDTj/dRtQeaQtZm+6ab5fuCIFchFlslrGTWi?= =?us-ascii?Q?NMqozuEbUfZYK8tAy/qaTP5xgCm7zwFf7Aye18H8yL/9oL60Jc6rOyOBfg/T?= =?us-ascii?Q?VYu+VA14JiP4YpaPPeOrGqk0qOECD1ZcUyn87/7/+NU7lI/BpSBydjQnT8x6?= =?us-ascii?Q?MI5BSkBaJvpABJIlQ1dhq64EIQTIYwgxuV6MgJcM3TF2iLZPYXKm8C+5kW2b?= =?us-ascii?Q?Uq0XydlWOO++J7oEHHsDKrjz/jyT/zPDDHhBL3QRm9w6E8ab1NvA3kutRaZg?= =?us-ascii?Q?/OCyrK75iJ/v+42yzxZ2I1Gi2tubXVO66hbirvGO0/TkBV0+w4oN3R2FJKKm?= =?us-ascii?Q?cGIBJROKbkaZ6ln7TOrq/+Jn2ejBASqaILaiDANPK822zPUV72LdukZ6E8jb?= =?us-ascii?Q?iE1MJoTXtFphtr8HKqd4pdW7Pml33DiaFvRexT0ELeJ9jK+c1AUSDzVL4M0Y?= =?us-ascii?Q?Wg=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: bf033847-8517-41ed-f7fa-08da640f0627 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 14:01:32.0040 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NbzvbImRvUVRC9PqR3oxCu9pkUQOM+Vk/eE8fZQZraYvOxhOryemJdQWbgr1DOoES6CEbE50pNknajRA1f+fZeORqtwUPWh7S6gSPAjRxGI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB1704 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883 definitions=2022-07-12_08:2022-07-12,2022-07-12 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 suspectscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 malwarescore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207120055 X-Proofpoint-GUID: CTkov92eFHX4k35qBx_zD9ZnEp2178Dc X-Proofpoint-ORIG-GUID: CTkov92eFHX4k35qBx_zD9ZnEp2178Dc ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1657644529; a=rsa-sha256; cv=pass; b=uyBON7pxrL1vP/BQTKc2mHOlhw473JxJUtVWP60xZL713UpXs7/87/ZU+ZOLVTIgDc0QPa UHojIZkmMiiERHrDqMBIc7nIoyEjFrf2n8nz207D8NYEYcy9Siip4runl1XOSRP0uVRPZA sTOXZV9fX4kxZR2hhRiAlIe/gwkGahg= ARC-Authentication-Results: i=2; imf27.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b="fKbh8/G9"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b="SMF/tqlq"; spf=none (imf27.hostedemail.com: domain of dan.carpenter@oracle.com has no SPF policy when checking 205.220.165.32) smtp.mailfrom=dan.carpenter@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=none) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657644529; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=bUcUoqfxTAR95/KiABZG7ABLW6Mm3TbBJ9ffeHS4/RU=; b=ADlQX1jQja05G4dHaQt7iq8AZNZZ+BN+6S1s4S9C31kF4QLPHXbjLw6EwkFKPZG7FrrsgP QCYtfmWL+bVur9vjoIxRSwAahhKl6+FHgBgRw246xn+T+TV/cA1JozY1B4iHgKrzkD13el wjII4CVOeTNszKzqbUTTLpKj/+fLMbI= X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E21554007D X-Rspam-User: Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b="fKbh8/G9"; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b="SMF/tqlq"; spf=none (imf27.hostedemail.com: domain of dan.carpenter@oracle.com has no SPF policy when checking 205.220.165.32) smtp.mailfrom=dan.carpenter@oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=none) header.from=oracle.com X-Stat-Signature: 3y13d5e3zxic3rzccte5qoj6z3c39e76 X-HE-Tag: 1657644528-430759 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Tyrone, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: f2528c29385819a84480cacef4886b049761e2c5 commit: bbc38ed53a02a759d8e5c01e834eca49304a2315 [1342/8914] i2c: npcm: Support NPCM845 config: microblaze-randconfig-m031-20220706 (https://download.01.org/0day-ci/archive/20220711/202207110811.lWIJpo4l-lkp@intel.com/config) compiler: microblaze-linux-gcc (GCC) 11.3.0 If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot Reported-by: Dan Carpenter smatch warnings: drivers/i2c/busses/i2c-npcm7xx.c:639 npcm_i2c_slave_enable() error: buffer overflow 'npcm_i2caddr' 2 <= 9 vim +/npcm_i2caddr +639 drivers/i2c/busses/i2c-npcm7xx.c f54736925a4f83 Tali Perry 2020-05-27 607 static int npcm_i2c_slave_enable(struct npcm_i2c *bus, enum i2c_addr addr_type, f54736925a4f83 Tali Perry 2020-05-27 608 u8 addr, bool enable) f54736925a4f83 Tali Perry 2020-05-27 609 { f54736925a4f83 Tali Perry 2020-05-27 610 u8 i2cctl1; f54736925a4f83 Tali Perry 2020-05-27 611 u8 i2cctl3; f54736925a4f83 Tali Perry 2020-05-27 612 u8 sa_reg; f54736925a4f83 Tali Perry 2020-05-27 613 f54736925a4f83 Tali Perry 2020-05-27 614 sa_reg = (addr & 0x7F) | FIELD_PREP(NPCM_I2CADDR_SAEN, enable); f54736925a4f83 Tali Perry 2020-05-27 615 if (addr_type == I2C_GC_ADDR) { f54736925a4f83 Tali Perry 2020-05-27 616 i2cctl1 = ioread8(bus->reg + NPCM_I2CCTL1); f54736925a4f83 Tali Perry 2020-05-27 617 if (enable) f54736925a4f83 Tali Perry 2020-05-27 618 i2cctl1 |= NPCM_I2CCTL1_GCMEN; f54736925a4f83 Tali Perry 2020-05-27 619 else f54736925a4f83 Tali Perry 2020-05-27 620 i2cctl1 &= ~NPCM_I2CCTL1_GCMEN; f54736925a4f83 Tali Perry 2020-05-27 621 iowrite8(i2cctl1, bus->reg + NPCM_I2CCTL1); f54736925a4f83 Tali Perry 2020-05-27 622 return 0; 47d506d1a28fd1 Tali Perry 2022-05-25 623 } else if (addr_type == I2C_ARP_ADDR) { f54736925a4f83 Tali Perry 2020-05-27 624 i2cctl3 = ioread8(bus->reg + NPCM_I2CCTL3); f54736925a4f83 Tali Perry 2020-05-27 625 if (enable) f54736925a4f83 Tali Perry 2020-05-27 626 i2cctl3 |= I2CCTL3_ARPMEN; f54736925a4f83 Tali Perry 2020-05-27 627 else f54736925a4f83 Tali Perry 2020-05-27 628 i2cctl3 &= ~I2CCTL3_ARPMEN; f54736925a4f83 Tali Perry 2020-05-27 629 iowrite8(i2cctl3, bus->reg + NPCM_I2CCTL3); f54736925a4f83 Tali Perry 2020-05-27 630 return 0; f54736925a4f83 Tali Perry 2020-05-27 631 } 47d506d1a28fd1 Tali Perry 2022-05-25 632 if (addr_type > I2C_SLAVE_ADDR2 && addr_type <= I2C_SLAVE_ADDR10) 47d506d1a28fd1 Tali Perry 2022-05-25 633 dev_err(bus->dev, "try to enable more than 2 SA not supported\n"); This prints an error message for values 2-10, but allows 0-1,11,12. Maybe the intention here was to return -EINVAL? It seldom makes sense to print an error and then go forward with an out of bounds access. 47d506d1a28fd1 Tali Perry 2022-05-25 634 f54736925a4f83 Tali Perry 2020-05-27 635 if (addr_type >= I2C_ARP_ADDR) ^^^^^^^^^^^^ This is addr_type >= 11 so Smatch complains that npcm_i2caddr[] only has two elements. My personal Smatch run with the cross function DB says that addr_type is always 0 so it doesn't complain. However, one rule of kernel style is that we do not allow stub code and also to a human reader this code really does look buggy... :/ f54736925a4f83 Tali Perry 2020-05-27 636 return -EFAULT; 47d506d1a28fd1 Tali Perry 2022-05-25 637 f54736925a4f83 Tali Perry 2020-05-27 638 /* Set and enable the address */ f54736925a4f83 Tali Perry 2020-05-27 @639 iowrite8(sa_reg, bus->reg + npcm_i2caddr[addr_type]); f54736925a4f83 Tali Perry 2020-05-27 640 npcm_i2c_slave_int_enable(bus, enable); 47d506d1a28fd1 Tali Perry 2022-05-25 641 f54736925a4f83 Tali Perry 2020-05-27 642 return 0; f54736925a4f83 Tali Perry 2020-05-27 643 } -- 0-DAY CI Kernel Test Service https://01.org/lkp