From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35B7EC433EF for ; Fri, 8 Jul 2022 13:31:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B39486B0073; Fri, 8 Jul 2022 09:31:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AE8378E0002; Fri, 8 Jul 2022 09:31:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D7778E0001; Fri, 8 Jul 2022 09:31:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8FAFC6B0073 for ; Fri, 8 Jul 2022 09:31:31 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 4AC3060E5A for ; Fri, 8 Jul 2022 13:31:31 +0000 (UTC) X-FDA: 79664019582.13.F24DF02 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id B73CE1C0055 for ; Fri, 8 Jul 2022 13:31:30 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 941DB6272F; Fri, 8 Jul 2022 13:31:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 079C3C341C0; Fri, 8 Jul 2022 13:31:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657287089; bh=hGds4B+mCIAOpm1BnDxnLnmZBHrG70bhYx2KsmmxqIo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CetDsqfpap9TpmGYmlt51q4RIDsIk3g8CKBuY71/K8OZVND1iyEzsg2nVcVbb/JFr +zJh65zexDNPxKxlEr4mlBWIObet9ygfMwwLxGuIXUKjb37tyM8IaHsOPG3xbLEcM6 5ht0EdJqaTGydT5JTFa3JPYiAmFYAw+/ai5fSDVt0e9yPK0Cu3D5dCHyhi+B2rDkXL yBqJz3ElCgtLYCvigS6h5A16oPHBHWAfxctgTy4Ind+qLoNLkxRCjmRnAHBDfJsf7N Jl/rgCToCIZoDmK3TK+TpuxPUXmlYPyMHDMEx9ofe4EKS0vJ1tjDe8aY1qtJjVxR11 QSHndpPPMTj+A== Date: Fri, 8 Jul 2022 14:31:23 +0100 From: Will Deacon To: Peter Zijlstra Cc: Jann Horn , Linus Torvalds , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Dave Airlie , Daniel Vetter , Andrew Morton , Guo Ren , David Miller Subject: Re: [PATCH 2/4] csky/tlb: Remove tlb_flush() define Message-ID: <20220708133122.GC5989@willie-the-truck> References: <20220708071802.751003711@infradead.org> <20220708071834.019084831@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220708071834.019084831@infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657287091; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7mJHZTJ0ALNxNnPFJiVG+c9WPmkVGLtzy6hD461dSps=; b=tq01JmEprOpupOnFVElEi3b04KqAQMGhH9FRy5p6Rji+1rvDIxlXbqQ2RjXfB901hIzAo2 kf9jTYGHQ9YBWnBswnLJZh3maZp6npCJdYs8BYWoDMefhJcwBfVOPgOvDrxvVf/WAnkXUc nrDvaNWKQ6AJEKsD/ZdzZe+gY7IL080= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657287091; a=rsa-sha256; cv=none; b=vD/V44sYx3F5YZ9iQXoUuAVBbGYNy9zXSdGU5967/SfB5vy+BzAeGrppxT3BhdYJUM3xH2 aF5JYVdtuK6Al0ujCeqF6fImHLq4Ig7vlrHeCCMymg9O6rf6INYpR62klULZKiDUwefj26 DibB7nbLdHJiLe46dAXqBDivSrEBMwo= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CetDsqfp; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of will@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=will@kernel.org Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=CetDsqfp; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of will@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=will@kernel.org X-Stat-Signature: ktcuudjruyi157e6w8yoidbu3d9fuhpi X-Rspamd-Queue-Id: B73CE1C0055 X-Rspamd-Server: rspam07 X-Rspam-User: X-HE-Tag: 1657287090-886595 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 08, 2022 at 09:18:04AM +0200, Peter Zijlstra wrote: > The previous patch removed the tlb_flush_end() implementation which > used tlb_flush_range(). This means: > > - csky did double invalidates, a range invalidate per vma and a full > invalidate at the end > > - csky actually has range invalidates and as such the generic > tlb_flush implementation is more efficient for it. > > Signed-off-by: Peter Zijlstra (Intel) > --- > arch/csky/include/asm/tlb.h | 2 -- > 1 file changed, 2 deletions(-) > > --- a/arch/csky/include/asm/tlb.h > +++ b/arch/csky/include/asm/tlb.h > @@ -4,8 +4,6 @@ > #define __ASM_CSKY_TLB_H > > #include > -#define tlb_flush(tlb) flush_tlb_mm((tlb)->mm) Looks right to me, and the generic code handles the fullmm case when !CONFIG_MMU_GATHER_NO_RANGE so: Acked-by: Will Deacon Will