From: Will Deacon <will@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Jann Horn <jannh@google.com>,
Linus Torvalds <torvalds@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Dave Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Andrew Morton <akpm@linux-foundation.org>,
Guo Ren <guoren@kernel.org>, David Miller <davem@davemloft.net>
Subject: Re: [PATCH 2/4] csky/tlb: Remove tlb_flush() define
Date: Fri, 8 Jul 2022 14:31:23 +0100 [thread overview]
Message-ID: <20220708133122.GC5989@willie-the-truck> (raw)
In-Reply-To: <20220708071834.019084831@infradead.org>
On Fri, Jul 08, 2022 at 09:18:04AM +0200, Peter Zijlstra wrote:
> The previous patch removed the tlb_flush_end() implementation which
> used tlb_flush_range(). This means:
>
> - csky did double invalidates, a range invalidate per vma and a full
> invalidate at the end
>
> - csky actually has range invalidates and as such the generic
> tlb_flush implementation is more efficient for it.
>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> ---
> arch/csky/include/asm/tlb.h | 2 --
> 1 file changed, 2 deletions(-)
>
> --- a/arch/csky/include/asm/tlb.h
> +++ b/arch/csky/include/asm/tlb.h
> @@ -4,8 +4,6 @@
> #define __ASM_CSKY_TLB_H
>
> #include <asm/cacheflush.h>
> -#define tlb_flush(tlb) flush_tlb_mm((tlb)->mm)
Looks right to me, and the generic code handles the fullmm case when
!CONFIG_MMU_GATHER_NO_RANGE so:
Acked-by: Will Deacon <will@kernel.org>
Will
next prev parent reply other threads:[~2022-07-08 13:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 7:18 [PATCH 0/4] munmap() vs unmap_mapping_range() Peter Zijlstra
2022-07-08 7:18 ` [PATCH 1/4] mmu_gather: Remove per arch tlb_{start,end}_vma() Peter Zijlstra
2022-07-08 13:25 ` Will Deacon
2022-07-08 7:18 ` [PATCH 2/4] csky/tlb: Remove tlb_flush() define Peter Zijlstra
2022-07-08 13:31 ` Will Deacon [this message]
2022-07-08 7:18 ` [PATCH 3/4] mmu_gather: Let there be one tlb_{start,end}_vma() implementation Peter Zijlstra
2022-07-08 13:32 ` Will Deacon
2022-07-08 7:18 ` [PATCH 4/4] mmu_gather: Force tlb-flush VM_PFNMAP vmas Peter Zijlstra
2022-07-08 13:36 ` Will Deacon
2022-07-08 14:03 ` Peter Zijlstra
2022-07-08 14:04 ` Jann Horn
2022-07-09 8:38 ` Peter Zijlstra
2022-07-11 15:04 ` Jann Horn
2022-07-21 8:37 ` [PATCH 0/4] munmap() vs unmap_mapping_range() Peter Zijlstra
2022-07-21 17:46 ` Linus Torvalds
2022-07-21 17:52 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220708133122.GC5989@willie-the-truck \
--to=will@kernel.org \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=guoren@kernel.org \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
--cc=torvalds@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox