From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C25A6C433EF for ; Fri, 8 Jul 2022 20:08:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B6B86B0072; Fri, 8 Jul 2022 16:08:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 166C96B0073; Fri, 8 Jul 2022 16:08:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 056398E0001; Fri, 8 Jul 2022 16:08:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EDC006B0072 for ; Fri, 8 Jul 2022 16:08:05 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id C3293120204 for ; Fri, 8 Jul 2022 20:08:05 +0000 (UTC) X-FDA: 79665018930.28.AA982FD Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf04.hostedemail.com (Postfix) with ESMTP id 52A7E4001A for ; Fri, 8 Jul 2022 20:08:05 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 05578B80522; Fri, 8 Jul 2022 20:08:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8DFB2C341C0; Fri, 8 Jul 2022 20:08:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1657310882; bh=vTpWxWFk/hwrY5iWwCtMuQKiizi77JlQz/Tb8GOwwGI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=wFYWjkV7ClzYFAPoUOgjcOAOl8Pxb7vSQ6uDW/BZujTRBMaUN49yO5+kuMzXLM4I4 k6PYoerdPZUdTOCeWyE7Ch5K/8LNqGgDERmED7QuMm3BP/KlKI04LWuBS8G1g+zuT6 8KpOz6hJYHjmYFNpXpiv5UiFGJqB3qoldZOQ8qfI= Date: Fri, 8 Jul 2022 13:08:01 -0700 From: Andrew Morton To: Adam Sindelar Cc: linux-mm@kvack.org, Adam Sindelar , David Vernet , kernel-team@fb.com Subject: Re: [PATCH] selftests/vm: fix va_128TBswitch.sh permissions Message-Id: <20220708130801.411ace64e0244a75f483a9f0@linux-foundation.org> In-Reply-To: <20220708090646.34927-1-adam@wowsignal.io> References: <20220708090646.34927-1-adam@wowsignal.io> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657310885; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iaBd49G33sai1KnPEMzaTxmq5Oy6I3/G2szQl+vA8vU=; b=vCbD628QAqQB5cYdrB5s6e9Z3xKDnLdbos2bnwQK2Dg1rv8BManccqcIJwUdrKF9c1Vg43 2wXZkr7/CPdhLKNtub8ADHNolAWK6Dxz+9fiDYkeRWVNTm3w+aPzsTo7odnqrdMOJ1repB vQn1F5v08YlofTZHxcvSMT8Tb3+ZdSo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657310885; a=rsa-sha256; cv=none; b=ohJIGXHcVrbOCRDEBuehWD9DmH6RnBamrUMzRelG2kkCm3/3TXXC8ZmK4CuD34zie93TfP AVWvgIIEniUZhuiHkm7gr7XTtfzNJff8oG/JhkFnhqjbVCuC22JKT+3xo406K0vRfjEHuc Owu0IcjQbEDZj0WZhAfByavQdZfo6JY= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=wFYWjkV7; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Queue-Id: 52A7E4001A Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=wFYWjkV7; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: ix9kb4cy8xp5oimw7d6ypkayfgq1ajjt X-HE-Tag: 1657310885-563139 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 8 Jul 2022 11:06:46 +0200 Adam Sindelar wrote: > Restores the +x bit to va_128TBswitch.sh, which got dropped from the > previous patch, somehow. > > Fixes: 1afd01d43efc3 ("selftests/vm: Only run 128TBswitch with 5-level > paging") > > Signed-off-by: Adam Sindelar > --- > tools/testing/selftests/vm/va_128TBswitch.sh | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > mode change 100644 => 100755 tools/testing/selftests/vm/va_128TBswitch.sh > > diff --git a/tools/testing/selftests/vm/va_128TBswitch.sh b/tools/testing/selftests/vm/va_128TBswitch.sh > old mode 100644 > new mode 100755 Half of tools/testing/selftests/vm/*.sh don't have the x bit set. They're invoked via `/bin/sh foo.sh', which is more robust. Can we hunt down and fix the invoking code? Might be as simple as --- a/tools/testing/selftests/vm/run_vmtests.sh~a +++ a/tools/testing/selftests/vm/run_vmtests.sh @@ -144,7 +144,7 @@ run_test() { local sep=$(echo -n "$title" | tr "[:graph:][:space:]" -) printf "%s\n%s\n%s\n" "$sep" "$title" "$sep" - "$@" + /bin/sh "$@" local ret=$? if [ $ret -eq 0 ]; then echo "[PASS]" _