From: Andrew Morton <akpm@linux-foundation.org>
To: Adam Sindelar <adam@wowsignal.io>
Cc: linux-mm@kvack.org, Adam Sindelar <ats@fb.com>,
David Vernet <void@manifault.com>,
kernel-team@fb.com
Subject: Re: [PATCH] selftests/vm: fix va_128TBswitch.sh permissions
Date: Fri, 8 Jul 2022 13:08:01 -0700 [thread overview]
Message-ID: <20220708130801.411ace64e0244a75f483a9f0@linux-foundation.org> (raw)
In-Reply-To: <20220708090646.34927-1-adam@wowsignal.io>
On Fri, 8 Jul 2022 11:06:46 +0200 Adam Sindelar <adam@wowsignal.io> wrote:
> Restores the +x bit to va_128TBswitch.sh, which got dropped from the
> previous patch, somehow.
>
> Fixes: 1afd01d43efc3 ("selftests/vm: Only run 128TBswitch with 5-level
> paging")
>
> Signed-off-by: Adam Sindelar <adam@wowsignal.io>
> ---
> tools/testing/selftests/vm/va_128TBswitch.sh | 0
> 1 file changed, 0 insertions(+), 0 deletions(-)
> mode change 100644 => 100755 tools/testing/selftests/vm/va_128TBswitch.sh
>
> diff --git a/tools/testing/selftests/vm/va_128TBswitch.sh b/tools/testing/selftests/vm/va_128TBswitch.sh
> old mode 100644
> new mode 100755
Half of tools/testing/selftests/vm/*.sh don't have the x bit set.
They're invoked via `/bin/sh foo.sh', which is more robust.
Can we hunt down and fix the invoking code? Might be as simple as
--- a/tools/testing/selftests/vm/run_vmtests.sh~a
+++ a/tools/testing/selftests/vm/run_vmtests.sh
@@ -144,7 +144,7 @@ run_test() {
local sep=$(echo -n "$title" | tr "[:graph:][:space:]" -)
printf "%s\n%s\n%s\n" "$sep" "$title" "$sep"
- "$@"
+ /bin/sh "$@"
local ret=$?
if [ $ret -eq 0 ]; then
echo "[PASS]"
_
next prev parent reply other threads:[~2022-07-08 20:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 9:06 Adam Sindelar
2022-07-08 20:08 ` Andrew Morton [this message]
2022-07-09 8:14 ` Adam Sindelar
2022-07-10 7:33 ` Adam Sindelar
2022-07-12 16:17 ` David Vernet
2022-07-22 8:11 ` Adam Sindelar
2022-07-26 22:01 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220708130801.411ace64e0244a75f483a9f0@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adam@wowsignal.io \
--cc=ats@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-mm@kvack.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox