From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A540C433EF for ; Fri, 8 Jul 2022 10:48:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41B6C6B0071; Fri, 8 Jul 2022 06:48:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CA496B0073; Fri, 8 Jul 2022 06:48:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BAAD6B0074; Fri, 8 Jul 2022 06:48:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1C64B6B0071 for ; Fri, 8 Jul 2022 06:48:36 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BB940102D for ; Fri, 8 Jul 2022 10:48:35 +0000 (UTC) X-FDA: 79663608990.14.F32447F Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf31.hostedemail.com (Postfix) with ESMTP id 424BD2002E for ; Fri, 8 Jul 2022 10:48:34 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id BEB5E1FD03; Fri, 8 Jul 2022 10:48:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1657277312; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q0Ec0Ulnhq52Ncd23SrWLzFENoz6LxdurNLcKnZxeNo=; b=W+JKNS7w5o6SLSwsxFMCO05yaxvWD/mKu6CANNQ6C2ur+5NYpucKp7fv2n9mc0qS3IG35C 7O1DhBiSse+eT/Gvt86jIoKHXf+GrpHku69cH4e4Zer4uBcAeuRm6cfEN9hwcf56hsrUf1 vYgrEhu+teFz5GoffjkWy3DRmMFOtn0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1657277312; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q0Ec0Ulnhq52Ncd23SrWLzFENoz6LxdurNLcKnZxeNo=; b=PZfug6P+R1osLhgh9oanDBqGjSBibcUmjA4oafVTm0nhENAqbl+EA/e0OX4F5/MVQQEboK yclWqK8/9dW0SOCw== Received: from suse.de (unknown [10.163.43.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 9565C2C141; Fri, 8 Jul 2022 10:48:31 +0000 (UTC) Date: Fri, 8 Jul 2022 11:48:29 +0100 From: Mel Gorman To: Dan Carpenter Cc: kbuild@lists.01.org, lkp@intel.com, kbuild-all@lists.01.org, Linux Memory Management List , Andrew Morton , Nicolas Saenz Julienne Subject: Re: [kbuild] [linux-next:master 7884/8197] mm/page_alloc.c:3813 rmqueue_pcplist() warn: inconsistent returns 'flags'. Message-ID: <20220708104829.GD15381@suse.de> References: <202207071103.r5a2F97A-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <202207071103.r5a2F97A-lkp@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657277314; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q0Ec0Ulnhq52Ncd23SrWLzFENoz6LxdurNLcKnZxeNo=; b=i1vyfRO/p5Gr7v6BpU2HFx9YwNMICcLSHMWtgmSgJe6PNed2g+0Or8kR9U84D3TBlkhMAo gN3aBZEZKAotjVG86PEdCbznmkOWoqYATLS456szCwlZp68/GA9KPAlpWHMTpS/L1WL6Cj 2A+UaZyAKjJDpcgZ2RqAHQHvjaLiHRw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657277314; a=rsa-sha256; cv=none; b=cvpllSY2RL+CZAvPx7GfnjoD6dXaCB8Vb2uDkGj3bt6kYyw2cBEioLSbHVkCIpsgPg9OUN OvFRD+inL7vBGF+hl75vEPfvSNh1mLSb3NZHjv3FWr0tho/qg/lc0PnMczWpucaXgIQEYN w2E28uBF6XGOyyCjtCru89jsH3LPsqI= ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=W+JKNS7w; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=PZfug6P+; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf31.hostedemail.com: domain of mgorman@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=mgorman@suse.de Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=W+JKNS7w; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=PZfug6P+; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf31.hostedemail.com: domain of mgorman@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=mgorman@suse.de X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 424BD2002E X-Stat-Signature: ydrnr45ycj86wr9xeqrh6d7cjfs6xbce X-Rspam-User: X-HE-Tag: 1657277314-808972 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 07, 2022 at 09:44:03AM +0300, Dan Carpenter wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 088b9c375534d905a4d337c78db3b3bfbb52c4a0 > commit: fdd1b94629bb5592abf40d0c7a572b58e4c0cadc [7884/8197] mm/page_alloc: protect PCP lists with a spinlock > config: i386-randconfig-m021 > compiler: gcc-11 (Debian 11.3.0-3) 11.3.0 > > If you fix the issue, kindly add following tag where applicable > Reported-by: kernel test robot > Reported-by: Dan Carpenter > Thanks Dan, I see Andrew has already merged a fix for this. --8<-- mm-page_alloc-protect-pcp-lists-with-a-spinlock-fix add missing local_unlock_irqrestore() on contention path Reported-by: kernel test robot Reported-by: Dan Carpenter Cc: Hugh Dickins Cc: Marcelo Tosatti Cc: Marek Szyprowski Cc: Mel Gorman Cc: Michal Hocko Cc: Minchan Kim Cc: Nicolas Saenz Julienne Cc: Vlastimil Babka Cc: Yu Zhao Signed-off-by: Andrew Morton --- mm/page_alloc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 3b819c2720f8..66b902fef364 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -3788,6 +3788,7 @@ static struct page *rmqueue_pcplist(struct zone *preferred_zone, pcp_trylock_prepare(UP_flags); if (!spin_trylock(&pcp->lock)) { pcp_trylock_finish(UP_flags); + local_unlock_irqrestore(&pagesets.lock, flags); return NULL; }