From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 344A6C433EF for ; Fri, 8 Jul 2022 07:00:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF2916B0073; Fri, 8 Jul 2022 03:00:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A7BEB6B0074; Fri, 8 Jul 2022 03:00:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91C496B0075; Fri, 8 Jul 2022 03:00:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 820416B0073 for ; Fri, 8 Jul 2022 03:00:26 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 480C12111D for ; Fri, 8 Jul 2022 07:00:26 +0000 (UTC) X-FDA: 79663034052.22.C9AD2E8 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by imf26.hostedemail.com (Postfix) with ESMTP id B712C14003F for ; Fri, 8 Jul 2022 07:00:25 +0000 (UTC) Received: by mail-pf1-f175.google.com with SMTP id l124so12408632pfl.8 for ; Fri, 08 Jul 2022 00:00:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=M5RE66zrdc/N0NBtgGFgV/bL4WegcaJZi2+sphyGLok=; b=FIuiHaiPXg7QDqSFtyF6OuChPFcFdIcMisknzrlnDq8HzZBfhgsjLVyV7RbU9yoUiD ts3SzbiQZzg7wJzoHtZ+ax4J7TRlPqLeaMAQUPIKVS4Uun9ZeVDm6DGSS0UaMj4/23w7 ORjoskWb/pJBuPBfMe/ye2FXZqMaRrjoB0qbxJfUFLZkqHRRWloEJ9bycl/XcKTrxMgJ I8l0IvM4Pc/WMzHU38+0BX3KakIJ9f59ZQ0bNV2EQzHDI7NIDG5qNog10RY6Bf9d052f lHWvNZI6tmQ0CdiFx8FeFhbBXhNncdEUxujTSc0qOO38uhHxfW0fi74KhnhsVjGzJTuI ilgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=M5RE66zrdc/N0NBtgGFgV/bL4WegcaJZi2+sphyGLok=; b=O64delhCxxkdCrQGxmviT8XE6P2FiXoO5StUECF7vHikiapz5XhpRXcTIeipLbHRY4 sjOMM9thVnCGn3SKBE8VlDpqirsSmmVD2vXkQLLG4QLPXNZU8V+bKPh9sY7Pz8mJJA2d /o6CqWOI45dOOzQm9uBHrKU8033Kr1MCvBxTrR8bInCbU8JLwFo9Sd6Q6EbwJDK68B4s N1ryTd0w79NFLSIkKO6H9pLVRYdwNxZDmMfaTPgHWbZILxDB6/KzpC0NF1HewA516jHJ KArjbj/gVK9phEngKgR8u6BBfWPGbDKFdxXDBcu+SxsmpXt0bTlboA4xuDsDGYL/PIbd BeMQ== X-Gm-Message-State: AJIora8OYYdrsK8JXv2LgKuHKlofflk8yPDANXEagy8qqXWXRAj+Hme2 fkr5BbZ+araOBIBeQOY+WUI= X-Google-Smtp-Source: AGRyM1uf7NHQjaeeca+DJ6oixV1QzXnzIK7AaL5emKlSjOMweKzPtb9tssIVlJVf5TC7BTLLInm8ag== X-Received: by 2002:aa7:8b51:0:b0:525:5132:8a84 with SMTP id i17-20020aa78b51000000b0052551328a84mr2206235pfd.45.1657263624676; Fri, 08 Jul 2022 00:00:24 -0700 (PDT) Received: from localhost.localdomain (47-72-206-164.dsl.dyn.ihug.co.nz. [47.72.206.164]) by smtp.gmail.com with ESMTPSA id d16-20020a170902b71000b0016a7b9558f7sm26513101pls.136.2022.07.08.00.00.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jul 2022 00:00:24 -0700 (PDT) From: Barry Song <21cnbao@gmail.com> To: namit@vmware.com Cc: 21cnbao@gmail.com, akpm@linux-foundation.org, arnd@arndb.de, catalin.marinas@arm.com, corbet@lwn.net, darren@os.amperecomputing.com, guojian@oppo.com, huzhanyuan@oppo.com, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lipeifeng@oppo.com, mgorman@suse.de, realmz6@gmail.com, v-songbaohua@oppo.com, will@kernel.org, x86@kernel.org, yangyicong@hisilicon.com, zhangshiming@oppo.com Subject: Re: [PATCH 2/4] mm: rmap: Allow platforms without mm_cpumask to defer TLB flush Date: Fri, 8 Jul 2022 18:59:57 +1200 Message-Id: <20220708065957.3859-1-21cnbao@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <67943544-6DAA-4C8A-A04D-029D2D36C318@vmware.com> References: <67943544-6DAA-4C8A-A04D-029D2D36C318@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657263625; a=rsa-sha256; cv=none; b=mWv/RvDKhCNK7SueGjXykXWWEZiHO82bpX1TN4hgowmj+CfoXfPeAgJNNFUSmBAtADoLpk IizApn/jXlZmmcPRJfssgVJJGCGeebePz+vkenB7CtWTheo0soe+zxdrSUuEIUpes6shTK pjBo1WhtiDseTJXu3Jc8NnUjFFb0oqo= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=FIuiHaiP; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.210.175 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657263625; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M5RE66zrdc/N0NBtgGFgV/bL4WegcaJZi2+sphyGLok=; b=IAYhOXfhb3kJ0sCy/rfplFjNXfTSfE7YqPEaDbRkfCmA8d0oQTcegU0CEl7zTT7wH8P2yX oPt5ujTxZEbId5SqKHC5tzwpo0+57LcBSwVorfBaOzbwQJX/qI2mVxIe7/EWtcPvOKjxRG F3FHzrQUsEBnM6W14el31+MSQSx/zU4= X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B712C14003F Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=FIuiHaiP; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.210.175 as permitted sender) smtp.mailfrom=21cnbao@gmail.com X-Stat-Signature: r1kbtkctw7hosounbau5cf8jux9c5ro3 X-Rspam-User: X-HE-Tag: 1657263625-224602 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > The cpumask_empty() is indeed just another memory access, which is most > likely ok. But wouldn’t adding something like CONFIG_ARCH_HAS_MM_CPUMASK > make the code simpler and (slightly, certainly slightly) more performant? Yep. good suggestion, Nadav. So the code will be as below, right? diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index be0b95e51df6..a91d73866238 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -81,6 +81,7 @@ config X86 select ARCH_HAS_KCOV if X86_64 select ARCH_HAS_MEM_ENCRYPT select ARCH_HAS_MEMBARRIER_SYNC_CORE + select ARCH_HAS_MM_CPUMASK select ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE select ARCH_HAS_PMEM_API if X86_64 select ARCH_HAS_PTE_DEVMAP if X86_64 diff --git a/mm/Kconfig b/mm/Kconfig index 169e64192e48..7bf54f57ca01 100644 --- a/mm/Kconfig +++ b/mm/Kconfig @@ -951,6 +951,9 @@ config ARCH_HAS_CURRENT_STACK_POINTER register alias named "current_stack_pointer", this config can be selected. +config ARCH_HAS_MM_CPUMASK + bool + config ARCH_HAS_VM_GET_PAGE_PROT bool diff --git a/mm/rmap.c b/mm/rmap.c index 5bcb334cd6f2..13d4f9a1d4f1 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -692,6 +692,10 @@ static bool should_defer_flush(struct mm_struct *mm, enum ttu_flags flags) if (!(flags & TTU_BATCH_FLUSH)) return false; +#ifndef CONFIG_ARCH_HAS_MM_CPUMASK + return true; +#endif + /* If remote CPUs need to be flushed then defer batch the flush */ if (cpumask_any_but(mm_cpumask(mm), get_cpu()) < nr_cpu_ids) should_defer = true; Thanks Barry