From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B1E4C43334 for ; Thu, 7 Jul 2022 22:17:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D13066B0072; Thu, 7 Jul 2022 18:17:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CC2736B0073; Thu, 7 Jul 2022 18:17:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B8ADE6B0074; Thu, 7 Jul 2022 18:17:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A739F6B0072 for ; Thu, 7 Jul 2022 18:17:21 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7622334117 for ; Thu, 7 Jul 2022 22:17:21 +0000 (UTC) X-FDA: 79661715882.02.2F92EEA Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf16.hostedemail.com (Postfix) with ESMTP id 0273B180035 for ; Thu, 7 Jul 2022 22:17:19 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BEE9D1FE4F; Thu, 7 Jul 2022 22:17:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1657232238; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NQHmVjONVW9HBKDyRt/r720zRRw/7ufnQWCuHyx0tgU=; b=AMLeYp46gfvG5OYYxmSHWOSsVg611S1x9HIxx7i+TiQtZPqjK2maEGSUNwIj/8obkAs562 OWF3HprbsH9qOre8WT3mc3sEyZpJnU9XWg00WpuULWoTPQI6yg5Turmn189fxjet5IkYMX CrpP8iAff/ueR9FinnanBd2Bd0ZETEQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1657232238; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NQHmVjONVW9HBKDyRt/r720zRRw/7ufnQWCuHyx0tgU=; b=m4FLEyUovO/d2M2Y+OmpP71OLh3JnFbHASJneI4PmA085VBRoatYjaKxq1b/EMn+MhkxMh nQihNDqak0uDA9Aw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5E63A13461; Thu, 7 Jul 2022 22:17:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id NUQBFm5bx2ImXwAAMHmgww (envelope-from ); Thu, 07 Jul 2022 22:17:18 +0000 Date: Fri, 8 Jul 2022 00:12:31 +0200 From: David Sterba To: "Fabio M. De Francesco" Cc: David Sterba , Chris Mason , Josef Bacik , Nick Terrell , linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ira Weiny , Andrew Morton , Matthew Wilcox , Kees Cook , Sebastian Andrzej Siewior , "James E. J. Bottomley" , Helge Deller , John David Anglin , linux-parisc@vger.kernel.org Subject: Re: [PATCH v6 0/2] btrfs: Replace kmap() with kmap_local_page() in zstd.c Message-ID: <20220707221231.GS15169@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, "Fabio M. De Francesco" , David Sterba , Chris Mason , Josef Bacik , Nick Terrell , linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ira Weiny , Andrew Morton , Matthew Wilcox , Kees Cook , Sebastian Andrzej Siewior , "James E. J. Bottomley" , Helge Deller , John David Anglin , linux-parisc@vger.kernel.org References: <20220706111520.12858-1-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220706111520.12858-1-fmdefrancesco@gmail.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657232240; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NQHmVjONVW9HBKDyRt/r720zRRw/7ufnQWCuHyx0tgU=; b=zink0KW7SxXK9WZj2IFJ9qcbAARlArUja6zz2BwiT+I4rDhgamjmJTZpEmmSePT5Ug6PTX HFBaSlVx9p7zAeDpRbxrPH5GVLJNXQqpUtHH+t9N4ZaxZd7KwP6vGxW9uX/pB67dvkQF7Y ZSQ2ahmxO2+XGuvFvVUx+dj8D1y/Q28= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657232240; a=rsa-sha256; cv=none; b=VNugHOBAELAhY6QHyxruc/J3ytewQauiXENgmYmOdya3eYAtwpn40bSsWd4U0XWs/7UVqw Wf2VtTclBClIDVvZtd+jqBelXBpdA6MlWf35Sn3vikawCy69iSR1PJOmQAxHAXO6ycxwJF HJJmbyQWUDRxQOQeu/jmr1V0eqUUI/g= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=AMLeYp46; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=m4FLEyUo; dmarc=none; spf=pass (imf16.hostedemail.com: domain of dsterba@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=dsterba@suse.cz Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=AMLeYp46; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=m4FLEyUo; dmarc=none; spf=pass (imf16.hostedemail.com: domain of dsterba@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=dsterba@suse.cz X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0273B180035 X-Stat-Signature: sba9uxbiw1muejixx8uzdou1zm6b5gyg X-Rspam-User: X-HE-Tag: 1657232239-406580 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 06, 2022 at 01:15:18PM +0200, Fabio M. De Francesco wrote: > This is a little series which serves the purpose to replace kmap() with > kmap_local_page() in btrfs/zstd.c. Actually this task is only accomplished > in patch 2/2. > > Instead patch 1/2 is a pre-requisite for the above-mentioned replacement, > however, above all else, it has the purpose to conform the prototypes of > __kunmap_{local,atomic}() to their own correct semantics. Since those > functions don't make changes to the memory pointed by their arguments, > change the type of those arguments to become pointers to const void. > > v5 -> v6: Delete an unnecessary assignment in 2/2 (thanks to Ira Weiny). > > v4 -> v5: Use plain page_address() for pages which cannot come from Highmem > (instead of kmapping them); remove unnecessary initializations to NULL > in 2/2 (thanks to Ira Weiny). > > v3 -> v4: Resend and add linux-mm to the list of recipients (thanks to > Andrew Morton). > > Fabio M. De Francesco (2): > highmem: Make __kunmap_{local,atomic}() take "const void *" > btrfs: Replace kmap() with kmap_local_page() in zstd.c Added to the kmap patch queue, thanks. With all the other conversion there are 5 patches highmem: Make __kunmap_{local,atomic}() take const void pointer btrfs: zstd: replace kmap() with kmap_local_page() btrfs: zlib: replace kmap() with kmap_local_page() in zlib_compress_pages() btrfs: zlib: replace kmap() with kmap_local_page() in zlib_decompress_bio() btrfs: replace kmap_atomic() with kmap_local_page() and there are no kmap or kmap_atomic left in fs/btrfs, scheduled for 5.20.