From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 309A6C43334 for ; Wed, 6 Jul 2022 13:45:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 271BF6B0071; Wed, 6 Jul 2022 09:45:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 220E76B0073; Wed, 6 Jul 2022 09:45:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 110716B0074; Wed, 6 Jul 2022 09:45:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 02CC36B0071 for ; Wed, 6 Jul 2022 09:45:13 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id B91DE6039D for ; Wed, 6 Jul 2022 13:45:12 +0000 (UTC) X-FDA: 79656796464.30.55F8044 Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) by imf07.hostedemail.com (Postfix) with ESMTP id 5CF1340011 for ; Wed, 6 Jul 2022 13:45:12 +0000 (UTC) Received: by mail-qt1-f173.google.com with SMTP id c13so18198703qtq.10 for ; Wed, 06 Jul 2022 06:45:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=YNuq2Uaie/OK3zaUA/7W+ZPsbCaletAcNjeFIsOaTwM=; b=hOf4/6bFE5NQdxKw+acUz60RFdssIMhhcoMUzbIT6pVqT8IUA6Yig3jRvaVf0YRzNz o5mPwNqO3ArLGZ6jBTqmvXW1t/L6EsgVi7pvdGuFCLdHQu4XmOM1vSAd0eBCUKo9WBif CfpjseWJq1ufprTfGGLNyD2XOLd4IZjmMIrj9yrXe5IdkRAODr8XxeIjhLi/QKnokBnC 7Kk5hGuaCbUVSkFbYZXwXc86/4Kk6PsqcoogvGJWEBHeUFjGGIMJ5nSlZNqVmC3H8u9R WL/tetz0A62BisMwocyW+9AngLN2UljQBB3WtRoCf0zRknuqhtDTrFSOpC/lX9BsyjZ8 fahA== X-Gm-Message-State: AJIora+V3ZMwYLXpi3lx2hAzY8eMaeWGXVIar2L03dJrgmHi5maLu5Ve cRvJtgUN29v91rOIclJBeUo= X-Google-Smtp-Source: AGRyM1veDxFdkDe3Y5bxrTT/rWu0fTmWftQWmzih0lDzCemwKE/EUn9elWlS08w7cccdg1geiUPCow== X-Received: by 2002:ad4:5bc4:0:b0:473:20d4:ee08 with SMTP id t4-20020ad45bc4000000b0047320d4ee08mr1564713qvt.6.1657115111499; Wed, 06 Jul 2022 06:45:11 -0700 (PDT) Received: from dev0025.ash9.facebook.com (fwdproxy-ash-006.fbsv.net. [2a03:2880:20ff:6::face:b00c]) by smtp.gmail.com with ESMTPSA id u4-20020a05620a430400b006a6d7c3a82esm30055468qko.15.2022.07.06.06.45.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jul 2022 06:45:11 -0700 (PDT) Date: Wed, 6 Jul 2022 06:45:08 -0700 From: David Vernet To: Adam Sindelar Cc: Andrew Morton , Suren Baghdasaryan , linux-mm@kvack.org, Adam Sindelar , kernel-team@fb.com Subject: Re: [PATCH v3] selftests/vm: fix errno handling in mrelease_test Message-ID: <20220706134508.xiqkgdidg433tybh@dev0025.ash9.facebook.com> References: <20220706095707.7539-1-adam@wowsignal.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220706095707.7539-1-adam@wowsignal.io> User-Agent: NeoMutt/20211029 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657115112; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YNuq2Uaie/OK3zaUA/7W+ZPsbCaletAcNjeFIsOaTwM=; b=3eeuOsjYubg3NGsUI3qSFZ2We2CUV/Z7bsIef+MRXt7OTcZvXWowkpgHQMLy2fcX2gcSWk 2bdyURzNod3ZNVLwLp07mYT1wTcQnG7M6hSE/kNO+qbsOw+RfJisZ8NAygak2kB4yqp2kw GauAb038j6auJ9MKfT2AiCXoI6tKaM0= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of dcvernet@gmail.com designates 209.85.160.173 as permitted sender) smtp.mailfrom=dcvernet@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657115112; a=rsa-sha256; cv=none; b=V8ZYyMsNBsjy7CyUYjM9XpVWFSVD83sGcrQvoTZooQMzq0Y+F3NQiEZepDT8+cNLPwi6N7 TdTtHQMUj0YbB4+BSllhrXUIRllKIwIwnEOe3qlNZ1XKQqgOb2lf0jbcJdXRVtwbbwLyCw xvY2XPfmfneMKabgWu/uSX01iu5Ih2c= X-Rspamd-Server: rspam11 X-Rspam-User: X-Stat-Signature: 8ejgh7md6d7em86zj344zfe7tm96ehez X-Rspamd-Queue-Id: 5CF1340011 Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of dcvernet@gmail.com designates 209.85.160.173 as permitted sender) smtp.mailfrom=dcvernet@gmail.com X-HE-Tag: 1657115112-281464 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 06, 2022 at 11:57:07AM +0200, Adam Sindelar wrote: > mrelease_test should return KSFT_SKIP when process_mrelease is not > defined, but due to a perror call consuming the errno, it returns > KSFT_FAIL. > > This patch decides the exit codes before calling perror. As requested on the v2 version of the patch, please also include a "Fixes" line here (see [0]): Fixes: 33776141b812 ("selftests: vm: add process_mrelease tests") [0]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes > > Signed-off-by: Adam Sindelar > --- > v1->v2: Fixed second instance in the same file > v2->v3: Fixed remaining instances of errno mishandling > > tools/testing/selftests/vm/mrelease_test.c | 16 +++++++++++----- > 1 file changed, 11 insertions(+), 5 deletions(-) > > diff --git a/tools/testing/selftests/vm/mrelease_test.c b/tools/testing/selftests/vm/mrelease_test.c > index 96671c2f7d48..6c62966ab5db 100644 > --- a/tools/testing/selftests/vm/mrelease_test.c > +++ b/tools/testing/selftests/vm/mrelease_test.c [...] Looks good otherwise, thanks. Reviewed-by: David Vernet