From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1101ECCA473 for ; Wed, 6 Jul 2022 19:07:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 72D556B0072; Wed, 6 Jul 2022 15:07:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6DDC06B0073; Wed, 6 Jul 2022 15:07:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5CC5A6B0074; Wed, 6 Jul 2022 15:07:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4AB4D6B0072 for ; Wed, 6 Jul 2022 15:07:17 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DFA8233700 for ; Wed, 6 Jul 2022 19:07:16 +0000 (UTC) X-FDA: 79657608072.18.9611310 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 7666C140035 for ; Wed, 6 Jul 2022 19:07:15 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8DAD961FEC; Wed, 6 Jul 2022 19:07:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66AECC3411C; Wed, 6 Jul 2022 19:07:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1657134434; bh=K38rVZ1m/HFXpPYNXoStTqJQXufHClahIpkV/lUJaus=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iu3oMjLgVa4VT0I8PzUHKZ8okMFKeXKQV5F7gYfc1Rs/y7wXKrjDwm9jifcHo2FwE OLlblTM1qQzekK4zwzsdoSBnhP9uPhaVqUQXy10GjMaeBtVNSXsnN9pqjplsY1CPF2 1lpdYlYRvtsiwk3uILEzHv7/7p11vvyIUoK5xbI8= Date: Wed, 6 Jul 2022 12:07:12 -0700 From: Andrew Morton To: "Fabio M. De Francesco" Cc: David Sterba , Chris Mason , Josef Bacik , Nick Terrell , linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ira Weiny , Matthew Wilcox , Kees Cook , Sebastian Andrzej Siewior , "James E. J. Bottomley" , Helge Deller , John David Anglin , linux-parisc@vger.kernel.org, David Sterba Subject: Re: [PATCH v6 1/2] highmem: Make __kunmap_{local,atomic}() take "const void *" Message-Id: <20220706120712.31b4313f17cb7ae08618c90e@linux-foundation.org> In-Reply-To: <20220706111520.12858-2-fmdefrancesco@gmail.com> References: <20220706111520.12858-1-fmdefrancesco@gmail.com> <20220706111520.12858-2-fmdefrancesco@gmail.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657134435; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W7ZbEmlw8w+6n1YU4dSmu8sxHsdlBMC3TvWwngxWekI=; b=H7WTMXePWY0BKzZB4D1+Guz4Sfo+QPjv6eaV41bCUA57koO7WXPVM13/NMxSlaHr36B4Hw gCurvhrIKtDT9giGyZ1BohyN9hs8Hbsko7aMu43SQZUm8I8Ru26pL36w2WEBr+/Ct6gzgI UPlS65ESwWqFEPKmZ/HL5kIyginGyv4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657134435; a=rsa-sha256; cv=none; b=uTu0RoagknDhmqja7IOLpV+zUnUFMuaiPUqOeNAprffkfy1Ycd1wgMm78VPXilgxsHPizB eKCbf/1iAwBSXOrBHGBn3KP1Wn6/87Lh/pnXB/vb+XTVm7XWDSc10CHcJk5qoYL+MF4RqW f1aAZ3PLAi4/EJ0ZxBkmg8ThgWfNthI= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=iu3oMjLg; dmarc=none; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Stat-Signature: ypaq55rgy87b9c71bfgh3gsij59a5hue X-Rspamd-Queue-Id: 7666C140035 X-Rspam-User: Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=iu3oMjLg; dmarc=none; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspamd-Server: rspam10 X-HE-Tag: 1657134435-853473 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 6 Jul 2022 13:15:19 +0200 "Fabio M. De Francesco" wrote: > __kunmap_ {local,atomic}() currently take pointers to void. However, this > is semantically incorrect, since these functions do not change the memory > their arguments point to. > > Therefore, make this semantics explicit by modifying the > __kunmap_{local,atomic}() prototypes to take pointers to const void. > > As a side effect, compilers will likely produce more efficient code. > Acked-by: Andrew Morton Please include this in the btrfs tree if/when [2/2] is added.