From: Andrew Morton <akpm@linux-foundation.org>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: David Sterba <dsterba@suse.com>, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
Nick Terrell <terrelln@fb.com>,
linux-btrfs@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Ira Weiny <ira.weiny@intel.com>,
Matthew Wilcox <willy@infradead.org>,
Kees Cook <keescook@chromium.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
"James E. J. Bottomley" <James.Bottomley@HansenPartnership.com>,
Helge Deller <deller@gmx.de>,
John David Anglin <dave.anglin@bell.net>,
linux-parisc@vger.kernel.org, David Sterba <dsterba@suse.cz>
Subject: Re: [PATCH v6 1/2] highmem: Make __kunmap_{local,atomic}() take "const void *"
Date: Wed, 6 Jul 2022 12:07:12 -0700 [thread overview]
Message-ID: <20220706120712.31b4313f17cb7ae08618c90e@linux-foundation.org> (raw)
In-Reply-To: <20220706111520.12858-2-fmdefrancesco@gmail.com>
On Wed, 6 Jul 2022 13:15:19 +0200 "Fabio M. De Francesco" <fmdefrancesco@gmail.com> wrote:
> __kunmap_ {local,atomic}() currently take pointers to void. However, this
> is semantically incorrect, since these functions do not change the memory
> their arguments point to.
>
> Therefore, make this semantics explicit by modifying the
> __kunmap_{local,atomic}() prototypes to take pointers to const void.
>
> As a side effect, compilers will likely produce more efficient code.
>
Acked-by: Andrew Morton <akpm@linux-foundation.org>
Please include this in the btrfs tree if/when [2/2] is added.
next prev parent reply other threads:[~2022-07-06 19:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 11:15 [PATCH v6 0/2] btrfs: Replace kmap() with kmap_local_page() in zstd.c Fabio M. De Francesco
2022-07-06 11:15 ` [PATCH v6 1/2] highmem: Make __kunmap_{local,atomic}() take "const void *" Fabio M. De Francesco
2022-07-06 19:07 ` Andrew Morton [this message]
2022-07-08 12:47 ` Helge Deller
2022-07-06 11:15 ` [PATCH v6 2/2] btrfs: Replace kmap() with kmap_local_page() in zstd.c Fabio M. De Francesco
2022-07-07 22:12 ` [PATCH v6 0/2] " David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220706120712.31b4313f17cb7ae08618c90e@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bigeasy@linutronix.de \
--cc=clm@fb.com \
--cc=dave.anglin@bell.net \
--cc=deller@gmx.de \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=fmdefrancesco@gmail.com \
--cc=ira.weiny@intel.com \
--cc=josef@toxicpanda.com \
--cc=keescook@chromium.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-parisc@vger.kernel.org \
--cc=terrelln@fb.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox